domkey 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e93f5beddbdb0fad6ae8e499a06a46dc177c23b3
-  data.tar.gz: 4a77a3c0434d61e3ce656babba4abfdfe2eb9853
+  metadata.gz: 6db2446775f3d86af13cba9df7fc019216d3839a
+  data.tar.gz: 7354d30f4de4efadde733996bb66d0e8bb9002d8
 SHA512:
-  metadata.gz: 3cc26e517caf10802fc411947b2de31ea5dc2ca06d6b4467fd8a4a81bc5f21ce7443f5dc17baac0836a84a193f630f028fae9375b550837660d6c5fe490ca1ab
-  data.tar.gz: 88deffe102eb2fa60e364cf7a59bdbd07b81997a54dda072d56653702f757909622fe77c9e3ffe55f8194136f18d915899fac384988fb019fa62e392a2b3ac41
+  metadata.gz: 1d0ae9df2963b01dfb954326d3375a9095c281ad68be78fd15cf836c02399b650be455f6367cec18971daef426858e0e44c60ebba8225f03ad4ce8106854915b
+  data.tar.gz: 9d24abfc09c0da8a15471c80d87225d06e11f03029c0fa37b06cbad1b40f42e71aa25e368b2e8daf59fa365ea8540d228fa3e177503afbfc6ba19ce4de1d872f

data/lib/domkey/version.rb

@@ -1,3 +1,3 @@
 module Domkey
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

data/lib/domkey/view/checkbox_group.rb

@@ -13,11 +13,15 @@ module Domkey
 
       private
 
-      # @api private
-      # unselects all checkboxes before setting it with desired value
-      def before_set
-        validate_scope
-        each { |o| o.set false }
+      def set_by_symbol value
+        case value
+        when FalseClass
+          each { |o| o.set false }
+        when TrueClass
+          return #noop
+        else
+          fail(Exception::NotImplementedError, "Unknown way of setting by value: #{value.inspect}")
+        end
       end
     end
   end

data/lib/domkey/view/option_selectable.rb

@@ -55,6 +55,8 @@ module Domkey
       # strategy for selecting OptionSelectable object
       def set_strategy value
         case value
+        when TrueClass, FalseClass, Symbol
+          set_by_symbol(value)
         when String, Regexp
           set_by_value(value)
         when Array
@@ -70,9 +72,16 @@ module Domkey
               set_by_value(value)
             end
           end
+        else
+          fail(Exception::NotImplementedError, "Unable to be set by this value: #{value.inspect}")
         end
       end
 
+      # true, false, or some symbol identifier
+      def set_by_symbol value
+        fail Exception::NotImplementedError, "Subclass responsible for implementing"
+      end
+
       # default strategy. set by value attribute
       def set_by_value value
         fail Exception::NotImplementedError, "Subclass responsible for implementing"

data/lib/domkey/view/option_selectable_group.rb

@@ -9,6 +9,10 @@ module Domkey
 
       include OptionSelectable
 
+      def before_set
+        validate_scope
+      end
+
       def set_by_index value
         [*value].each { |i| self[i.to_i].set(true) }
       end
@@ -23,10 +27,8 @@ module Domkey
               find { |o| o.value == value }
             when Regexp
               find { |o| o.value.match(value) }
-            else
-              false
             end
-        o ? o.element.set : fail(Exception::NotFoundError, "Element not found with value: #{v.inspect}")
+        o ? o.element.set : fail(Exception::NotFoundError, "Element not found with value: #{value.inspect}")
       end
 
       def value_by_default

data/lib/domkey/view/page_object.rb

@@ -81,7 +81,7 @@ module Domkey
       # @api private
       # delegate to element when element responds to message
       def method_missing(message, *args, &block)
-        if respond_to_missing?(message, false)
+        if element.respond_to?(message)
           element.__send__(message, *args, &block)
         else
           super
@@ -91,7 +91,7 @@ module Domkey
       # @api private
       # ruturn true when element.respond_to? message so we can delegate with confidence
       def respond_to_missing?(message, include_private = false)
-        element.respond_to?(message) ? true : false
+        element.respond_to?(message) || super
       end
 
       private
@@ -116,16 +116,16 @@ module Domkey
             rescue StandardError
               return package #suitecase exploded, proc returned
             end
-            if peeked_inside.respond_to?(:each_pair) # hash
+            if peeked_inside.kind_of?(Hash)
               return initialize_this peeked_inside
-            elsif peeked_inside.respond_to?(:wd) # watir element
+            elsif peeked_inside.kind_of?(Watir::Container)
               return lambda { peeked_inside }
-            elsif peeked_inside.respond_to?(:package) #pageobject
+            elsif peeked_inside.kind_of?(PageObject)
               return peeked_inside.package
             else
               fail Exception::Error, "package must be kind of hash, watirelement or pageobject but I got this: #{package}"
             end
-          elsif package.respond_to?(:package) #pageobject
+          elsif package.respond_to?(:package, true) #pageobject
             return package.package
           else
             fail Exception::Error, "package must be kind of hash, watirelement or pageobject but I got this: #{package}"

data/lib/domkey/view/radio_group.rb

@@ -13,9 +13,15 @@ module Domkey
 
       private
 
-      def before_set
-        validate_scope
+      def set_by_symbol value
+        case value
+        when FalseClass, TrueClass
+          return #noop
+        else
+          fail(Exception::NotImplementedError, "Unknown way of setting by value: #{value.inspect}")
+        end
       end
+
     end
   end
 end

data/lib/domkey/view/select_list.rb

@@ -7,6 +7,8 @@ module Domkey
 
       include OptionSelectable
 
+      private
+
       # by position in options array
       def set_by_index value
         [*value].each { |i| element.options[i].select }
@@ -42,12 +44,16 @@ module Domkey
         end
       end
 
-
-      def before_set
-        element.clear if element.multiple?
+      def set_by_symbol value
+        case value
+        when FalseClass
+          element.clear if element.multiple?
+        when TrueClass
+          return #noop
+        else
+          fail(Exception::NotImplementedError, "Unknown way of setting by value: #{value.inspect}")
+        end
       end
-
-
     end
   end
 end

data/lib/domkey/view/widgetry/dispatcher.rb

@@ -45,6 +45,14 @@ module Domkey
         end
       end
 
+      class Select < Dispatcher
+
+        def set value
+          original.select value
+        end
+
+      end
+
 
     end
   end

data/spec/checkbox_group_spec.rb

@@ -35,11 +35,8 @@ describe Domkey::View::CheckboxGroup do
       @v = CollectionAsPageObjectCheckboxGroupView.new
       @v.group.count.should == 3
       @v.group.to_a.each { |e| e.should be_kind_of(Domkey::View::PageObject) }
-    end
-
-    it 'initial value on test page' do
-      @v.group.value.should eql ['other']
-      @v.group.value(:value, :index, :label).should eql [value: 'other', index: 2, label: 'Other']
+      # clear all selections first
+      @v.group.set false
     end
 
     it 'set string' do
@@ -52,6 +49,19 @@ describe Domkey::View::CheckboxGroup do
       @v.group.value.should eql ['other']
     end
 
+    it 'set by not implemented symbol' do
+      expect { @v.group.set :hello_world }.to raise_error(Domkey::Exception::NotImplementedError)
+    end
+
+    it 'set appends by defulat' do
+      @v.group.set 'tomato'
+      @v.group.value.should eql ['tomato']
+      @v.group.set 'other'
+      @v.group.value.should eql ['tomato', 'other']
+      @v.group.set false
+      @v.group.value.should eql []
+    end
+
     it 'set array of strings or regexp' do
       @v.group.set ['tomato']
       @v.group.value.should eql ['tomato']

data/spec/option_selectable_spec.rb

@@ -17,6 +17,15 @@ describe Domkey::View::OptionSelectable do
       @widget.set('fake')
     end
 
+    it 'set by symbol' do
+      expect(@widget).to receive(:set_by_symbol)
+      @widget.set :hello_world
+    end
+
+    it 'set by not implemented strategy' do
+      expect { @widget.set Object.new }.to raise_error(Domkey::Exception::NotImplementedError)
+    end
+
     it 'set regex' do
       expect(@widget).to receive(:set_by_value)
       @widget.set(/fake/)
@@ -66,6 +75,10 @@ describe Domkey::View::OptionSelectable do
       expect { @widget.set(:value => 'fake') }.to raise_error(Domkey::Exception::NotImplementedError)
     end
 
+    it ':symbol' do
+      expect { @widget.set :hello_world }.to raise_error(Domkey::Exception::NotImplementedError)
+    end
+
   end
 
   context 'value' do

data/spec/page_object_delegates_spec.rb

@@ -9,22 +9,37 @@ describe Domkey::View::PageObject do
     goto_html("test.html")
   end
 
-  context 'delegate to element for missing methods' do
-    before :all do
-      @o = Domkey::View::PageObject.new -> { text_field(id: 'city1') }
-    end
+  context 'wrapping single watir elements' do
+
+    context 'dispatcher bridges set value and options messages' do
 
-    it 'should delegate to element when element responds' do
-      @o.should respond_to(:id)
-      @o.id.should eql 'city1'
+      it 'select' do
+        o = Domkey::View::PageObject.new -> { select_list(id: 'fruit_list') }
+        o.set 'Tomato'
+        o.value.should eql 'tomato'
+      end
 
-      @o.should respond_to(:click)
-      @o.click
     end
 
-    it 'should not delegate to element when element does not repsond' do
-      @o.should_not respond_to(:textaramabada)
-      expect { @o.textaramabada }.to raise_error(NoMethodError)
+    context 'delegate unimplmemented messages' do
+
+      before :all do
+        @o = Domkey::View::PageObject.new -> { text_field(id: 'city1') }
+      end
+
+      it 'should delegate to element when element responds' do
+        @o.should respond_to(:id)
+        @o.id.should eql 'city1'
+
+        @o.should respond_to(:click)
+        @o.click
+      end
+
+      it 'should not delegate to element when element does not repsond' do
+        @o.should_not respond_to(:textaramabada)
+        expect { @o.textaramabada }.to raise_error(NoMethodError)
+      end
     end
+
   end
 end

data/spec/radio_group_spec.rb

@@ -67,11 +67,21 @@ describe Domkey::View::RadioGroup do
       @v.group.value([:index, :label]).should eql [{:index=>0, :label=>"Cucumber"}]
     end
 
-    it 'set false has no effect' do
+    it 'set false noop' do
       @v.group.set false
       @v.group.value.should eql ['other']
     end
 
+    it 'set true noop' do
+      @v.group.set false
+      @v.group.value.should eql ['other']
+    end
+
+    it 'set by not implemented symbol errors' do
+      expect { @v.group.set :hello_world }.to raise_error(Domkey::Exception::NotImplementedError)
+    end
+
+
     it 'set empty array has no effect' do
       @v.group.set []
       @v.group.value.should eql ['other']

data/spec/select_list_spec.rb

@@ -25,13 +25,12 @@ describe Domkey::View::SelectList do
 
     before :each do
       goto_html("test.html")
+      @widget.set false
     end
 
-    it 'initial value on the test page' do
+    it 'initial example' do
+      @widget.set ["2", "3"]
       @widget.value.should eql ["2", "3"]
-    end
-
-    it 'initial value by keys on the test page' do
       # array
       @widget.value([:index, :text, :value]).should eql [{:index=>1, :text=>"English", :value=>"2"}, {:index=>2, :text=>"Norwegian", :value=>"3"}]
       # splat list
@@ -107,6 +106,10 @@ describe Domkey::View::SelectList do
       @widget.value.should eql ["1", "2", "", "Swedish"]
     end
 
+    it 'set by symbol' do
+      expect { @widget.set :hello_world }.to raise_error(Domkey::Exception::NotImplementedError)
+    end
+
     it 'options by default' do
       @widget.options.should eql ["1", "2", "3", "", "Swedish"]
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: domkey
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - rubytester
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-07 00:00:00.000000000 Z
+date: 2014-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: watir-webdriver