domain_validator 0.0.2 → 0.1.0

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.rspec
 Gemfile.lock
 InstalledFiles
 _yardoc

data/.travis.yml

@@ -4,6 +4,5 @@ rvm:
   - jruby-18mode # JRuby in 1.8 mode
   - jruby-19mode # JRuby in 1.9 mode
   - rbx-18mode
-  - rbx-19mode
   - 1.8.7
   - 2.0.0

data/README.md

@@ -1,6 +1,7 @@
 # DomainValidator
 
 [![Build Status](https://travis-ci.org/kdayton-/domain_validator.png?branch=master)](https://travis-ci.org/kdayton-/domain_validator)
+[![Code Climate](https://codeclimate.com/github/kdayton-/domain_validator.png)](https://codeclimate.com/github/kdayton-/domain_validator)
 
 Adds a DomainValidator to ActiveModel, allowing for easy validation of FQDNs
 
@@ -25,10 +26,23 @@ Add a domain validation to your ActiveModel enabled class
 
 ```ruby
 class User < ActiveRecord::Base
+  attr_accessible :domain
   validates :domain, :domain => true
 end
 ```
 
+DomainValidator can also perform a DNS check using ruby's built-in Resolv library
+
+```ruby
+class User < ActiveRecord::Base
+  attr_accessible :domain
+  validates :domain, :domain => {:verify_dns => true}
+
+  # Also supports a custom message when failing DNS check
+  # validates :domain, :domain => {:verify_dns => {:message => "DNS check failed"}}
+end
+```
+
 ## Examples
 
 ```ruby
@@ -39,6 +53,14 @@ user.domain = 'invalid*characters.com'
 user.valid? # => false
 ```
 
+## Compatibility
+
+DomainValidator is tested against:
+
+MRI 1.8.7, 1.9.3, 2.0.0  
+JRuby 1.8, 1.9  
+Rubinus 1.8
+
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -1,5 +1,5 @@
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 

data/domain_validator.gemspec

@@ -1,7 +1,7 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'domain_validator/version'
+require "domain_validator/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "domain_validator"

data/lib/domain_validator.rb

@@ -1 +1,2 @@
-require 'domain_validator/validator'
+require "domain_validator/dns_check"
+require "domain_validator/validator"

data/lib/domain_validator/dns_check.rb

@@ -0,0 +1,16 @@
+require "resolv"
+
+module DomainValidator
+  class DnsCheck
+
+    def self.has_record?(domain)
+      begin
+        Resolv::DNS.new.getaddress domain
+        return true
+      rescue Resolv::ResolvError => e
+        return false
+      end
+    end
+
+  end
+end

data/lib/domain_validator/validator.rb

@@ -1,5 +1,5 @@
-require 'active_model'
-require 'active_model/validator'
+require "active_model"
+require "active_model/validator"
 
 module DomainValidator
   class Validator < ActiveModel::EachValidator
@@ -7,14 +7,35 @@ module DomainValidator
     RE_DOMAIN = %r(^(?=.{1,255}$)[0-9A-Za-z](?:(?:[0-9A-Za-z]|-){0,61}[0-9A-Za-z])?(?:\.[0-9A-Za-z](?:(?:[0-9A-Za-z]|-){0,61}[0-9A-Za-z])?)+$)
 
     def validate_each(record, attr_name, value)
+      validate_domain_format(record, attr_name, value)
+      validate_domain_dns(record, attr_name, value) if options[:verify_dns]
+    end
+
+    def validate_domain_format(record, attr_name, value)
       valid_domain = is_valid_domain?(value)
-      record.errors.add(attr_name, options[:message] || "is invalid") and return unless valid_domain
+      record.errors.add(attr_name, options[:message] || "is invalid") unless valid_domain
+    end
+
+    def validate_domain_dns(record, attr_name, value)
+      valid_domain = has_dns_record?(value)
+      record.errors.add(attr_name, verify_dns_message || "does not have a DNS record") unless valid_domain
     end
 
     def is_valid_domain?(domain)
       domain =~ RE_DOMAIN
     end
 
+    def has_dns_record?(domain)
+      options[:verify_dns] ? DnsCheck.has_record?(domain) : true
+    end
+
+    def verify_dns_message
+      verify_dns = options[:verify_dns]
+      if verify_dns.is_a? Hash
+        verify_dns[:message] || options[:message]
+      end
+    end
+
   end
 end
 

data/lib/domain_validator/version.rb

@@ -1,3 +1,3 @@
 module DomainValidator
-  VERSION = [0, 0, 2].join "."
+  VERSION = [0, 1, 0].join "."
 end

data/spec/dns_check_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+module DomainValidator
+  describe DnsCheck do
+    describe '#has_record?' do
+
+      context "given a domain without a DNS record" do
+        it "should return false" do
+          DnsCheck.has_record?("a.com").should be_false
+        end
+      end
+
+      context "given a domain with a DNS record" do
+        it "should return true" do
+          DnsCheck.has_record?("example.com").should be_true
+        end
+      end
+
+    end
+  end
+end

data/spec/domain_validator_spec.rb

@@ -1,28 +1,5 @@
 require 'spec_helper'
-
-class User < Model
-  validates :domain, :domain => true
-end
-
-class UserAllowsNil < Model
-  validates :domain, :domain => {:allow_nil => true}
-end
-
-class UserAllowsNilFalse < Model
-  validates :domain, :domain => {:allow_nil => false}
-end
-
-class UserAllowsBlank < Model
-  validates :domain, :domain => {:allow_blank => true}
-end
-
-class UserAllowsBlankFalse < Model
-  validates :domain, :domain => {:allow_blank => false}
-end
-
-class UserWithMessage < Model
-  validates :domain, :domain => {:message => "isn't quite right"}
-end
+require 'support/models'
 
 describe DomainValidator do
   context "with valid domain" do
@@ -87,6 +64,54 @@ describe DomainValidator do
         subject.errors[:domain].should include "isn't quite right"
       end
     end
+
+    context "when :verify_dns has a :message option" do
+      subject { UserVerifyDNSMessage.new :domain => "a.com" }
+      before { subject.valid? }
+
+      it "should add the customized message" do
+        subject.errors[:domain].should include "failed DNS check"
+      end
+    end
+
+    context "when :verify_dns does not have a :message option" do
+      subject { UserVerifyDNS.new :domain => "a.com" }
+      before { subject.valid? }
+
+      it "should add the default message" do
+        subject.errors[:domain].should include "does not have a DNS record"
+      end
+    end
+  end
+
+  describe "DNS check" do
+    describe "a domain with a DNS record" do
+      it "should be valid when :verify_dns is true" do
+        UserVerifyDNS.new(:domain => "example.com").should be_valid
+      end
+
+      it "should be valid when :verify_dns is false" do
+        UserVerifyDNSFalse.new(:domain => "example.com").should be_valid
+      end
+
+      it "should be valid when :verify_dns is undefined" do
+        User.new(:domain => "example.com").should be_valid
+      end
+    end
+
+    describe "a domain without a DNS record" do
+      it "should not be valid when :verify_dns is true" do
+        UserVerifyDNS.new(:domain => "a.com").should_not be_valid
+      end
+
+      it "should be valid when :verify_dns is false" do
+        UserVerifyDNSFalse.new(:domain => "a.com").should be_valid
+      end
+
+      it "should be valid when :verify_dns is undefined" do
+        User.new(:domain => "a.com").should be_valid
+      end
+    end
   end
 
 end

data/spec/support/models.rb

@@ -0,0 +1,35 @@
+class User < Model
+  validates :domain, :domain => true
+end
+
+class UserAllowsNil < Model
+  validates :domain, :domain => {:allow_nil => true}
+end
+
+class UserAllowsNilFalse < Model
+  validates :domain, :domain => {:allow_nil => false}
+end
+
+class UserAllowsBlank < Model
+  validates :domain, :domain => {:allow_blank => true}
+end
+
+class UserAllowsBlankFalse < Model
+  validates :domain, :domain => {:allow_blank => false}
+end
+
+class UserWithMessage < Model
+  validates :domain, :domain => {:message => "isn't quite right"}
+end
+
+class UserVerifyDNS < Model
+  validates :domain, :domain => {:verify_dns => true}
+end
+
+class UserVerifyDNSFalse < Model
+  validates :domain, :domain => {:verify_dns => false}
+end
+
+class UserVerifyDNSMessage < Model
+  validates :domain, :domain => {:verify_dns => {:message => "failed DNS check"}}
+end

metadata

@@ -1,69 +1,78 @@
 --- !ruby/object:Gem::Specification
 name: domain_validator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
+  prerelease: 
 platform: ruby
 authors:
 - Kyle Dayton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-08 00:00:00.000000000 Z
+date: 2013-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Adds ActiveModel validation for domain format.
@@ -81,36 +90,43 @@ files:
 - Rakefile
 - domain_validator.gemspec
 - lib/domain_validator.rb
+- lib/domain_validator/dns_check.rb
 - lib/domain_validator/validator.rb
 - lib/domain_validator/version.rb
+- spec/dns_check_spec.rb
 - spec/domain_validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/domain_helpers.rb
+- spec/support/models.rb
 homepage: http://github.com/kdayton-/domain_validator
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Adds ActiveModel validation for domain format.
 test_files:
+- spec/dns_check_spec.rb
 - spec/domain_validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/domain_helpers.rb
+- spec/support/models.rb
+has_rdoc: 

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: a951e441fa4015ac815c9ba5fee96609c22fc8a4
-  data.tar.gz: ae1724471b31badf6553fd783e5da8c5e905a17b
-SHA512:
-  metadata.gz: a82193dea64c492105c0b64e847f02f8214f8b2a82a0c7048a1c29b4fe5501280ed60aea2d329e23898b875f1c93e1d5be84947d13176e5b1856ba563d61a502
-  data.tar.gz: 082544a780890525d87962ec301888a8842beb0d7696e6176ad26254142c0d34b1ecb1b08a66fc899b8d2e3085036c87f4c2f956d1f08411cf95d13c88104b13