docusign_dtr 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e03a52f3bb44e1462024e64b3d3a408c71f63c81565a658606b568cb2fe8848b
-  data.tar.gz: f1f1a6345ade77d8e31af1641e510ef68147e141baf18fcd57dc2b7c1e57bbcb
+  metadata.gz: babf7393da3cdb470a7a0ddbc037b50e3bf282ee6ba121204ca45641dcc30bff
+  data.tar.gz: 89c2be6c61dbb4e9739e34e966112159232e037eab6f4d726060eaceb069a6af
 SHA512:
-  metadata.gz: 86680ddc00e86f70d75661603302350dbe912458e15824217a75d27225e1c6ee2256c9538e8363133160e59a51e7e9669edef908f4cef6588cc4fdebd4076b27
-  data.tar.gz: 6e481220000cf8f4afa61ce0aca4895c793ce831b4f1ad0ce995fad7701f1a32ee406b0555dab18111a7146c9bcd0e3ae7fcb6c6abd30daf1e465b1075ad0dc5
+  metadata.gz: '049c2d2bc889e2f57ac05ef86b6f312edd2893fc42d53e5879d7cdfe9077cdfd96ac8a91bdfc4674a24e7a967620a71f8e7a8b89322f132f2f1a4b4cc5d6216a'
+  data.tar.gz: c41da729edfff39ab6dfacf6f04293917cf24fe26aec512409228df92ae8e7e63270a648ffb51e0b224ad7b0960f1d044214e9a7a92b34180f2dd6cd9019f9cf

data/.travis.yml

@@ -1,8 +1,8 @@
 sudo: false
 language: ruby
 rvm:
-- 2.5.1
-before_install: gem install bundler -v 1.15.1
+- 2.5.3
+before_install: gem install bundler -v 1.17.1
 notifications:
   slack:
     secure: JabcnJlmrkhrrCtDTaqoylYn2dmyUP9h9SO/IyVKrIZ0YvTukaKzU2RSHP6PXjv1WC/9zfrmrWiODBZmg3HciOq4C6g+LdPEGtujx4ULSpztyIm8MlC+uODKtNLR7Q4j9cWTNOi6JKmBWJmo00i7OXLiB3njpEza3or3585vL9ffLJTG/9bi61u/ccuDXBKjqOg2Mxa5sWycgl/kAZ1qTgG76RARWFr6f2Cvxu9LG0BeUq0KpMHKToPjTllmYIKoXKStAX8bLnTU0M1JI5O4uc5W/QOaRhrNgSNyn2LVzHos/8+LO8I4kj+ptMYK037pM3ojByYmQOyE8WL/6kCAJbRN5njyENRUpXrGyWjfF7yDBGA5zMoYgC6MyUWiOj66p12tNTrUVkeFc53uYzlfAg8n331aHj+j+zWuT+oOrn0H9Nx1X4QtJleY6qkPHZO2aF9o7rZIeA7Fn9fGrECUvOQyskBHgHyyWnZ1SpZsRBXKCqlPMyf//RUO9Cx580VSTqgjTCcHa5gAhsoiTl5S9NjsTJCrshRxkj0t1tv2tiCbbTLJ9n309wsI2kj+53S4Q4lXgTV4SQEqrqoO7PldQKPiOZDF2ZOZO0Ou6EBEGcIqL54tWjoKXHpPxMuXW0UrXgl1wl+jhiQTzKBlW4raHLYfaL6u1Yjvo1ZKKTlLseg=

data/lib/docusign_dtr/auth/base.rb

@@ -65,7 +65,7 @@ module DocusignDtr
       end
 
       def handle_error(response)
-        raise DocusignDtr::Auth::Error.new(response: response).build
+        DocusignDtr::Auth::Error.new(response: response).build
       end
     end
   end

data/lib/docusign_dtr/auth/code.rb

@@ -26,7 +26,7 @@ module DocusignDtr
 
         params = { grant_type: :authorization_code, code: code }
         response = self.class.post(auth_uri, query: params, headers: headers, timeout: 60)
-        handle_error(response) if response.code != 200
+        handle_error(response)
         @token_response = DocusignDtr::Models::AuthTokenResponse.new(response.parsed_response)
       end
 
@@ -35,7 +35,7 @@ module DocusignDtr
 
         params = { grant_type: :refresh_token, refresh_token: @token_response.refresh_token }
         response = self.class.post("#{base_uri}oauth/token", query: params, headers: headers, timeout: 60)
-        handle_error(response) if response.code != 200
+        handle_error(response)
         @token_response = DocusignDtr::Models::AuthTokenResponse.new(response.parsed_response)
       end
 
@@ -43,7 +43,7 @@ module DocusignDtr
         raise 'No token to obtain userinfo' unless @token_response&.access_token
 
         response = self.class.get("#{base_uri}oauth/userinfo", headers: user_info_headers, timeout: 60)
-        handle_error(response) if response.code != 200
+        handle_error(response)
         @userinfo = DocusignDtr::Models::Userinfo.new(response.parsed_response)
       end
 

data/lib/docusign_dtr/auth/error.rb

@@ -8,11 +8,7 @@ module DocusignDtr
       def build
         return nil if @response.code == 200
 
-        exception.new(full_message)
-      end
-
-      def full_message
-        "Error communicating: Response code #{@response.code}"
+        raise exception.new(standard_error_message)
       end
 
       def exception
@@ -35,8 +31,9 @@ module DocusignDtr
       def general_error
         return DocusignDtr::InvalidGrant if error_code.match?(/grant/)
         return DocusignDtr::ApiLimitExceeded if error_code.match?(/HOURLY_APIINVOCATION_LIMIT_EXCEEDED/)
+        return DocusignDtr::ConsentRequired if error_code.match?(/consent_required/)
 
-        DocusignDtr::ConsentRequired
+        StandardError
       end
 
       def error_code
@@ -45,8 +42,16 @@ module DocusignDtr
         @error_code ||= parsed_response.fetch(:error, nil) || parsed_response.fetch(:errorCode, '')
       end
 
+      def error_message
+        parsed_response.fetch(:message, nil) || parsed_response.fetch(:errorDetails, '')
+      end
+
       def parsed_response
-        @parsed_response ||= @response.parsed_response&.transform_keys(&:to_sym)
+        @parsed_response ||= @response.parsed_response&.transform_keys(&:to_sym) || {}
+      end
+
+      def standard_error_message
+        [error_code, error_message].compact.reject(&:empty?).join(': ')
       end
     end
   end

data/lib/docusign_dtr/auth/jwt.rb

@@ -23,7 +23,7 @@ module DocusignDtr
 
       def request_token
         response = self.class.post(auth_uri, query: access_token_params, headers: base_headers, timeout: 60)
-        handle_error(response) if response.code != 200
+        handle_error(response)
         @token_response = DocusignDtr::Models::AuthTokenResponse.new(response.parsed_response)
       end
 

data/lib/docusign_dtr/client.rb

@@ -18,12 +18,12 @@ module DocusignDtr
     def raw(page, params = {})
       full_path = [base_uri, page].join
       response = self.class.get(full_path, query: params, headers: headers, timeout: 60)
-      handle_error(response) if response.code != 200
+      handle_error(response)
       response.parsed_response
     end
 
     def handle_error(response)
-      raise DocusignDtr::Auth::Error.new(response: response).build
+      DocusignDtr::Auth::Error.new(response: response).build
     end
 
     def Document # rubocop:disable  Naming/MethodName

data/lib/docusign_dtr/version.rb

@@ -1,3 +1,3 @@
 module DocusignDtr
-  VERSION = '0.3.4'.freeze
+  VERSION = '0.3.5'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docusign_dtr
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Loft47
@@ -34,7 +34,7 @@ cert_chain:
   WPTyTwBv5qAL48mT3OBIV99mY13XurTi2s2OCJAgkQZIQlGsFzmT/4IDYivCoABO
   QVWtuf6LfMkXYW5shBsTlpiGbXeVlm0QW2Av3w==
   -----END CERTIFICATE-----
-date: 2018-11-02 00:00:00.000000000 Z
+date: 2018-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -333,7 +333,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Docusign DTR library