docusign_dtr 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 65d316f60d05b3daca51ba5e8ba96bbcf3882d77
-  data.tar.gz: 7c7deb709fee8e487ac7a957b769f499784e2974
+SHA256:
+  metadata.gz: 304f53ac13abf8675980078b6726e011b97dccd04ea8f66960b9fdbd011bf295
+  data.tar.gz: 553f4afc451445758c905ffe41daf0dd08f624711249d0c743e929d49242854a
 SHA512:
-  metadata.gz: d0add2e061bbc8034ee8d3df4c9340153df2bc62eaf0b8d2f049dca7f61a0057146b567f1896c8f231d89dec3373b7b6221b7ad0ed2d1c94b8879be22142dea0
-  data.tar.gz: bc155de1fc63efc5ae81566cb5fcca62868b8c159389e8c061ec040e43659e630fe2df61ef9702f5f606da19dbe3236f50207c2d3e23a0639f7aef475c9effdf
+  metadata.gz: ac44253fbc773477faeffed5681d1a6c701aca29fd7de7d339f6d0e19b734a41556f372008150f0b556ee615e790d38e18d0b5e7ea6822e20db50556e8d7bdbd
+  data.tar.gz: e111da02dd6d52ae6da28e2dc522f5c1bd8d07393c4f0246d3e08dd7bb4204a6ce5c909757a70a8050142ec900fee2b5aeb1dd9144cc33084ff3ba5423f81cd3

data/lib/docusign_dtr.rb

@@ -8,6 +8,7 @@ require 'docusign_dtr/exceptions'
 require 'docusign_dtr/auth/base'
 require 'docusign_dtr/auth/code'
 require 'docusign_dtr/auth/jwt'
+require 'docusign_dtr/auth/error'
 require 'docusign_dtr/client'
 require 'docusign_dtr/activity'
 require 'docusign_dtr/document'

data/lib/docusign_dtr/auth/base.rb

@@ -65,25 +65,7 @@ module DocusignDtr
       end
 
       def handle_error(response)
-        raise error_type(response), "Error communicating: Response code #{response.code}"
-      end
-
-      def error_type(response)
-        case response.code
-        when 400
-          # {"error":"invalid_grant"}
-          return DocusignDtr::InvalidGrant if response.parsed_response['error'].match?(/grant/)
-
-          DocusignDtr::ConsentRequired # {"error":"consent_required"}
-        when 401
-          DocusignDtr::Unauthorized
-        when 403
-          DocusignDtr::Forbidden
-        when 204
-          DocusignDtr::NoContent
-        else
-          StandardError
-        end
+        raise DocusignDtr::Auth::Error.new(response: response).build
       end
     end
   end

data/lib/docusign_dtr/auth/error.rb

@@ -0,0 +1,53 @@
+module DocusignDtr
+  module Auth
+    class Error
+      def initialize(response:)
+        @response = response
+      end
+
+      def build
+        return nil if @response.code == 200
+
+        exception.new(full_message)
+      end
+
+      def full_message
+        "Error communicating: Response code #{@response.code}"
+      end
+
+      def exception
+        case @response.code
+        when 400
+          general_error
+        when 401
+          DocusignDtr::Unauthorized
+        when 403
+          DocusignDtr::Forbidden
+        when 204
+          DocusignDtr::NoContent
+        else
+          StandardError
+        end
+      end
+
+      private
+
+      def general_error
+        return DocusignDtr::InvalidGrant if error_code.match?(/grant/)
+        return DocusignDtr::ApiLimitExceeded if error_code.match?(/HOURLY_APIINVOCATION_LIMIT_EXCEEDED/)
+
+        DocusignDtr::ConsentRequired
+      end
+
+      def error_code
+        return '' unless parsed_response
+
+        @error_code ||= parsed_response.fetch(:error) || parsed_response.fetch(:errorCode, '')
+      end
+
+      def parsed_response
+        @parsed_response ||= @response.parsed_response&.transform_keys(&:to_sym)
+      end
+    end
+  end
+end

data/lib/docusign_dtr/client.rb

@@ -23,7 +23,7 @@ module DocusignDtr
     end
 
     def handle_error(response)
-      raise error_type(response), "Error communicating: Response code #{response.code}"
+      raise DocusignDtr::Auth::Error.new(response: response).build
     end
 
     def Document # rubocop:disable  Naming/MethodName
@@ -179,23 +179,5 @@ module DocusignDtr
         object.to_snake_keys
       end
     end
-
-    def error_type(response)
-      case response.code
-      when 400
-        # {"error":"invalid_grant"}
-        return DocusignDtr::InvalidGrant if response.parsed_response['error'].match?(/grant/)
-
-        DocusignDtr::ConsentRequired # {"error":"consent_required"}
-      when 401
-        DocusignDtr::Unauthorized
-      when 403
-        DocusignDtr::Forbidden
-      when 204
-        DocusignDtr::NoContent
-      else
-        StandardError
-      end
-    end
   end
 end

data/lib/docusign_dtr/exceptions.rb

@@ -1,8 +1,9 @@
 module DocusignDtr
+  class ApiLimitExceeded < StandardError; end
   class ConsentRequired < StandardError; end
+  class Forbidden < StandardError; end
   class InvalidGrant < StandardError; end
   class InvalidParameter < StandardError; end
-  class Forbidden < StandardError; end
   class NoContent < StandardError; end
   class Unauthorized < StandardError; end
 end

data/lib/docusign_dtr/version.rb

@@ -1,3 +1,3 @@
 module DocusignDtr
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.3.3'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docusign_dtr
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Loft47
@@ -34,7 +34,7 @@ cert_chain:
   WPTyTwBv5qAL48mT3OBIV99mY13XurTi2s2OCJAgkQZIQlGsFzmT/4IDYivCoABO
   QVWtuf6LfMkXYW5shBsTlpiGbXeVlm0QW2Av3w==
   -----END CERTIFICATE-----
-date: 2018-10-25 00:00:00.000000000 Z
+date: 2018-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -242,6 +242,7 @@ files:
 - lib/docusign_dtr/activity.rb
 - lib/docusign_dtr/auth/base.rb
 - lib/docusign_dtr/auth/code.rb
+- lib/docusign_dtr/auth/error.rb
 - lib/docusign_dtr/auth/jwt.rb
 - lib/docusign_dtr/client.rb
 - lib/docusign_dtr/document.rb
@@ -332,7 +333,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Docusign DTR library