docker_registry2 0.7.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 659ecf4ef40131454d487d83c3f6592020b69f04
-  data.tar.gz: 64c62b6dc3ac56dcd49e7290dd519a6c56ba9836
+  metadata.gz: 3a8e38262e00c15c3706999d7d5283a6f9b13ff0
+  data.tar.gz: 5fe67075919b2a2d3d70077fbc327dc0f9a5a9f0
 SHA512:
-  metadata.gz: f436b0a221871c034a9a7fe785d00ebb24011c12e2adeec782786676f819ef61356ab0f1440b3b98f0f01e516b31e90a71532cc672a488b6e12f3f243481fdde
-  data.tar.gz: 0e8eca4a3438bb7fda0608b7920b6b76bc2090928b81c13589adb2f1031de98d11c8c15136fb1cad6028a23987be66ecf56cd71884feed755f94c981602fb737
+  metadata.gz: 3d369e8f8f55e20601637fe62089db93d178a025fcf67caaf69287f808df47fe8bf062afab68c55ec17c6a7beee5352e9d1866461c80a579ea20386ef6193f53
+  data.tar.gz: 49861378fac8d26ccd3558206bb4f87f45322d89422ad5efcdecf6fcb55400a26bb406be65a765730830d8e70c26e77875306e73114206dc4546d40b6330cf9b

data/README.md

@@ -66,12 +66,16 @@ The following exceptions are thrown:
 * `RegistrySSLException`: registry SSL certificate cannot be validated
 
 #### Authenticated
-If you wish to authenticate, pass a username and password as part of the URL.
+If you wish to authenticate, pass a username and password as part of the options to `DockerRegistry.connect`.
 
 ````ruby
-reg = DockerRegistry2.connect("https://myuser:mypass@my.registy.corp.com")
+url = "https://my.registy.corp.com"
+opts = {user: "me", password: "secretstuff"}
+reg = DockerRegistry2.connect(url,opts)
 ````
 
+**Note:** Older versions prior to 1.0.0 _used_ to support putting the username and password in the URL. We no longer support it as it is **strongly** discouraged in RFCs. Put it in the `opts` hash.
+
 The following exceptions are thrown:
 
 * `RegistryAuthenticationException`: username/password combination is invalid

data/lib/docker_registry2.rb

@@ -4,8 +4,8 @@ require File.dirname(__FILE__) + '/registry/exceptions'
 
 
 module DockerRegistry2
-  def self.connect(uri="https://registry.hub.docker.com")
-    @reg = DockerRegistry2::Registry.new(uri)
+  def self.connect(uri="https://registry.hub.docker.com",opts={})
+    @reg = DockerRegistry2::Registry.new(uri,opts)
   end
 
   def self.search(query = '')

data/lib/registry/registry.rb

@@ -10,8 +10,8 @@ class DockerRegistry2::Registry
   def initialize(uri, options = {})
     @uri = URI.parse(uri)
     @base_uri = "#{@uri.scheme}://#{@uri.host}:#{@uri.port}"
-    @user = @uri.user
-    @password = @uri.password
+    @user = options[:user]
+    @password = options[:password]
     # make a ping connection
     ping
   end
@@ -193,12 +193,8 @@ class DockerRegistry2::Registry
       end
       # authenticate against the realm
       uri = URI.parse(target[:realm])
-      uri.user = @user if defined? @user
-      uri.password = @password if defined? @password
       begin
-        # FIXME: This should be set with the rest of the headers
-        # target[:params]['scope'] = 'repository'
-        response = RestClient.get uri.to_s, {params: target[:params]}
+        response = RestClient::Request.execute method: :get, url: uri.to_s, headers: {params: target[:params]}, user: @user, password: @password
       rescue RestClient::Unauthorized
         # bad authentication
         raise DockerRegistry2::RegistryAuthenticationException

data/lib/registry/version.rb

@@ -1,3 +1,3 @@
 module DockerRegistry2
-  VERSION = '0.7.0'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docker_registry2
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Avi Deitcher https://github.com/deitch
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-11 00:00:00.000000000 Z
+date: 2017-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler