docdata 0.1.8 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b7fce0fc2d60f3333084ba16516eb7ad414b728
-  data.tar.gz: 52f071c31314b98fd530bb62b3f0fb007c4d4b33
+  metadata.gz: 1649a0341e1a2bab71fffe7312e8164eac76ad28
+  data.tar.gz: c2669f29aaa9e3d413103d6853c176e70d9a9c8e
 SHA512:
-  metadata.gz: 25d68049043573abdbd864625135dab093f86cd2cba3ce5095f9de81bca2b3d6429859e29f63bd2211aae374ada25d8c03d8a8614e0fb21600a6915812f53514
-  data.tar.gz: fe7766f96151b852e3fcb4702f977e6b84fbbd73810ac0d969f814cb62b685a1aaed37e65b55cc609403c2b6714fcdfb6f57625260e579fc1959cf2865d52d1c
+  metadata.gz: 09ae4da69d1e3863169b627dc658bd7a225e5682fdc33d13a3fd30767c7d5e2470af19b88bfa9f748bca4e5fe805fdf58074adbe440c7252a5c428fd874f6e5f
+  data.tar.gz: 7557feaa5bfed0907f872693f5699e8966928e01f5d5f7111d9921d0b0fe0374db73cfc8e5b4dbd048204ce605978c5f7c223ebd6c008b193c4b7aa098df9aa0

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.2.0
+* We now assume a payment to be paid when total_registered == total_acquirer_approved
+
+## v0.1.9
+* Bug fixed where 'paid?' returned false if respons status had both 'paid' and 'canceled' node in response XML.
+
 ## v0.1.8
 * You can now make refunds. See documentation.
 * Updated README

data/lib/docdata/response.rb

@@ -149,12 +149,31 @@ module Docdata
     # a different 'paid'.
     # @note This method is never 100% reliable. If you need to finetune this, please implement your own method, using
     # the available data (total_captured, total_registered, etc.)
+    ## from the Docs:
+    ### Safe route: 
+    # The safest route to check whether all payments were made is for the merchants
+    # to refer to the “Total captured” amount to see whether this equals the “Total registered
+    # amount”. While this may be the safest indicator, the downside is that it can sometimes take a
+    # long time for acquirers or shoppers to actually have the money transferred and it can be
+    # captured.
+    ### Quick route: 
+    # Another option is to see whether the sum of “total shopper pending”, “total
+    # acquirer pending” and “total acquirer authorized” matches the “total registered sum”. This
+    # implies that everyone responsible has indicated that they are going to make the payment and
+    # that the merchant is trusting that everyone will indeed make this. While this route will be
+    # faster, it does also have the risk that some payments will actually not have been made.
+    ### Balanced route: 
+    # Depending on the merchant's situation, it can be a good option to only refer
+    # to certain totals. For instance, if the merchant only makes use of credit card payments it
+    # could be a good route to only look at “Total acquirer approved”, since this will be rather safe
+    # but quicker than looking at the captures.
     def is_paid?
+
       if payment_method
         case payment_method
         # ideal (dutch)
         when "IDEAL" 
-          (total_registered == total_captured) && (capture_status == "CAPTURED")
+          (total_registered == total_captured) ## && (capture_status == "CAPTURED")
         # creditcard
         when "MASTERCARD", "VISA", "AMEX"
           (total_registered == total_acquirer_approved)
@@ -164,7 +183,7 @@ module Docdata
         # fallback: if total_registered equals total_caputured,
         # we can assume that this order is paid. No 100% guarantee.
         else
-          total_registered == total_captured
+          total_registered == total_acquirer_approved
         end
       else
         false
@@ -222,6 +241,8 @@ module Docdata
 
     # Sometimes a single response has multiple payment nodes. When a payment fails first and 
     # succeeds later, for example. In that case, always use the newest (== highest id) node.
+    # UPDATE (2/3/2015) this is not always the case: a payment can receive a 'canceled' payment 
+    # later on with a higher ID, but the order is still paid.
     def self.payment_node(hash)
       if hash[:payment] && hash[:payment].is_a?(Hash)
         hash[:payment]

data/lib/docdata/version.rb

@@ -1,3 +1,3 @@
 module Docdata
-  VERSION = "0.1.8"
+  VERSION = "0.2.0"
 end

data/spec/response_spec.rb

@@ -33,6 +33,35 @@ describe Docdata::Response do
     end
   end
 
+
+  describe "response with multiple payment nodes (paid first, canceled later)" do
+    before(:each) do
+      file = "#{File.dirname(__FILE__)}/xml/status-paid-multiple-and-canceled.xml"
+      @xml = open(file)
+      @response = Docdata::Response.parse(:status, @xml)
+    end    
+
+    it "returs a response object" do
+      expect(@response).to be_kind_of(Docdata::Response)
+    end
+
+    it "is of method IDEAL" do
+      expect(@response.payment_method).to eq("IDEAL")
+    end
+
+    it "is paid?" do
+      expect(@response.paid?).to eq(true)
+    end
+
+    it "is paid" do
+      # puts "IS PAID: #{total_registered} && #{total_captured}"
+      expect(@response.total_registered).to eq(2600)
+      expect(@response.total_captured).to eq(2600)      
+      expect(@response.paid).to eq(true)
+    end
+  end
+
+
   describe "response with multiple payment nodes (paid first, canceled later)" do
     before(:each) do
       file = "#{File.dirname(__FILE__)}/xml/status-paid-canceled-ideal-multiple.xml"

data/spec/xml/status-paid-multiple-and-canceled.xml

@@ -0,0 +1,42 @@
+<S:Envelope xmlns:S="http://schemas.xmlsoap.org/soap/envelope/">
+   <S:Body>
+      <statusResponse xmlns="http://www.docdatapayments.com/services/paymentservice/1_1/">
+         <statusSuccess>
+            <success code="SUCCESS">Operation successful.</success>
+            <report>
+               <approximateTotals exchangedTo="EUR" exchangeRateDate="2015-03-02 11:14:59">
+                  <totalRegistered>2600</totalRegistered>
+                  <totalShopperPending>0</totalShopperPending>
+                  <totalAcquirerPending>0</totalAcquirerPending>
+                  <totalAcquirerApproved>2600</totalAcquirerApproved>
+                  <totalCaptured>2600</totalCaptured>
+                  <totalRefunded>0</totalRefunded>
+                  <totalChargedback>0</totalChargedback>
+               </approximateTotals>
+               <payment>
+                  <id>2551456273</id>
+                  <paymentMethod>IDEAL</paymentMethod>
+                  <authorization>
+                     <status>CANCELED</status>
+                     <amount currency="EUR">2600</amount>
+                     <confidenceLevel/>
+                  </authorization>
+               </payment>
+               <payment>
+                  <id>2551456260</id>
+                  <paymentMethod>IDEAL</paymentMethod>
+                  <authorization>
+                     <status>AUTHORIZED</status>
+                     <amount currency="EUR">2600</amount>
+                     <confidenceLevel>ACQUIRER_APPROVED</confidenceLevel>
+                     <capture>
+                        <status>CAPTURED</status>
+                        <amount currency="EUR">2600</amount>
+                     </capture>
+                  </authorization>
+               </payment>
+            </report>
+         </statusSuccess>
+      </statusResponse>
+   </S:Body>
+</S:Envelope>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docdata
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.2.0
 platform: ruby
 authors:
 - Henk Meijer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-23 00:00:00.000000000 Z
+date: 2015-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -293,6 +293,7 @@ files:
 - spec/xml/status-paid-creditcard.xml
 - spec/xml/status-paid-ideal-multiple.xml
 - spec/xml/status-paid-ideal.xml
+- spec/xml/status-paid-multiple-and-canceled.xml
 - spec/xml/status-paid-sofort.xml
 homepage: http://rdoc.info/github/henkm/docdata/
 licenses:
@@ -339,5 +340,6 @@ test_files:
 - spec/xml/status-paid-creditcard.xml
 - spec/xml/status-paid-ideal-multiple.xml
 - spec/xml/status-paid-ideal.xml
+- spec/xml/status-paid-multiple-and-canceled.xml
 - spec/xml/status-paid-sofort.xml
 has_rdoc: