docdata 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 583612f0f3405d88e304b04589e08faa14fc873c
-  data.tar.gz: e846c3af8a8be9caec3bddb1ca375565feb9e7e3
+  metadata.gz: e4522413a11b26b3dfdfd86eba1c75266e2e75fd
+  data.tar.gz: 59ec267e42dc78db14c0ae8e24ff262198f14dc7
 SHA512:
-  metadata.gz: 4f78048e064e074ffc7e343267d94b45b54d9ef81bbab5a34fd535466557f89746d80d23e3c027d195fa19388588c22a7305d374dd14b8df6c812b137fafcb82
-  data.tar.gz: c039738e8915fa272fd01ea4c95e4e0df54f9823ba89febe6831f67a685f49018b68b8ee6594b930efc301188652b34701cda63a973039c4cf54a56e08e2fa97
+  metadata.gz: 6e7708006984099623dd4eb12229b6913285525705e3ac6e0b398e3a7626902896e5431f1f95afb745e97201da551c10bac842b0545b6027e1331671bd46a1a8
+  data.tar.gz: 3440473688ded10b3412bc588d3dc949beba30b2a0704123a0017af786b5582951124f4d64534494e608719927ba5674e1d5d4bba2669f978605559e14200e9a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## v0.1.6
+* Bug fixed where a description contained an illegal character (& in this case)
+
 ## v0.1.5
 * Fixed a bug that occured when docdata reponded with multiple 'payment' nodes in the return object.
 

data/lib/docdata/payment.rb

@@ -69,6 +69,12 @@ module Docdata
     end
 
 
+    # @return [String] a cleaned up version of the description string
+    # where forbidden characters are filtered out and limit is 50 chars.
+    def cleaned_up_description
+      description.gsub("&", "and")[0..49]
+    end
+
     # @return [Boolean] true/false, depending if this instanciated object is valid
     def valid?
       validator = PaymentValidator.new

data/lib/docdata/version.rb

@@ -1,3 +1,3 @@
 module Docdata
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/lib/docdata/xml/create.xml.erb

@@ -35,7 +35,7 @@
          </_1:billTo>
 
          <% if payment.description.present? %>
-         <_1:description><%= payment.description[0..49] %></_1:description>
+         <_1:description><%= payment.cleaned_up_description %></_1:description>
          <% end %>
          <% if payment.receipt_text.present? %>
          <_1:receiptText><%= payment.receipt_text %></_1:receiptText>
@@ -89,7 +89,7 @@
                </_1:address>
             </_1:shipTo>
             <!--Optional:-->
-            <_1:additionalDescription>sdf</_1:additionalDescription>
+            <_1:additionalDescription></_1:additionalDescription>
          </_1:invoice>
          <% end %>
 

data/spec/payment_spec.rb

@@ -97,6 +97,12 @@ describe Docdata::Payment do
       expect(@response.payment).to be_kind_of(Docdata::Payment)
     end
 
+    it "replaces & for 'and'" do
+      @payment.description = "Pete & Friends"
+      expect(@payment.cleaned_up_description) == "Pete and Friends"
+      expect(@payment.create_xml).to include("Pete and Friends")
+    end
+
     it "has a `url` property" do
       Docdata.set_credentials_from_environment
       VCR.use_cassette("payments-successful-create") do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: docdata
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Henk Meijer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-22 00:00:00.000000000 Z
+date: 2014-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler