dnsmadeeasy-rest-api 1.0.8 → 1.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ea11e9f3e4bd98ca1e7c96fa950103ced863745b
-  data.tar.gz: 1bef7b48f3f0941cd6c8b5eae87f7cac2b08abac
+SHA256:
+  metadata.gz: cfef63371c15cdb43f5b3cc10da4f1040e799e80ee4baa25c3022690343eb18b
+  data.tar.gz: 5d1f3555975abd4539f87cb2c1379c8429d1998db641fe442868ed6f6c881b1d
 SHA512:
-  metadata.gz: e667b4ebdc8a24286130def23c20009d6fb55132e42daa12bb9366c1fcb5d8d46002d21ddb9336a0dd7df3331b09dc4f819735431f09e356359f97ceea5aab0a
-  data.tar.gz: 1a58213c6cc533fa722f75403694302ea115aa1c1f7576657c575555eadf3547d711abdd1c714966c06ac2353a2c4b5d494b00b26c094769fcc635e14d3469ff
+  metadata.gz: ff5dbf38737e7b45fb01921cc35567fd18fa7c1aada5fcbc6dd3f872787068d1654b758403b1ae8fc00b42e44c8909a7dfe8a3011d251cf1715fc2520dc9f3d9
+  data.tar.gz: 6799acbfd78fcb37810e1b1785a2b26c58a4d5b9ec13f913cc9cf6c19ee811d7c5d40829d1550991213938f29dd9d44edf3cf20cc857bf63906912aa1a08eedc

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
@@ -19,4 +21,4 @@ end
 
 # The default rake task should just run it all
 desc 'Run all tests'
-task default: %w(style unit)
+task default: %w[style unit]

data/dnsmadeeasy-rest-api.gemspec

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |s|
   s.name          = 'dnsmadeeasy-rest-api'
-  s.version       = '1.0.8'
+  s.version       = '1.0.9'
   s.authors       = ['Arnoud Vermeer', 'Paul Henry', 'James Hart']
   s.email         = ['a.vermeer@freshway.biz', 'ops@wanelo.com']
-  s.license       = 'Apache'
+  s.license       = 'Apache-2.0'
   s.summary       = 'DNS Made Easy V2.0 REST API client for Ruby'
   s.description   = 'DNS Made Easy V2.0 REST API client for Ruby. With tests and no dependencies.'
   s.homepage      = 'https://github.com/funzoneq/dnsmadeeasy-rest-api'
 
   s.files         = `git ls-files`.split("\n")
 
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency 'webmock'
   s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rspec'
   s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'webmock'
 end

data/lib/dnsmadeeasy-rest-api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'time'
 require 'openssl'
 require 'json'
@@ -11,8 +13,8 @@ class DnsMadeEasy
   attr_reader :request_limit
 
   def initialize(api_key, api_secret, sandbox = false, options = {})
-    fail 'api_key is undefined' unless api_key
-    fail 'api_secret is undefined' unless api_secret
+    raise 'api_key is undefined' unless api_key
+    raise 'api_secret is undefined' unless api_secret
 
     @api_key = api_key
     @api_secret = api_secret
@@ -20,11 +22,11 @@ class DnsMadeEasy
     @requests_remaining = -1
     @request_limit = -1
 
-    if sandbox
-      self.base_uri = 'https://api.sandbox.dnsmadeeasy.com/V2.0'
-    else
-      self.base_uri = 'https://api.dnsmadeeasy.com/V2.0'
-    end
+    self.base_uri = if sandbox
+                      'https://api.sandbox.dnsmadeeasy.com/V2.0'
+                    else
+                      'https://api.dnsmadeeasy.com/V2.0'
+                    end
   end
 
   # -----------------------------------
@@ -55,6 +57,54 @@ class DnsMadeEasy
     create_domains([domain_name])
   end
 
+  # -----------------------------------
+  # -------- SECONDARY DOMAINS --------
+  # -----------------------------------
+
+  def secondarys
+    get '/dns/secondary'
+  end
+
+  def secondary(id)
+    get "/dns/secondary/#{id}"
+  end
+
+  def update_secondary(ids = [], ipSetId)
+    put('/dns/secondary/', 'ids' => ids, 'ipSetId' => ipSetId)
+  end
+
+  def create_secondary(names = [], ipSetId)
+    post('/dns/secondary/', "names": names, 'ipSetId' => ipSetId)
+  end
+
+  def delete_secondary(id)
+    delete("/dns/secondary/#{id}")
+  end
+
+  # -----------------------------------
+  # ------------- IP SETS -------------
+  # -----------------------------------
+
+  def ip_sets
+    get '/dns/secondary/ipSet'
+  end
+
+  def ip_set(id)
+    get "/dns/secondary/ipSet/#{id}"
+  end
+
+  def update_ip_set(id, name, ips = [])
+    put("/dns/secondary/ipSet/#{id}", 'name' => name, 'id' => id, 'ips' => ips)
+  end
+
+  def create_ip_set(name, ips = [])
+    post('/dns/secondary/ipSet', 'name' => name, 'ips' => ips)
+  end
+
+  def delete_ip_set(id)
+    delete("/dns/secondary/ipSet/#{id}")
+  end
+
   # -----------------------------------
   # ------------- RECORDS -------------
   # -----------------------------------
@@ -80,6 +130,7 @@ class DnsMadeEasy
 
   def delete_records(domain_name, ids = [])
     return if ids.empty?
+
     domain_id = get_id_by_domain(domain_name)
 
     delete "/dns/managed/#{domain_id}/records?ids=#{ids.join(',')}"
@@ -172,7 +223,7 @@ class DnsMadeEasy
     get "/monitor/#{record_id}"
   end
 
-  def update_failover_config(record_id, ips, desc, protocol='TCP', options = {})
+  def update_failover_config(record_id, ips, desc, protocol = 'TCP', options = {})
     protocolIds = {
       'TCP' => 1,
       'UDP' => 2,
@@ -197,8 +248,8 @@ class DnsMadeEasy
     body = body.merge(options)
 
     ip_config = {}
-    (0.. ips.length-1).each do |idx|
-      ip_config["ip#{idx+1}"] = ips[idx]
+    (0..ips.length - 1).each do |idx|
+      ip_config["ip#{idx + 1}"] = ips[idx]
     end
 
     body = body.merge(ip_config)
@@ -206,7 +257,7 @@ class DnsMadeEasy
     put "/monitor/#{record_id}", body
   end
 
-  def disable_failover(record_id, options={})
+  def disable_failover(record_id, options = {})
     put "/monitor/#{record_id}", { 'failover' => false, 'monitor' => false }.merge(options)
   end
 

data/spec/lib/dnsmadeeasyapi-rest-api_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require_relative '../../lib/dnsmadeeasy-rest-api'
 
@@ -5,10 +7,10 @@ describe DnsMadeEasy do
   let(:api_key) { 'soooo secret' }
   let(:secret_key) { 'soooo secret' }
   let(:request_headers) do
-    {'Accept' => 'application/json',
+    { 'Accept' => 'application/json',
       'X-Dnsme-Apikey' => 'soooo secret',
       'X-Dnsme-Hmac' => 'ff6e87e78ff909573362c9a38df13ccc5fa01846',
-      'X-Dnsme-Requestdate' => 'Wed, 21 May 2014 18:08:37 GMT'}
+      'X-Dnsme-Requestdate' => 'Wed, 21 May 2014 18:08:37 GMT' }
   end
 
   subject { DnsMadeEasy.new(api_key, secret_key) }
@@ -18,71 +20,70 @@ describe DnsMadeEasy do
   end
 
   describe '#get_id_by_domain' do
-
     let(:response) do
-      "{\"name\":\"something.wanelo.com\",\"id\":1130967}"
+      '{"name":"something.wanelo.com","id":1130967}'
     end
 
     it 'returns the id of the domain' do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/dns/managed/id/something.wanelo.com").
-        with(:headers => request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/id/something.wanelo.com')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
-      expect(subject.get_id_by_domain('something.wanelo.com')).to eq(1130967)
+      expect(subject.get_id_by_domain('something.wanelo.com')).to eq(1_130_967)
     end
   end
 
   describe '#domains' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     it 'returns all the domains' do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/dns/managed/").
-        with(:headers => request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.domains).to eq({})
     end
   end
 
-  describe "#domain" do
-    let(:response) { "{}" }
+  describe '#domain' do
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
     end
 
-    it "returns the domain given a domain name" do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123").
-        with(:headers => request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+    it 'returns the domain given a domain name' do
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.domain('something.wanelo.com')).to eq({})
     end
   end
 
   describe '#delete_domain' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
     end
 
     it 'deletes the domain' do
-      stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123").
-        with(:headers => request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:delete, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.delete_domain('something.wanelo.com')).to eq({})
     end
   end
 
   describe '#create_domains' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     it 'creates the domains' do
-      stub_request(:post, "https://api.dnsmadeeasy.com/V2.0/dns/managed/").
-        with(:headers => request_headers, :body => '{"names":["something.wanelo.com"]}').
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:post, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/')
+        .with(headers: request_headers, body: '{"names":["something.wanelo.com"]}')
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.create_domains(['something.wanelo.com'])).to eq({})
     end
@@ -95,17 +96,29 @@ describe DnsMadeEasy do
     end
   end
 
+  describe '#secondarys' do
+    let(:response) { '{}' }
+
+    it 'returns all the secondary domains' do
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/dns/secondary')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
+
+      expect(subject.secondarys).to eq({})
+    end
+  end
+
   describe '#records_for' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
     end
 
     it 'returns all records for a given domain' do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records").
-        with(:headers => request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.records_for('something.wanelo.com')).to eq({})
     end
@@ -115,8 +128,8 @@ describe DnsMadeEasy do
     let(:records_for_response) do
       {
         'data' => [
-          { 'name' => 'demo', 'type' => 'A', 'id' => 123},
-          { 'name' => 'demo', 'type' => 'A', 'id' => 143}
+          { 'name' => 'demo', 'type' => 'A', 'id' => 123 },
+          { 'name' => 'demo', 'type' => 'A', 'id' => 143 }
         ]
       }
     end
@@ -126,7 +139,7 @@ describe DnsMadeEasy do
     end
 
     it 'finds the first record that matches name and type' do
-      expect(subject.find('something.wanelo.com', 'demo', 'A')).to eq({ 'name' => 'demo', 'type' => 'A', 'id' => 123})
+      expect(subject.find('something.wanelo.com', 'demo', 'A')).to eq('name' => 'demo', 'type' => 'A', 'id' => 123)
     end
   end
 
@@ -134,8 +147,8 @@ describe DnsMadeEasy do
     let(:records_for_response) do
       {
         'data' => [
-          { 'name' => 'demo', 'type' => 'A', 'id' => 123},
-          { 'name' => 'demo', 'type' => 'A', 'id' => 143}
+          { 'name' => 'demo', 'type' => 'A', 'id' => 123 },
+          { 'name' => 'demo', 'type' => 'A', 'id' => 143 }
         ]
       }
     end
@@ -150,7 +163,7 @@ describe DnsMadeEasy do
   end
 
   describe '#delete_records' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
     let(:domain) { 'something.wanelo.com' }
     let(:domain_id) { 123 }
 
@@ -160,9 +173,9 @@ describe DnsMadeEasy do
       before do
         subject.stub(:get_id_by_domain).with(domain).and_return(domain_id)
 
-        stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/#{domain_id}/records?ids=#{ids.join(',')}").
-          with(headers: request_headers).
-          to_return(:status => 200, :body => response, :headers => {})
+        stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/#{domain_id}/records?ids=#{ids.join(',')}")
+          .with(headers: request_headers)
+          .to_return(status: 200, body: response, headers: {})
       end
 
       it 'deletes a list of records from a given domain' do
@@ -178,16 +191,16 @@ describe DnsMadeEasy do
   end
 
   describe '#delete_all_records' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
     let(:domain) { 'something.wanelo.com' }
     let(:domain_id) { 123 }
 
     before do
       subject.stub(:get_id_by_domain).with(domain).and_return(domain_id)
 
-      stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/#{domain_id}/records").
-        with(headers: request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/#{domain_id}/records")
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
     end
 
     it 'deletes all records from the domain' do
@@ -196,23 +209,23 @@ describe DnsMadeEasy do
   end
 
   describe '#delete_record' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
     end
 
     it 'deletes a record' do
-      stub_request(:delete, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/42/").
-        with(headers: request_headers).
-        to_return(:status => 200, :body => response, :headers => {})
+      stub_request(:delete, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/42/')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.delete_record('something.wanelo.com', 42)).to eq({})
     end
   end
 
   describe '#create_record' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
@@ -222,61 +235,60 @@ describe DnsMadeEasy do
     let(:name) { 'test' }
 
     it 'creates a record' do
-      stub_request(:post, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/").
-        with(headers: request_headers, body: {"name" => 'test', "type" => 'A', "value" => '192.168.1.1', "ttl" => 3600, "gtdLocation" => "DEFAULT"}.to_json).
-        to_return(:status => 200, :body => response, :headers => {})
-
+      stub_request(:post, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/')
+        .with(headers: request_headers, body: { 'name' => 'test', 'type' => 'A', 'value' => '192.168.1.1', 'ttl' => 3600, 'gtdLocation' => 'DEFAULT' }.to_json)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.create_record(domain_name, 'test', 'A', '192.168.1.1')).to eq({})
     end
   end
 
-  ["a", "aaaa", "ptr", "txt", "cname", "ns", "spf"].each do |record_type|
+  %w[a aaaa ptr txt cname ns spf].each do |record_type|
     method_name = "create_#{record_type}_record"
     describe "##{method_name}" do
       upper_record_type = record_type.upcase
 
       it "calls through to create record with \"#{upper_record_type}\"" do
-        expect(subject).to receive(:create_record).with('something.wanelo.com', 'smellyface',  upper_record_type, '192.168.1.1', {}).and_return({})
+        expect(subject).to receive(:create_record).with('something.wanelo.com', 'smellyface', upper_record_type, '192.168.1.1', {}).and_return({})
         expect(subject.send(method_name, 'something.wanelo.com', 'smellyface', '192.168.1.1')).to eq({})
       end
     end
   end
 
-  describe "#create_mx_record" do
+  describe '#create_mx_record' do
     it 'creates an mx record' do
-      expect(subject).to receive(:create_record).with('something.wanelo.com', 'mail', 'MX', '192.168.1.1', {'mxLevel' => 50}).and_return({})
+      expect(subject).to receive(:create_record).with('something.wanelo.com', 'mail', 'MX', '192.168.1.1', 'mxLevel' => 50).and_return({})
       expect(subject.create_mx_record('something.wanelo.com', 'mail', 50, '192.168.1.1')).to eq({})
     end
   end
 
-  describe "#create_srv_record" do
+  describe '#create_srv_record' do
     let(:weight) { '50' }
     let(:priority) { '42' }
     let(:port) { '4040' }
 
     it 'creates an srv record' do
-      expect(subject).to receive(:create_record).with('something.wanelo.com', 'serv', 'SRV', '192.168.1.1', {"priority" => priority, "weight" => weight, "port" => port}).and_return({})
+      expect(subject).to receive(:create_record).with('something.wanelo.com', 'serv', 'SRV', '192.168.1.1', 'priority' => priority, 'weight' => weight, 'port' => port).and_return({})
 
       expect(subject.create_srv_record('something.wanelo.com', 'serv', priority, weight, port, '192.168.1.1')).to eq({})
     end
   end
 
-  describe "#create_httpred_record" do
+  describe '#create_httpred_record' do
     let(:description) { 'hunky dory redirect description' }
     let(:keywords) { 'omg,keywords,redirect' }
     let(:redirect_type) { 'STANDARD - 302' }
     let(:title) { 'wat' }
 
     it 'creates an srv record' do
-      expect(subject).to receive(:create_record).with('something.wanelo.com', 'redirect', 'HTTPRED', '192.168.1.1', {"redirectType" => redirect_type, "description" => description, "keywords" => keywords, "title" => title}).and_return({})
+      expect(subject).to receive(:create_record).with('something.wanelo.com', 'redirect', 'HTTPRED', '192.168.1.1', 'redirectType' => redirect_type, 'description' => description, 'keywords' => keywords, 'title' => title).and_return({})
 
       expect(subject.create_httpred_record('something.wanelo.com', 'redirect', '192.168.1.1', redirect_type, description, keywords, title)).to eq({})
     end
   end
 
-  describe "#update_record" do
-    let(:response) { "{}" }
+  describe '#update_record' do
+    let(:response) { '{}' }
 
     before do
       subject.stub(:get_id_by_domain).with('something.wanelo.com').and_return(123)
@@ -285,11 +297,9 @@ describe DnsMadeEasy do
     it 'updates a record' do
       body = '{"name":"mail","type":"A","value":"1.1.1.1","ttl":3600,"gtdLocation":"DEFAULT","id":21}'
 
-
-      stub_request(:put, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/21/").
-        with(headers: request_headers, body: body).
-        to_return(:status => 200, :body => response, :headers => {})
-
+      stub_request(:put, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/21/')
+        .with(headers: request_headers, body: body)
+        .to_return(status: 200, body: response, headers: {})
 
       expect(subject.update_record('something.wanelo.com', 21, 'mail', 'A', '1.1.1.1', {})).to eq({})
     end
@@ -324,13 +334,11 @@ describe DnsMadeEasy do
 
       body = '[{"id":21,"name":"mail","type":"A","value":"1.1.1.1","gtdLocation":"DEFAULT","ttl":3600},{"id":22,"name":"post","type":"A","value":"1.1.1.2","gtdLocation":"DEFAULT","ttl":3600}]'
 
+      stub_request(:put, 'https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/updateMulti/')
+        .with(headers: request_headers, body: body)
+        .to_return(status: 200, body: response, headers: {})
 
-      stub_request(:put, "https://api.dnsmadeeasy.com/V2.0/dns/managed/123/records/updateMulti/").
-        with(headers: request_headers, body: body).
-        to_return(status: 200, body: response, headers: {})
-
-
-      expect(subject.update_records('something.wanelo.com', records, { 'ttl' => 3600 })).to eq({})
+      expect(subject.update_records('something.wanelo.com', records, 'ttl' => 3600)).to eq({})
     end
   end
 
@@ -359,18 +367,18 @@ describe DnsMadeEasy do
     end
 
     it 'gets the failover config for a failover enabled record' do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/monitor/21").
-        with(headers: request_headers).
-        to_return(status: 200, body: response, headers: {})
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/monitor/21')
+        .with(headers: request_headers)
+        .to_return(status: 200, body: response, headers: {})
 
-      expect(subject.get_failover_config(21)).to eq({
+      expect(subject.get_failover_config(21)).to eq(
         'port' => 80,
         'source' => 1,
         'failover' => true,
         'ip1' => '1.1.1.1',
         'ip2' => '2.2.2.2',
         'protocolId' => 3,
-        'sourceId' => 104620,
+        'sourceId' => 104_620,
         'monitor' => true,
         'sensitivity' => 5,
         'systemDescription' => 'Test',
@@ -382,71 +390,70 @@ describe DnsMadeEasy do
         'ip5Failed' => 0,
         'recordId' => 21,
         'autoFailover' => false
-        })
+      )
     end
   end
 
   describe '#disable_failover' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
     let(:body) { '{"failover":false,"monitor":false,"port":80,"sensitivity":5}' }
 
     it 'disables the failover config for a failover enabled record' do
-      stub_request(:put, "https://api.dnsmadeeasy.com/V2.0/monitor/21").
-        with(headers: request_headers, body: body).
-        to_return(status: 200, body: response, headers: {})
+      stub_request(:put, 'https://api.dnsmadeeasy.com/V2.0/monitor/21')
+        .with(headers: request_headers, body: body)
+        .to_return(status: 200, body: response, headers: {})
 
-      expect(subject.disable_failover(21, { 'port' => 80, 'sensitivity' => 5 })).to eq({})
+      expect(subject.disable_failover(21, 'port' => 80, 'sensitivity' => 5)).to eq({})
     end
   end
 
   describe '#update_failover_config' do
-    let(:response) { "{}" }
+    let(:response) { '{}' }
     let(:body) do
       '{"protocolId":3,"port":80,"systemDescription":"Test","sensitivity":3,"failover":true,"monitor":false,"maxEmails":1,"autoFailover":false,"source":1,"httpFqdn":"example.com","httpFile":"/magic","httpQueryString":"more-magic","ip1":"1.1.1.1","ip2":"2.2.2.2"}'
     end
 
-    it "updates the failover config" do
-      stub_request(:put, "https://api.dnsmadeeasy.com/V2.0/monitor/21").
-        with(headers: request_headers, body: body).
-        to_return(status: 200, body: response, headers: {})
+    it 'updates the failover config' do
+      stub_request(:put, 'https://api.dnsmadeeasy.com/V2.0/monitor/21')
+        .with(headers: request_headers, body: body)
+        .to_return(status: 200, body: response, headers: {})
 
-      expect(subject.update_failover_config(21, ['1.1.1.1', '2.2.2.2'], 'Test', 'HTTP', {
-        'port' => 80,
-        'httpFqdn' => 'example.com',
-        'httpFile' => '/magic',
-        'httpQueryString' => 'more-magic',
-        'sensitivity' => 3
-      })).to eq({})
+      expect(subject.update_failover_config(21, ['1.1.1.1', '2.2.2.2'], 'Test', 'HTTP',
+                                            'port' => 80,
+                                            'httpFqdn' => 'example.com',
+                                            'httpFile' => '/magic',
+                                            'httpQueryString' => 'more-magic',
+                                            'sensitivity' => 3)).to eq({})
     end
   end
 
-  describe "#request" do
+  describe '#request' do
     before do
-      stub_request(:get, "https://api.dnsmadeeasy.com/V2.0/some_path").
-        with(headers: request_headers).
-        to_return(status: status, body: body, headers: {})
+      stub_request(:get, 'https://api.dnsmadeeasy.com/V2.0/some_path')
+        .with(headers: request_headers)
+        .to_return(status: status, body: body, headers: {})
     end
 
     let(:response) do
-      subject.send(:request, "/some_path") { |uri|
+      subject.send(:request, '/some_path') do |uri|
         Net::HTTP::Get.new(uri.path)
-      }
+      end
     end
 
-    context "with a 2xx, empty-string response" do
+    context 'with a 2xx, empty-string response' do
       let(:status) { 200 }
-      let(:body) { "" }
+      let(:body) { '' }
 
-      it "handles gracefully" do
+      it 'handles gracefully' do
         expect(response).to eq({})
       end
     end
 
-    context "with a non-2xx response" do
+    context 'with a non-2xx response' do
       let(:status) { 400 }
       let(:body) { "<xml> JSON.parse won't like this very much </xml>" }
 
-      it "raises a Net::HTTPServerException instead of a JSON::ParserError" do
+      it 'raises a Net::HTTPServerException instead of a JSON::ParserError' do
         expect { response }.to raise_exception(Net::HTTPServerException)
       end
     end

data/spec/spec_helper.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'webmock/rspec'
 
 RSpec.configure do |config|
-
-  config.filter_run :focus => true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 
   if config.files_to_run.one?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dnsmadeeasy-rest-api
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.0.9
 platform: ruby
 authors:
 - Arnoud Vermeer
@@ -10,10 +10,10 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-30 00:00:00.000000000 Z
+date: 2020-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -27,7 +27,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -41,7 +41,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -55,7 +55,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -88,7 +88,7 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/funzoneq/dnsmadeeasy-rest-api
 licenses:
-- Apache
+- Apache-2.0
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -105,8 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: DNS Made Easy V2.0 REST API client for Ruby