dns_monkey 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8cce7f6719d57e77d5dc9c4ce83c265e578dafe2ceb0a30176439ecd202177b
-  data.tar.gz: d73bf5872231a9969ee5976d0b42baaed062c409906d8248140e5e5abbe106be
+  metadata.gz: b100dd3944b4c70296e2ca97efe3ebde2e2cca0e4e5f72a962c4c28b31c1410e
+  data.tar.gz: 66bf30794c0854c56304309fa768b3e69adbb0228ead121f98dba1b8aeda4e9e
 SHA512:
-  metadata.gz: 5b26890e41e969009eab9272170fd1c2b72f301fec86718a9a05b2c94c6e15712d74ea45b43e1d1775617121473fefba2dc942272d42b0c7623f12776146af29
-  data.tar.gz: aab352bbac653632edfed56f23a04ce0d2a3c12a0778f56551ea98913563c0491b9af9b760089d75d0dd1dc0a66a80e9ee99672fa3b641b885d56589b7b70604
+  metadata.gz: 95fbc64f2c8ae87e7d9c6326b28cd75abd802dc85e8d7c13127987ad20ef99a02e0424d9225346eb2e0f26a41804551de70758634db634699733b93910a95e3d
+  data.tar.gz: 798842f39c09c47197b9f7fb9477792bd95767570da5fd89ee62dfe38889f23a91b2a604ac94133045de17a2e905b3adf5e530698924a1f926542d5539b64a03

data/lib/dns_monkey.rb

@@ -16,11 +16,8 @@ class DNSMonkey
   #   exist
   #
   def a_record_name(name)
-    if cname_record?(name)
-      a_record_name(resolv_cname_record(name).name)
-    elsif a_record?(name)
-      name.to_s
-    end
+    return a_record_name(resolv_cname_record(name).name) if cname_record?(name)
+    return name.to_s if a_record?(name)
   end
 
   private

data/lib/dns_monkey/version.rb

@@ -1,3 +1,3 @@
 class DNSMonkey
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.2'.freeze
 end

data/spec/unit/dns_monkey_spec.rb

@@ -2,6 +2,7 @@ require 'dns_monkey'
 
 describe DNSMonkey do
   subject { DNSMonkey.new(resolver: resolver) }
+
   let(:resolver) { Resolv::DNS.new }
 
   it 'responds to #a_record_name' do
@@ -9,54 +10,23 @@ describe DNSMonkey do
   end
 
   describe '#a_record_name' do
-    let(:bad_record_name) { 'bad-record.domain.com' }
-    let(:a_record_name) { 'a-record.domain.com' }
-    let(:a_record_ip) { '8.8.4.4' }
-    let(:cname_record_name) { 'cname-record.domain.com' }
-    let(:a_record) { Resolv::DNS::Resource::IN::A.new(a_record_ip) }
-    let(:cname_record_dns_name) { Resolv::DNS::Name.create(a_record_name) }
-    let(:cname_record) { Resolv::DNS::Resource::IN::CNAME.new(cname_record_dns_name) }
-
-    before do
-      allow(resolver).to receive(:getresource)
-        .with(cname_record_name, Resolv::DNS::Resource::IN::CNAME)
-        .and_return(cname_record)
-
-      allow(resolver).to receive(:getresource)
-        .with(cname_record.name, Resolv::DNS::Resource::IN::CNAME)
-        .and_raise(Resolv::ResolvError)
-
-      allow(resolver).to receive(:getresource)
-        .with(cname_record.name, Resolv::DNS::Resource::IN::A)
-        .and_return(a_record)
-
-      allow(resolver).to receive(:getresource)
-        .with(a_record_name, Resolv::DNS::Resource::IN::CNAME)
-        .and_raise(Resolv::ResolvError)
-
-      allow(resolver).to receive(:getresource)
-        .with(a_record_name, Resolv::DNS::Resource::IN::A)
-        .and_return(a_record)
-
-      allow(resolver).to receive(:getresource)
-        .with(bad_record_name, Resolv::DNS::Resource::IN::CNAME)
-        .and_raise(Resolv::ResolvError)
-
-      allow(resolver).to receive(:getresource)
-        .with(bad_record_name, Resolv::DNS::Resource::IN::A)
-        .and_raise(Resolv::ResolvError)
-    end
 
-    it 'returns name of a record, when passed an a record name' do
+    let(:non_existent_record_name) { 'non-existent.dns-monkey.knowitnot.com' }
+    let(:a_record_name) { 'my-a-record.dns-monkey.knowitnot.com' }
+    let(:cname_record_name) { 'my-cname-record.dns-monkey.knowitnot.com' }
+    let(:other_cname_record_name) { 'my-other-cname-record.dns-monkey.knowitnot.com' }
+
+    it 'returns name of A record, when passed an A record name' do
       expect(subject.a_record_name(a_record_name)).to eq(a_record_name)
     end
 
-    it 'returns name of a record, when passed a cname record name' do
+    it 'returns name of A record, when passed a CNAME record name' do
       expect(subject.a_record_name(cname_record_name)).to eq(a_record_name)
+      expect(subject.a_record_name(other_cname_record_name)).to eq(a_record_name)
     end
 
-    it 'returns nil when passed an invalid a record name' do
-      expect(subject.a_record_name(bad_record_name)).to be nil
+    it 'returns nil when passed a non-existent record name' do
+      expect(subject.a_record_name(non_existent_record_name)).to be nil
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dns_monkey
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Jason Barnett