dns_adapter 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b0483dc7da91d95937b2dff3030112364e6bf83
-  data.tar.gz: 0533d3a5065cbb55d1e0437ca6167a86fedfa7ab
+  metadata.gz: 3d8dfc76014b9bfd17a92150ac19f3846adad58e
+  data.tar.gz: 6aea0dfbb4a549a6304243cc7a777944027fea83
 SHA512:
-  metadata.gz: 7b9fd402afa3ae99570c873d97bbaa3c76636101581836bb446555acf63328f4977cf0e0d8a44de419e13d4619facec6170eb9883a882ef6bd6d7a6b00bd3229
-  data.tar.gz: 453f44dc46487bb078e4842c3b9606248f83b805ee70bedce1184e0f54361e30e7bf34b939a7be642b88a63ebb6164617f5c9d5b1d19d9c3f488d08c3afe0abb
+  metadata.gz: 32bd75b2bdb092278b03737d27d3fefb4e1a5a1401b241e5507c1f710e870a314ff0cee804a0da547f46c20feac077d6a406e356fe23fe6fed0d408fba55012e
+  data.tar.gz: c027ec4d89fb7b870c823ff8f0dd80e6239fde10c2089cd23524d09938e610fa834c803e64ed07ac7707e760da85002e4348cfa062674775501f6fc109449525

data/lib/dns_adapter/mock_client.rb

@@ -30,6 +30,10 @@ module DNSAdapter
       fetch_records(domain, 'NS')
     end
 
+    def fetch_cname_records(domain)
+      fetch_records(domain, 'CNAME')
+    end
+
     def fetch_txt_records(domain)
       fetch_records(domain, 'TXT')
     end
@@ -80,6 +84,7 @@ module DNSAdapter
       'MX' => :exchange,
       'PTR' => :name,
       'NS' => :name,
+      'CNAME' => :name,
       'SPF' => :text,
       'TXT' => :text
     }

data/lib/dns_adapter/resolv_client.rb

@@ -38,6 +38,10 @@ module DNSAdapter
       fetch_name_records(domain, 'NS')
     end
 
+    def fetch_cname_records(domain)
+      fetch_name_records(domain, 'CNAME')
+    end
+
     private
 
     def fetch_a_type_records(domain, type)
@@ -104,7 +108,7 @@ module DNSAdapter
       raise DNSAdapter::Error, "Error on DNS lookup of '#{domain}'"
     end
 
-    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF NS)
+    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF NS CNAME)
     def self.type_class(rr_type)
       if SUPPORTED_RR_TYPES.include?(rr_type)
         Resolv::DNS::Resource::IN.const_get(rr_type)

data/lib/dns_adapter/version.rb

@@ -1,3 +1,3 @@
 module DNSAdapter
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/resolv_client_spec.rb

@@ -423,4 +423,58 @@ describe DNSAdapter::ResolvClient do
         .to raise_error(DNSAdapter::TimeoutError)
     end
   end
+
+  context '#fetch_cname_records' do
+    let(:first_cname_name) { SecureRandom.hex(10) }
+    let(:first_cname_record) do
+      Resolv::DNS::Resource::IN::CNAME.new(first_cname_name)
+    end
+    let(:record_list) { [first_cname_record] }
+    let(:cname_domain) { 'example.com' }
+    let(:cname_domain_with_trailing) { "#{cname_domain}." }
+
+    it 'should map the Resolv classes to a set of hashes' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(cname_domain, Resolv::DNS::Resource::IN::CNAME)
+        .and_return(record_list)
+      results = subject.fetch_cname_records(cname_domain)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'CNAME' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_cname_name])
+    end
+
+    it 'should map when the domain has a trailing dot' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(cname_domain, Resolv::DNS::Resource::IN::CNAME)
+        .and_return(record_list)
+      results = subject.fetch_cname_records(cname_domain_with_trailing)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'CNAME' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_cname_name])
+    end
+
+    it 'should map the Resolv errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(cname_domain, Resolv::DNS::Resource::IN::CNAME)
+        .and_raise(Resolv::ResolvError)
+      expect { subject.fetch_cname_records(cname_domain_with_trailing) }
+        .to raise_error(DNSAdapter::Error)
+    end
+
+    it 'should map the Resolv timeout errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(cname_domain, Resolv::DNS::Resource::IN::CNAME)
+        .and_raise(Resolv::ResolvTimeout)
+      expect { subject.fetch_cname_records(cname_domain_with_trailing) }
+        .to raise_error(DNSAdapter::TimeoutError)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dns_adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Peter M. Goldstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-16 00:00:00.000000000 Z
+date: 2015-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: An adapter layer for DNS queries.