dm-is-reflective 1.0.0 → 1.0.1.rc

data/CHANGES

@@ -1,5 +1,10 @@
 = dm-is-reflective changes history
 
+=== dm-is-reflective 1.0.1, ?
+* allow_nil is more close to db's semantics, not required. Thanks miaout17.
+  `:allow_nil` allows empty value, but `:required` does not. So here we
+  always use `:allow_nil` to match db's semantics.
+
 === dm-is-reflective 1.0.0, 2011-06-16
 * updated against dm-core 1.1.0
 

data/dm-is-reflective.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{dm-is-reflective}
-  s.version = "1.0.0"
+  s.version = "1.0.1.rc"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Lin Jen-Shin (godfat)}]
-  s.date = %q{2011-06-16}
+  s.date = %q{2011-07-19}
   s.description = %q{DataMapper plugin that helps you manipulate an existing database. It creates mappings between existing columns and model's properties.}
   s.email = [%q{godfat (XD) godfat.org}]
   s.extra_rdoc_files = [

data/lib/dm-is-reflective/is/adapters/mysql_adapter.rb

@@ -34,7 +34,7 @@ module DataMapper
           attrs[:serial] = true if field.extra      == 'auto_increment'
           attrs[:key]    = true if field.column_key == 'PRI'
 
-          attrs[:required] = field.is_nullable != 'YES'
+          attrs[:allow_nil] = field.is_nullable == 'YES'
           attrs[:default]  = field.column_default           if
             field.column_default
 

data/lib/dm-is-reflective/is/adapters/postgres_adapter.rb

@@ -53,7 +53,7 @@ module DataMapper
 
         attrs[:serial] = true if field.column_default =~ /nextval\('\w+'\)/
         attrs[:key] = true if field.key?
-        attrs[:required] = field.is_nullable != 'YES'
+        attrs[:allow_nil] = field.is_nullable == 'YES'
         # strip string quotation
         attrs[:default] = field.column_default.gsub(/^'(.*?)'$/, '\1') if
           field.column_default && !attrs[:serial]

data/lib/dm-is-reflective/is/adapters/sqlite_adapter.rb

@@ -32,7 +32,7 @@ module DataMapper
           attrs[:key] = true
           attrs[:serial] = true if supports_serial?
         end
-        attrs[:required] = field.notnull == 1
+        attrs[:allow_nil] = field.notnull == 0
         attrs[:default] = field.dflt_value[1..-2] if field.dflt_value
 
         if field.type.upcase == 'TEXT'

data/lib/dm-is-reflective/is/version.rb

@@ -2,7 +2,7 @@
 module DataMapper
   module Is
     module Reflective
-      VERSION = '0.9.0'
+      VERSION = '1.0.1.rc'
     end
   end
 end

data/lib/dm-is-reflective/version.rb

@@ -2,7 +2,7 @@
 module DataMapper
   module Is
     module Reflective
-      VERSION = '1.0.0'
+      VERSION = '1.0.1.rc'
     end
   end
 end

data/test/abstract.rb

@@ -8,8 +8,8 @@ module Abstract
     raise 'please provide a clean database because it is a destructive test!!'
   end
 
-  AttrCommon   = {:required => false}
-  AttrCommonPK = {:serial => true, :key => true, :required => true}
+  AttrCommon   = {:allow_nil => true}
+  AttrCommonPK = {:serial => true, :key => true, :allow_nil => false}
   AttrText     = {:length => 65535}.merge(AttrCommon)
 
   def user_fields
@@ -22,8 +22,8 @@ module Abstract
   def comment_fields
     [[:body,    DataMapper::Property::Text,    AttrText],
      [:id,      DataMapper::Property::Serial,  AttrCommonPK],
-     [:title,   String,   {:length => 50, :default => 'default title'}.
-                            merge(AttrCommon)],
+     [:title,   String,   {:length => 50, :default => 'default title',
+                           :allow_nil => false}],
      [:user_id, Integer,  AttrCommon]]
   end
 
@@ -67,7 +67,8 @@ module Abstract
     belongs_to :user, :required => false
 
     property :id,    Serial
-    property :title, String,  :length => 50, :default => 'default title'
+    property :title, String,  :length => 50, :default => 'default title',
+                              :allow_nil => false
     property :body,  Text
 
     is :reflective
@@ -196,6 +197,10 @@ module Abstract
     }
   end
 
+  def test_allow_empty_string
+    assert Comment.new(:title => '').save
+  end
+
   def test_auto_genclasses
     scope = new_scope
     assert_equal ["#{scope == Object ? '' : "#{scope}::"}AbstractComment",

metadata

@@ -1,19 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: dm-is-reflective
 version: !ruby/object:Gem::Version
-  version: 1.0.0
-  prerelease: 
+  version: 1.0.1.rc
+  prerelease: 6
 platform: ruby
 authors:
 - Lin Jen-Shin (godfat)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-06-16 00:00:00.000000000Z
+date: 2011-07-19 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dm-core
-  requirement: &2160101400 !ruby/object:Gem::Requirement
+  requirement: &2152609200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2160101400
+  version_requirements: *2152609200
 - !ruby/object:Gem::Dependency
   name: dm-do-adapter
-  requirement: &2160100780 !ruby/object:Gem::Requirement
+  requirement: &2152608560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2160100780
+  version_requirements: *2152608560
 - !ruby/object:Gem::Dependency
   name: dm-migrations
-  requirement: &2160100040 !ruby/object:Gem::Requirement
+  requirement: &2152607860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160100040
+  version_requirements: *2152607860
 - !ruby/object:Gem::Dependency
   name: dm-sqlite-adapter
-  requirement: &2160075900 !ruby/object:Gem::Requirement
+  requirement: &2152607200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160075900
+  version_requirements: *2152607200
 - !ruby/object:Gem::Dependency
   name: dm-mysql-adapter
-  requirement: &2160075200 !ruby/object:Gem::Requirement
+  requirement: &2152606480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160075200
+  version_requirements: *2152606480
 - !ruby/object:Gem::Dependency
   name: dm-postgres-adapter
-  requirement: &2160074520 !ruby/object:Gem::Requirement
+  requirement: &2152605820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160074520
+  version_requirements: *2152605820
 description: DataMapper plugin that helps you manipulate an existing database. It
   creates mappings between existing columns and model's properties.
 email:
@@ -130,9 +130,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5