djsun-mongo_mapper 0.5.6.2 → 0.5.6.3

data/VERSION

@@ -1 +1 @@
-0.5.6.2
+0.5.6.3

data/djsun-mongo_mapper.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{djsun-mongo_mapper}
-  s.version = "0.5.6.2"
+  s.version = "0.5.6.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["John Nunemaker"]

data/lib/mongo_mapper/embedded_document.rb

@@ -269,6 +269,7 @@ module MongoMapper
       end
 
       def ==(other)
+        return false unless other.is_a?(EmbeddedDocument)
         ignore = { '_id' => nil }
         attributes.merge(ignore) == other.attributes.merge(ignore)
       end

data/test/unit/test_document.rb

@@ -173,8 +173,15 @@ class DocumentTest < Test::Unit::TestCase
         doc_2 = @document.new('name' => "Doc 2")
         doc_1.should_not == doc_2
       end
+      
+      should "not be == when comparing other object types" do
+        doc = @document.new('name' => "Doc")
+        doc.should_not == nil
+        doc.should_not == false
+        doc.should_not == { 'name' => "Doc" }
+      end
 
-      should "not care about type" do
+      should "not care about document type" do
         @person = Class.new do
           include MongoMapper::EmbeddedDocument
 
@@ -195,13 +202,20 @@ class DocumentTest < Test::Unit::TestCase
         doc_1.should eql?(doc_2)
       end
 
-      should "not be == if type matches but key values are different" do
+      should "not be eql? if type matches but key values are different" do
         doc_1 = @document.new('name' => "Doc 1")
         doc_2 = @document.new('name' => "Doc 2")
         doc_1.should_not eql?(doc_2)
       end
 
-      should "not be eql? if types are different even if values are the same" do
+      should "not be eql? when comparing other object types" do
+        doc = @document.new('name' => "Doc")
+        doc.should_not eql?(nil)
+        doc.should_not eql?(false)
+        doc.should_not eql?({ 'name' => "Doc" })
+      end
+
+      should "not be eql? if document types are different even if values are the same" do
         @person = Class.new do
           include MongoMapper::EmbeddedDocument
 

data/test/unit/test_embedded_document.rb

@@ -657,7 +657,14 @@ class EmbeddedDocumentTest < Test::Unit::TestCase
         doc_1.should_not == doc_2
       end
 
-      should "not care about type" do
+      should "not be == when comparing other object types" do
+        doc = @document.new('name' => "Doc")
+        doc.should_not == nil
+        doc.should_not == false
+        doc.should_not == { 'name' => "Doc" }
+      end
+
+      should "not care about document type" do
         @person = Class.new do
           include MongoMapper::EmbeddedDocument
 
@@ -678,12 +685,19 @@ class EmbeddedDocumentTest < Test::Unit::TestCase
         doc_1.should eql?(doc_2)
       end
 
-      should "not be == if type matches but key values are different" do
+      should "not be eql? if type matches but key values are different" do
         doc_1 = @document.new('name' => "Doc 1")
         doc_2 = @document.new('name' => "Doc 2")
         doc_1.should_not eql?(doc_2)
       end
 
+      should "not be eql? when comparing other object types" do
+        doc = @document.new('name' => "Doc")
+        doc.should_not eql?(nil)
+        doc.should_not eql?(false)
+        doc.should_not eql?({ 'name' => "Doc" })
+      end
+
       should "not be eql? if types are different even if values are the same" do
         @person = Class.new do
           include MongoMapper::EmbeddedDocument

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: djsun-mongo_mapper
 version: !ruby/object:Gem::Version 
-  version: 0.5.6.2
+  version: 0.5.6.3
 platform: ruby
 authors: 
 - John Nunemaker