divvy_up 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7428ae33e30e958f738f5af7e4ae41fdd667774c
-  data.tar.gz: 7b499f0c387fc0f36dbc6b6119d0e7ec0f624986
+  metadata.gz: cb8031716a0ff8be7b2330f02f3729980a2f0611
+  data.tar.gz: f7e589444af474686c6ab06ca77d9dd01becdd69
 SHA512:
-  metadata.gz: 5d6402894878432babb2ed1c555fd042b1aeed327a7c11b7f7cc4fd579e7daaa7b531cdd9ed30759c39e73f94c0fddf04fce8cbfe72d3f9f41d04e113dfecac8
-  data.tar.gz: 31025cac7d76fbe7294fbb0fcb41f25b56d04fd33a274703e6e604977b84efecb9d84ecacea46ba445a534982a4d293ec041f9cf7c93214cde5b49394c81ed13
+  metadata.gz: eacc87d816ed1236597a458a0a2ef90578647bd6529ce88aeedbb91e92ba788ae8b10f6e6a6dab071eb497e4525cf6247f04bf502d99d5262e032f9c81bc6a67
+  data.tar.gz: ce779873f08a334cc3f9476c27c487e2e374d034160826115852fe96aba95703428e128b255c659f238d9985f5c8c799c09d5949de69bf1867f8e0bbabfb4bdf

data/CHANGELOG.md

@@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [0.1.2] - 2015-07-09
+### Fixed
+- Resolve potential infinite loop in `#split` occurring when no valid solution is possible using "permute" technique
+
 ## [0.1.1] - 2015-07-05
 ### Fixed
 - Resolve error occurring in `#split` method for certain list and group number combinations
@@ -15,6 +19,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## 0.0.1 - 2015-03-09
 - Initial release
 
-[unreleased]: https://github.com/djpowers/divvy_up/compare/v0.1.1...HEAD
-[0.1.1]: https://github.com/djpowers/divvy_up/compare/v0.0.1...v0.1.1
+[unreleased]: https://github.com/djpowers/divvy_up/compare/v0.1.2...HEAD
+[0.1.2]: https://github.com/djpowers/divvy_up/compare/v0.1.1...v0.1.2
+[0.1.1]: https://github.com/djpowers/divvy_up/compare/v0.1.0...v0.1.1
 [0.1.0]: https://github.com/djpowers/divvy_up/compare/v0.0.1...v0.1.0

data/lib/divvy_up/list.rb

@@ -113,15 +113,14 @@ module DivvyUp
     def output_final_sublists(sublist_options_sorted)
       sublists = []
       accounted_items = []
-      until sublists.size == @groups
-        sublist_options_sorted.each do |list|
-          if (accounted_items & list.keys).empty?
-            sublists << [list, (list.values.reduce(:+)).round(2)]
-            accounted_items << list.keys
-            accounted_items.flatten!
-          end
+      sublist_options_sorted.each do |list|
+        if (accounted_items & list.keys).empty?
+          sublists << [list, (list.values.reduce(:+)).round(2)]
+          accounted_items << list.keys
+          accounted_items.flatten!
         end
       end
+      sublists = nil if sublists.count > @groups
       sublists
     end
 
@@ -130,6 +129,7 @@ module DivvyUp
       snake_result = snake
       price_is_right_result = price_is_right
       results = [permute_result, snake_result, price_is_right_result]
+      results.delete(nil)
       result_differences = []
       results.each do |result|
         result_totals = []

data/lib/divvy_up/version.rb

@@ -1,3 +1,3 @@
 module DivvyUp
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/divvy_up/list_spec.rb

@@ -87,5 +87,17 @@ module DivvyUp
         ]
       )
     end
+
+    it "splits a large list into three groups" do
+      shopping_list = { orange_juice_1: 3, orange_juice_2: 3, eggs_dozen: 2.99, spring_mix_16_oz: 6.99, bacon: 4.99, pasta_sauce: 2.50, blueberries: 3.99, frozen_strawberries: 2.99, olive_oil: 8.99, paper_towels: 1.59, toilet_paper: 1.99, aluminum_foil: 3 }
+      list = DivvyUp::List.new(shopping_list)
+      expect(list.split(3)).to eql(
+        [
+          [{olive_oil:8.99, orange_juice_1:3, orange_juice_2:3, paper_towels:1.59}, 16.58],
+          [{spring_mix_16_oz:6.99, aluminum_foil:3, frozen_strawberries:2.99, toilet_paper:1.99}, 14.97],
+          [{bacon:4.99, blueberries:3.99, eggs_dozen:2.99, pasta_sauce:2.5}, 14.47]
+        ]
+      )
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: divvy_up
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Dave Powers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-06 00:00:00.000000000 Z
+date: 2015-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler