distack-urlsign 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 745e324c38d3c2c0fafb181c84ed5749e6863bda
-  data.tar.gz: fc92d7917e73f06cf2bd6d04f1ebb31483d801dc
+  metadata.gz: 7fa33d08fc927d8297e304ce2966779fdd8ca6ab
+  data.tar.gz: 3474af3ad913ee2e79ae0f2cf78ec3915c6ff7b8
 SHA512:
-  metadata.gz: aba5d78de6da6c8c2bf3c5a8b6ef591f4354a3a1738122b89ab44c6b1eef16d0fabc2d70223a3339dad9e5a74dfbe5814064a631ca9f1be8f1a4f84c54db035f
-  data.tar.gz: b03b1a4ad561ead878ac870a4e693c3347c16c7412a34f0a2dbd1f1767971dd955bfc9f66d215426cea629b3d8eaac7be796397f8ca412505b001e626092420d
+  metadata.gz: 1ad987c2d9c6fbe61bcb5a8b5783e3d2274a9cdde280c05261573a3ca5ffc2d099c4914f36d862883288bbf05d37848be8f2b89087279575e54900ba1d1191a3
+  data.tar.gz: cb5812370e9ba645c89c271cf91c28c2f50b20bcef87e3dc4188cf915a8e189d741d8bbb1ec5d04d5ae64490d11053e5a587cf933b098ba773741bb0a55dbad4

data/.ruby-version

@@ -0,0 +1 @@
+2.2.2

data/.travis.yml

@@ -1,3 +1,4 @@
+sudo: false
 language: ruby
 rvm:
-  - 2.2.0
+  - 2.2.2

data/Rakefile

@@ -1 +1,6 @@
 require "bundler/gem_tasks"
+
+task :default => :test
+task :test do
+  Dir.glob('./test/*_test.rb').each { |file| require file}
+end

data/distack-urlsign.gemspec

@@ -20,7 +20,8 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "rack"
 
-  spec.add_development_dependency "bundler", "~> 1.9"
+  spec.add_development_dependency "minitest", "~> 5.10.1"
+  spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "pry", "~> 0.10.1"
 end

data/lib/distack/urlsign/signer.rb

@@ -1,5 +1,7 @@
 module Distack::URLSign
   InvalidSignatureError = Class.new(StandardError)
+  MissingSignatureError = Class.new(StandardError)
+
 
   class Signer
     KEY_REGEX = /^[0-9A-f]+$/
@@ -43,19 +45,21 @@ module Distack::URLSign
       end
 
       q = Rack::Utils.parse_nested_query(url.query)
+      raise MissingSignatureError unless q["_signature"]
 
       original_q  = q.dup
       original_q.delete("_signature")
 
       original_qs = Rack::Utils.build_nested_query(original_q)
 
-      chunks = [url.scheme, "#{url.host}:#{url.port}", url.path, original_qs, url.userinfo].compact
+      host_with_port = url.port == url.default_port ? url.host : "#{url.host}:#{url.port}"
+      chunks = [url.scheme, host_with_port, url.path, original_qs, url.userinfo].compact
       digest = OpenSSL::Digest.new("sha512")
 
       rawsig    = OpenSSL::HMAC.digest(digest, @key, chunks.join)
       signature = Base64.urlsafe_encode64(rawsig)
 
-      if secure_compare(signature, q["_signature"])
+      if secure_compare(signature, URI.decode(q["_signature"]).to_s)
         new_url = url.dup
         new_url.query = original_qs
         new_url
@@ -64,6 +68,12 @@ module Distack::URLSign
       end
     end
 
+    def valid?(url)
+      !!verify(url)
+    rescue InvalidSignatureError, MissingSignatureError
+      false
+    end
+
     private
 
     # Constant time string comparison.

data/lib/distack/urlsign/version.rb

@@ -1,5 +1,5 @@
 module Distack
   module URLSign
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: distack-urlsign
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Rodrigo Kochenburger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-06-09 00:00:00.000000000 Z
+date: 2017-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -24,20 +24,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.10.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.10.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +89,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -107,9 +122,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: urlsign is a simple HMAC-based implementation for URL signing and verification
 test_files: []
-has_rdoc: