disposable 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d6e1ad3c3bf2e63ee78f3109a5dbdefc4a66e752
-  data.tar.gz: bdab6ed057dff4c820cb7bbb0e3129c566dbd7b1
+  metadata.gz: 95a247503e136210bf70026ebbf2a093de735bcc
+  data.tar.gz: d6f1d87dc8408223b808d6fa57c4286673393fb4
 SHA512:
-  metadata.gz: 565f5cce96dad1b569ec5747d4cab583de49e8ae93eb01b01ab0620b01f828f21b5c714bea8eef7a657b14c517ff460d99b8fa3fcce2cc53b099c2a6a9392deb
-  data.tar.gz: 0a89a7b63ff68773aaa44caaa92c1cc8128ef8b75d95b58036989f44f3c37a14c20f0cf3b21ff33c4b6b2417abc5147cb7fa82f6a0cf14e7a61949181dc11835
+  metadata.gz: 40be1a5438aa2bf43fb992bb413dc2c503e3ead6f3698e0c91077af418704be339fa9e85d544926241eb2191a0d6226485b60534ec4ef51d2ef7c44b004d8e0b
+  data.tar.gz: 4f7e86c71d723b08ff766360816239973955f98220c4ed0b1c93ef10c0372a56279c0a175a373f5ae4dade28c09a758e490713fe4773064bedc394a2f7dc85a9

data/CHANGES.md

@@ -1,3 +1,12 @@
+# 0.4.0
+
+* In `#sync {}` with block, `nil` values will now be included in the nested hash, resulting in a hash as follows.
+    ```ruby
+    twin.sync do |nested_hash|
+      nested_hash #=> {  uuid: nil, title: "Greatest Hits" }
+    ```
+  Note that in earlier versions, `nil` values were not included in this hash.
+
 # 0.3.2
 
 * Rename `JSONB` to `Property::Hash`.

data/lib/disposable/twin/sync.rb

@@ -90,8 +90,9 @@ class Disposable::Twin
         def build_nested_hash_representer
           Sync.hash_representer(self) do |dfn|
             dfn.merge!(
-              readable: true, # the nested hash contains all fields.
-              as:       dfn[:private_name] # nested hash keys by model property names.
+              readable:   true, # the nested hash contains all fields.
+              as:         dfn[:private_name], # nested hash keys by model property names.
+              render_nil: dfn[:collection] ? nil : true,
             )
 
             dfn.merge!(

data/lib/disposable/version.rb

@@ -1,3 +1,3 @@
 module Disposable
-  VERSION = "0.3.2"
+  VERSION = "0.4.0"
 end

data/test/twin/save_test.rb

@@ -85,7 +85,7 @@ class SaveTest < MiniTest::Spec
       nested_hash = hash
     end
 
-    nested_hash.must_equal({"name"=>"Live And Dangerous", "songs"=>[{"title"=>"Southbound"}, {"title"=>"The Boys Are Back In Town", "composer"=>{"name"=>"Lynott"}}], "artist"=>{"name"=>"Thin Lizzy"}})
+    nested_hash.must_equal({"name"=>"Live And Dangerous", "songs"=>[{"title"=>"Southbound", "composer"=>nil}, {"title"=>"The Boys Are Back In Town", "composer"=>{"name"=>"Lynott"}}], "artist"=>{"name"=>"Thin Lizzy"}})
 
     # nothing written to model.
     album.name.must_equal nil
@@ -189,4 +189,4 @@ end
 #     song.length.must_equal nil
 #     song.id.must_equal "10: 120"
 #   end
-# end
+# end

data/test/twin/sync_test.rb

@@ -94,26 +94,54 @@ class TwinSyncTest < MiniTest::Spec
       album.songs[1].composer.name.must_equal "Lynott"
     end
 
-    # save with block creates nested_hash and doesn't sync.
-    it do
-      twin = Twin::Album.new(album)
+    # save with block.
+    describe "#to_nested_hash" do
+      let (:twin) { Twin::Album.new(album) }
 
-      # this usually happens in Contract::Validate or in from_* in a representer
-      fill_out!(twin)
+      it "creates nested_hash and doesn't sync" do
+        # this usually happens in Contract::Validate or in from_* in a representer
+        fill_out!(twin)
+
+        nested_hash = nil
+        twin.sync do |hash|
+          nested_hash = hash
+        end
+
+        nested_hash.must_equal({"name"=>"Live And Dangerous", "songs"=>[{"title"=>"Southbound", "composer"=>nil}, {"title"=>"The Boys Are Back In Town", "composer"=>{"name"=>"Lynott"}}], "artist"=>{"name"=>"Thin Lizzy"}})
 
-      nested_hash = nil
-      twin.sync do |hash|
-        nested_hash = hash
+        # nothing written to model.
+        album.name.must_equal nil
+        album.songs[0].title.must_equal nil
+        album.songs[1].title.must_equal nil
+        album.songs[1].composer.name.must_equal nil
+        album.artist.name.must_equal nil
       end
 
-      nested_hash.must_equal({"name"=>"Live And Dangerous", "songs"=>[{"title"=>"Southbound"}, {"title"=>"The Boys Are Back In Town", "composer"=>{"name"=>"Lynott"}}], "artist"=>{"name"=>"Thin Lizzy"}})
+      describe "nil values" do
+        it "includes nil values, including nil collections" do
+          twin = Twin::Album.new(Model::Album.new(nil,
+            nil, # uninitialized nil collection.
+            nil)
+          )
 
-      # nothing written to model.
-      album.name.must_equal nil
-      album.songs[0].title.must_equal nil
-      album.songs[1].title.must_equal nil
-      album.songs[1].composer.name.must_equal nil
-      album.artist.name.must_equal nil
+          nested_hash = nil
+          twin.sync { |hash| nested_hash = hash }
+
+          nested_hash.must_equal({"name"=>nil, "artist"=>nil})
+        end
+
+        it "includes empty collections" do
+          twin = Twin::Album.new(Model::Album.new(nil,
+            [], # empty collection.
+            nil)
+          )
+
+          nested_hash = nil
+          twin.sync { |hash| nested_hash = hash }
+
+          nested_hash.must_equal({"name"=>nil, "songs"=>[], "artist"=>nil})
+        end
+      end
     end
 
 
@@ -125,4 +153,4 @@ class TwinSyncTest < MiniTest::Spec
       twin.artist.name = "Thin Lizzy"
     end
   end
-end
+end

data/test/twin/unnest_test.rb

@@ -21,4 +21,17 @@ class UnnestTest < MiniTest::Spec
     # also copies :nested.
     Twin.definitions.get(:email).extend(Declarative::Inspect).inspect.must_equal %{#<Disposable::Twin::Definition: @options={:private_name=>:email, :nested=>#<Class:>, :name=>\"email\", :readable=>false, :writeable=>false}>}
   end
+
+  it "exposes accessors on top-level twin" do
+    twin = Twin.new(OpenStruct.new(content: OpenStruct.new()))
+
+    twin.email.must_equal nil
+    twin.email= 2
+    twin.email.model.must_equal 2
+
+
+    twin.id.must_equal nil
+    twin.id = 1
+    twin.id.must_equal 1
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: disposable
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-05 00:00:00.000000000 Z
+date: 2016-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uber