disposable 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 333ff0a256285692e2f30e1dd908b671a8f93a0a
-  data.tar.gz: ff98cc474bd5b508066d459489c711643d6164e1
+  metadata.gz: 344f81de5499edef8813bf4f4c20d4b39e8b351f
+  data.tar.gz: 1e2a2305010b56e2f6a285a704206a54d6f6fb0e
 SHA512:
-  metadata.gz: 9ca99470a8d3eed471d107648d17fb8d9d3525e4191cb2d635404c5c4e9dcacf10c6fefec61ea4835a6a38a7083667a33f131a0fc442e6418c7d549e9f8c1dc1
-  data.tar.gz: c56cb7f98015746abf7ce43d05d6479e0bfa2b7c25df41a2c41f64fd3519c9613e08d755d335cb2128bc7a0b29f5b4e14dd5530bd6cf83c9b521217ad7475c21
+  metadata.gz: 0ae1f63242b61ca78b801762a36caeff71c292e83a146478e60916b5fac3a072879296dcee95c7dbe06a3b146a7f533613fd32bb9a4deb7ff7ceb287535163d1
+  data.tar.gz: e9d20cb50187ead62ff6a58ed89e4598e74168ab7d49a9edf857d0d46e683c521e616e448a76b66fdc341c41217067bd3b7b1b0b9c954f2af5d273a35d47e974

data/CHANGES.md

@@ -1,3 +1,7 @@
+# 0.1.2
+
+* Fix `Changed` which does not use the public reader to compare anymore, but the private `field_read`.
+
 # 0.1.1
 
 * Adding `Setup::SkipSetter` and `Sync::SkipGetter`.

data/lib/disposable/twin.rb

@@ -80,9 +80,19 @@ module Disposable
         return if dfn[:twin] and value.nil? # TODO: test me (model.composer => nil)
         value = dfn.array? ? wrap_collection(dfn, value) : wrap_scalar(dfn, value) if dfn[:twin]
 
+        field_write(name, value)
+      end
+
+      # Write the property's value without using the public writer.
+      def field_write(name, value)
         @fields[name.to_s] = value
       end
 
+      # Read the property's value without using the public reader.
+      def field_read(name)
+        @fields[name.to_s]
+      end
+
       def wrap_scalar(dfn, value)
         Twinner.new(dfn).(value)
       end

data/lib/disposable/twin/changed.rb

@@ -32,7 +32,7 @@ private
   end
 
   def write_property(name, value, dfn)
-    old_value = send(name)
+    old_value = field_read(name)
 
     super.tap do
       _changed[name.to_s] = old_value != value

data/lib/disposable/version.rb

@@ -1,3 +1,3 @@
 module Disposable
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/test/skip_getter_test.rb

@@ -34,4 +34,88 @@ class SkipGetterTest < MiniTest::Spec
     album.title.must_equal "Wild Frontier"
     album.artist.name.must_equal "Gary Moore"
   end
+end
+
+
+class SkipSetterTest < MiniTest::Spec
+  Album  = Struct.new(:title, :artist)
+  Artist = Struct.new(:name)
+
+  class AlbumTwin < Disposable::Twin
+    feature Setup::SkipSetter
+
+    property :title
+    property :artist do
+      property :name
+
+      def name=(v)
+        super(v.upcase)
+      end
+    end
+
+    def title=(v)
+      super(v.reverse)
+    end
+  end
+
+  it do
+    twin = AlbumTwin.new(Album.new("Wild Frontier", Artist.new("Gary Moore")))
+
+    twin.title.must_equal "Wild Frontier"
+    twin.artist.name.must_equal "Gary Moore"
+  end
+end
+
+
+class SkipGetterAndSetterWithChangedTest < MiniTest::Spec
+  Album  = Struct.new(:title, :artist)
+  Artist = Struct.new(:name)
+
+  class AlbumTwin < Disposable::Twin
+    feature Sync
+    feature Sync::SkipGetter
+    feature Setup::SkipSetter
+    feature Changed
+
+    property :title
+    property :artist do
+      property :name
+
+      def name
+        super.upcase
+      end
+
+      def name=(v)
+        super v.chop
+      end
+    end
+
+    def title
+      super.reverse
+    end
+
+    def title=(v)
+      super v.reverse
+    end
+  end
+
+  it do
+    album = Album.new("Wild Frontier", Artist.new("Gary Moore"))
+    twin  = AlbumTwin.new(album) # does not call getter (Changed).
+
+
+    twin.title.must_equal "reitnorF dliW"
+    twin.artist.name.must_equal "GARY MOORE"
+
+    twin.changed?.must_equal false
+    twin.artist.changed?.must_equal false
+
+    twin.title = "Self-Entitled"
+    twin.artist.name = "Nofx"
+
+    twin.sync # does NOT call getter.
+
+    album.title.must_equal "deltitnE-fleS"
+    album.artist.name.must_equal "Nof"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: disposable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Nick Sutterer
@@ -166,7 +166,6 @@ files:
 - test/expose_test.rb
 - test/persisted_test.rb
 - test/skip_getter_test.rb
-- test/skip_setter_test.rb
 - test/test_helper.rb
 - test/twin/benchmarking.rb
 - test/twin/builder_test.rb
@@ -221,7 +220,6 @@ test_files:
 - test/expose_test.rb
 - test/persisted_test.rb
 - test/skip_getter_test.rb
-- test/skip_setter_test.rb
 - test/test_helper.rb
 - test/twin/benchmarking.rb
 - test/twin/builder_test.rb

data/test/skip_setter_test.rb

@@ -1,30 +0,0 @@
-require "test_helper"
-
-class SkipSetterTest < MiniTest::Spec
-  Album  = Struct.new(:title, :artist)
-  Artist = Struct.new(:name)
-
-  class AlbumTwin < Disposable::Twin
-    feature Setup::SkipSetter
-
-    property :title
-    property :artist do
-      property :name
-
-      def name=(v)
-        super(v.upcase)
-      end
-    end
-
-    def title=(v)
-      super(v.reverse)
-    end
-  end
-
-  it do
-    twin = AlbumTwin.new(Album.new("Wild Frontier", Artist.new("Gary Moore")))
-
-    twin.title.must_equal "Wild Frontier"
-    twin.artist.name.must_equal "Gary Moore"
-  end
-end