display_case 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8309a666cba84ff544fb5cf9d97914bc228b8780
-  data.tar.gz: 821fe5d1b63f8fef408206a0d9bfe31c46c89a33
+  metadata.gz: b4e65f1433316f14dca449835da35f3f431c1163
+  data.tar.gz: 81f9de2392ef2ef606acea14d009b63c71ee72b8
 SHA512:
-  metadata.gz: 0615b6350ce33c59cd1c912769574502f06ed84d2957889a8c7c1682d0cc84a0bfffe6fbaa88fa849a2cee03784d872e58c71ae6b5f9c3fc7755b9141f520109
-  data.tar.gz: c8ea968c3df2d1fbef07c6e2f1b95b8af0fdaa1eb54252b3315f23c1295a74a238d8c9adf91edd275cdf78f667bf46115411422281b241110129324a2789241f
+  metadata.gz: 20eceab33a3c2feab1979a24ed53098eea29c0e8dce404d5e48488d47a1e4788dcab868cfc5e70e4ed5c27d45bb4eac2c1b9d718af2f43d09833e154c8bb7e0a
+  data.tar.gz: dfa1592a2e671d7d3eca646404ddc501139a3fd95d60e389dd0fbac7fdcd0f003fce1102c50cd4456f8ec6e6a511c1a338361349c1b0286567b1aa34b3608125

data/README.md

@@ -133,3 +133,25 @@ how to choose good keys.
 Wrong url with extra parameters using an exhibited model?
 ------------------
 See this issue for the reason: https://github.com/objects-on-rails/display-case/issues/8
+
+
+TypeError: superclass mismatch for class MyExhibit
+------------------
+This error is common in development mode in code bases which `ExhibitB` inherits from `ExhibitA`, which inherits from `DisplayCase::Exhibit`. 
+DisplayCase is doing a lot of messing around with your exhibits to make them respond appropriately as if they were the object you're exhibiting,
+and that is _normally_ the cause of this error if you're using inheritance among exhibits.
+
+However, since it's possible you could actually be inadvertently having a superclass mismatch, the recommended way around this error is to avoid 
+the situation.
+
+In case you're having this error, and you're confident that is _not_ happening, we do provide a configuration option to catch this 
+error and reload the class anyway. :warning: But be warned, if it is a legitimate superclass mismatch, you won't catch it with 
+this option turned on! :warning:
+
+To turn on this option, in your DisplayCase initializer:
+
+```ruby
+DisplayCase.configure do |config|
+  config.swallow_superclass_mismatch_for_exhibits = true
+end
+```

data/lib/display_case/configuration.rb

@@ -30,6 +30,10 @@ module DisplayCase
     # A boolean indicating whether Exhibits with names that are similar to
     # context should be favored over other exhibits. By default, this is true
     attr_accessor :smart_matching
+    
+    # A boolean indicating whether DisplayCase will swallow superclass mismatch
+    # errors (see README for more info). By default, this is false.
+    attr_accessor :swallow_superclass_mismatch_for_exhibits
 
     def initialize
       @definition_file_paths = %w(app/exhibits)
@@ -38,6 +42,7 @@ module DisplayCase
       @cache_store = nil
       @logging_enabled = false
       @smart_matching = true
+      @swallow_superclass_mismatch_for_exhibits = false
     end
 
     def explicit?
@@ -47,6 +52,10 @@ module DisplayCase
     def smart_matching?
       smart_matching
     end
+    
+    def swallow_superclass_mismatch_for_exhibits?
+      swallow_superclass_mismatch_for_exhibits
+    end
 
     def logging_enabled?
       defined? ::Rails and logging_enabled

data/lib/display_case/find_definitions.rb

@@ -19,8 +19,18 @@ module DisplayCase
   def self.display_case_load(file)
     @file_changes ||= {}
     if File.exists?(file) && (@file_changes[file].to_i < (mtime = File.mtime(file).to_i))
-      load file
-      @file_changes[file] = mtime
+      begin
+        load file
+        @file_changes[file] = mtime
+      rescue TypeError
+        klass = $!.message.gsub("superclass mismatch for class ", "").constantize
+        if klass.ancestors.include?(DisplayCase::Exhibit) && configuration.swallow_superclass_mismatch_for_exhibits?
+          Object.send(:remove_const, klass.name.to_sym)
+          retry
+        else
+          raise $!
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: display_case
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Avdi Grimm
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-08 00:00:00.000000000 Z
+date: 2015-03-29 00:00:00.000000000 Z
 dependencies: []
 description: An implementation of the Exhibit pattern, as described in Objects on
   Rails
@@ -49,9 +49,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: An implementation of the Exhibit pattern, as described in Objects on Rails
 test_files: []
-has_rdoc: