dispatch-rider 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8cefb6d56d04893f7ce7a4fc75dbd57f1c1148efac30e40ebd415190c480be6
-  data.tar.gz: 84f3c1c18b51123a08434e6c389521d6ea30760bf5823d72178c699d36de38b4
+  metadata.gz: e2d285970e4f0568ed26104410b0c1619f48ca60583ed41a694ad06a92a146be
+  data.tar.gz: 9a7f5fb0656497f5b9598cad100a769397d1b64587a06673c834c628079ceb5a
 SHA512:
-  metadata.gz: a52539c08456b5296f16cb02ce3e4c324307d23ae5bf4805a25ce1c5e437b0127dca7619a77f7957311657b16387d8d267f14fd0b85399b29a868f8ea7101727
-  data.tar.gz: 49b41b85fb54f6454cef746095291484533f44cf8eaab3f536b63d2ab130279cacb3219b2aec6286cf50818fc71ec6f15f59f87d94043157e5700754fefde0d9
+  metadata.gz: 4d3d5c7f71b887e31b89a47742f9710431c87401862f534be2b67795e63b03403c898137ef3f07db65a01aa83c9d615958b4eccc6fb89bd22348863e9a46c66e
+  data.tar.gz: '02820503721cdafdbda6b53de96da2d678b13f32b0463c41d59052d2984fb13f614682ab23bb160f148f186ce4ae60f7b6e5f40bc16bd5eaae3f6750d8def6e8'

data/.rubocop.yml

@@ -29,6 +29,13 @@ RSpec/VariableName:
   Exclude:
     - spec/lib/dispatch-rider/publisher/base_spec.rb
 
+Style/CommentedKeyword:
+  Exclude:
+    - 'spec/lib/dispatch-rider/publisher/configuration_reader_spec.rb'
+
+Style/RescueStandardError:
+  EnforcedStyle: implicit
+
 Style/StringLiterals:
   Enabled: false
 
@@ -64,3 +71,17 @@ Metrics/AbcSize:
     conditions.
   Enabled: true
   Max: 22
+
+# We don't want to do this
+Rails/ApplicationRecord:
+  Exclude:
+    - 'lib/dispatch-rider/scheduled_job.rb'
+
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'spec/lib/dispatch-rider/logging/json_formatter_spec.rb'
+    - 'spec/spec_helper.rb'
+
+Style/FormatString:
+  Exclude:
+    - 'lib/dispatch-rider/logging/text_formatter.rb'

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-09-14 23:37:26 UTC using RuboCop version 1.36.0.
+# on 2022-12-01 23:33:43 UTC using RuboCop version 1.39.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -22,34 +22,13 @@ Layout/BlockAlignment:
   Exclude:
     - 'spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/BlockEndNewline:
-  Exclude:
-    - 'spec/factories/messages.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Layout/ClosingParenthesisIndentation:
   Exclude:
     - 'spec/lib/dispatch-rider/publisher_spec.rb'
 
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'lib/dispatch-rider/message.rb'
-    - 'lib/dispatch-rider/queue_services/aws_sqs.rb'
-    - 'lib/dispatch-rider/queue_services/file_system/queue.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/dispatch-rider/queue_services/base.rb'
-
-# Offense count: 45
+# Offense count: 53
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -63,7 +42,7 @@ Layout/ExtraSpacing:
   Exclude:
     - 'spec/factories/messages.rb'
 
-# Offense count: 2
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Width, AllowedPatterns, IgnoredPatterns.
 Layout/IndentationWidth:
@@ -82,7 +61,7 @@ Layout/LeadingCommentSpace:
     - 'lib/dispatch-rider/queue_services/received_message.rb'
     - 'spec/lib/dispatch-rider/configuration_spec.rb'
 
-# Offense count: 2
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
@@ -91,12 +70,6 @@ Layout/MultilineMethodCallBraceLayout:
     - 'spec/lib/dispatch-rider/logging/lifecycle_logger_spec.rb'
     - 'spec/lib/dispatch-rider/publisher_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceAfterColon:
-  Exclude:
-    - 'spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Layout/SpaceAfterComma:
@@ -119,15 +92,6 @@ Layout/SpaceAroundOperators:
   Exclude:
     - 'spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'lib/dispatch-rider/queue_services/file_system/queue.rb'
-
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -147,7 +111,7 @@ Layout/SpaceInsideBlockBraces:
   Exclude:
     - 'lib/dispatch-rider/subscriber.rb'
 
-# Offense count: 41
+# Offense count: 43
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -177,22 +141,6 @@ Layout/TrailingEmptyLines:
   Exclude:
     - 'spec/lib/dispatch-rider/notification_services/file_system/notifier_spec.rb'
 
-# Offense count: 15
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/dispatch-rider/handlers/base.rb'
-    - 'lib/dispatch-rider/queue_services/base.rb'
-    - 'lib/dispatch-rider/queue_services/file_system.rb'
-    - 'lib/dispatch-rider/queue_services/file_system/fs_received_message.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'Rakefile'
-
 # Offense count: 13
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: enums
@@ -205,20 +153,13 @@ Lint/ConstantDefinitionInBlock:
     - 'spec/lib/dispatch-rider/publisher/base_spec.rb'
     - 'spec/lib/dispatch-rider/registrars/handler_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
 Lint/EmptyBlock:
   Exclude:
     - 'spec/lib/dispatch-rider/notification_services_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services_spec.rb'
     - 'spec/lib/dispatch-rider/registrars_spec.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/NonDeterministicRequireOrder:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Lint/RedundantStringCoercion:
@@ -241,26 +182,6 @@ Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/dispatch-rider/command.rb'
 
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/dispatch-rider/error_handlers.rb'
-    - 'lib/dispatch-rider/queue_services/simple.rb'
-    - 'lib/dispatch-rider/registrars/file_system_channel.rb'
-    - 'lib/dispatch-rider/registrars/handler.rb'
-    - 'lib/dispatch-rider/registrars/publishing_destination.rb'
-    - 'lib/dispatch-rider/registrars/sns_channel.rb'
-    - 'spec/lib/dispatch-rider/subscriber_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/dispatch-rider/scheduled_job.rb'
-
 # Offense count: 1
 # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/CyclomaticComplexity:
@@ -285,13 +206,6 @@ Naming/RescuedExceptionsVariableName:
     - 'lib/dispatch-rider/demultiplexer.rb'
     - 'lib/dispatch-rider/logging/lifecycle_logger.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/dispatch-rider/command.rb'
-    - 'lib/dispatch-rider/queue_services/base.rb'
-
 # Offense count: 10
 RSpec/AnyInstance:
   Exclude:
@@ -311,21 +225,6 @@ RSpec/ContextWording:
     - 'spec/lib/dispatch-rider/publisher/base_spec.rb'
     - 'spec/lib/dispatch-rider/publisher/configuration/notification_service_spec.rb'
 
-# Offense count: 13
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/lib/dispatch-rider/demultiplexer_spec.rb'
-    - 'spec/lib/dispatch-rider/logging/lifecycle_logger_spec.rb'
-    - 'spec/lib/dispatch-rider/message_spec.rb'
-    - 'spec/lib/dispatch-rider/notification_services/base_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/base_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/file_system_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/simple_spec.rb'
-
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/EmptyExampleGroup:
@@ -340,14 +239,6 @@ RSpec/EmptyLineAfterExample:
   Exclude:
     - 'spec/lib/dispatch-rider/demultiplexer_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterHook:
-  Exclude:
-    - 'spec/lib/dispatch-rider/dispatcher_spec.rb'
-    - 'spec/lib/dispatch-rider/subscriber_spec.rb'
-
 # Offense count: 14
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/EmptyLineAfterSubject:
@@ -356,14 +247,15 @@ RSpec/EmptyLineAfterSubject:
     - 'spec/lib/dispatch-rider/publisher/configuration/destination_spec.rb'
     - 'spec/lib/dispatch-rider/publisher/configuration/notification_service_spec.rb'
 
-# Offense count: 19
+# Offense count: 21
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 31
 
-# Offense count: 66
+# Offense count: 65
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords.
+# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
+# DisallowedExamples: works
 RSpec/ExampleWording:
   Exclude:
     - 'spec/lib/dispatch-rider/demultiplexer_spec.rb'
@@ -374,40 +266,19 @@ RSpec/ExampleWording:
     - 'spec/lib/dispatch-rider/queue_services/base_spec.rb'
     - 'spec/lib/dispatch-rider/queue_services/file_system_spec.rb'
     - 'spec/lib/dispatch-rider/queue_services/simple_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services_spec.rb'
     - 'spec/lib/dispatch-rider/registrars/base_spec.rb'
     - 'spec/lib/dispatch-rider/subscriber_spec.rb'
 
-# Offense count: 45
+# Offense count: 44
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Enabled: false
 
-# Offense count: 30
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  Exclude:
-    - 'spec/lib/dispatch-rider/configuration_spec.rb'
-    - 'spec/lib/dispatch-rider/dispatcher_spec.rb'
-    - 'spec/lib/dispatch-rider/notification_services/base_spec.rb'
-    - 'spec/lib/dispatch-rider/publisher/configuration_spec.rb'
-    - 'spec/lib/dispatch-rider/publisher/configuration_support_spec.rb'
-    - 'spec/lib/dispatch-rider/publisher_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/base_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/file_system_spec.rb'
-    - 'spec/lib/dispatch-rider/queue_services/simple_spec.rb'
-    - 'spec/lib/dispatch-rider/registrars/base_spec.rb'
-    - 'spec/lib/dispatch-rider/runner_spec.rb'
-    - 'spec/lib/dispatch-rider/subscriber_spec.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_line_only, single_statement_only, disallow
+# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
 RSpec/ImplicitSubject:
   Exclude:
     - 'spec/lib/dispatch-rider/scheduled_job_spec.rb'
@@ -422,13 +293,13 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/lib/dispatch-rider/publisher/base_spec.rb'
     - 'spec/lib/dispatch-rider/registrars/handler_spec.rb'
 
-# Offense count: 62
+# Offense count: 65
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 50
+# Offense count: 51
 RSpec/MultipleExpectations:
   Max: 6
 
@@ -438,7 +309,8 @@ RSpec/MultipleMemoizedHelpers:
   Max: 12
 
 # Offense count: 173
-# Configuration parameters: IgnoreSharedExamples.
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
@@ -457,13 +329,6 @@ RSpec/NotToNot:
     - 'spec/lib/dispatch-rider/publisher/configuration_reader_spec.rb'
     - 'spec/lib/dispatch-rider/scheduled_job_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ReceiveCounts:
-  Exclude:
-    - 'spec/lib/dispatch-rider/demultiplexer_spec.rb'
-    - 'spec/lib/dispatch-rider/publisher/configuration_reader_spec.rb'
-
 # Offense count: 2
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
@@ -510,21 +375,6 @@ RSpec/VerifiedDoubles:
     - 'spec/lib/dispatch-rider/runner_spec.rb'
     - 'spec/lib/dispatch-rider/subscriber_spec.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Rails/ApplicationRecord:
-  Exclude:
-    - 'lib/dispatch-rider/scheduled_job.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforceForPrefixed.
-Rails/Delegate:
-  Exclude:
-    - 'lib/dispatch-rider/queue_services/file_system.rb'
-    - 'lib/dispatch-rider/queue_services/file_system/queue.rb'
-    - 'lib/dispatch-rider/queue_services/simple.rb'
-
 # Offense count: 2
 # Configuration parameters: Include.
 # Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
@@ -580,15 +430,6 @@ Security/JSONLoad:
     - 'spec/integration/logging_spec.rb'
     - 'spec/lib/dispatch-rider/publisher_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: prefer_alias, prefer_alias_method
-Style/Alias:
-  Exclude:
-    - 'lib/dispatch-rider.rb'
-    - 'lib/dispatch-rider/publisher/configuration_support.rb'
-
 # Offense count: 7
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
@@ -608,23 +449,11 @@ Style/ClassVars:
   Exclude:
     - 'lib/dispatch-rider/publisher/base.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/CommentedKeyword:
-  Exclude:
-    - 'spec/lib/dispatch-rider/publisher/configuration_reader_spec.rb'
-
 # Offense count: 63
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/EachWithObject:
-  Exclude:
-    - 'lib/dispatch-rider/publisher.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -648,36 +477,9 @@ Style/ExpandPathArguments:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-Style/FileWrite:
-  Exclude:
-    - 'lib/dispatch-rider/queue_services/file_system/queue.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: format, sprintf, percent
-Style/FormatString:
-  Exclude:
-    - 'lib/dispatch-rider/logging/text_formatter.rb'
-
-# Offense count: 123
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/GlobalStdStream:
-  Exclude:
-    - 'lib/dispatch-rider/configuration.rb'
-
-# Offense count: 2
 # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Exclude:
-    - 'lib/dispatch-rider/queue_services/aws_sqs/sqs_received_message.rb'
     - 'lib/dispatch-rider/queue_services/base.rb'
 
 # Offense count: 2
@@ -709,12 +511,6 @@ Style/HashSyntax:
     - 'spec/lib/dispatch-rider/queue_services/file_system_spec.rb'
     - 'spec/lib/dispatch-rider/registrars/publishing_destination_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/dispatch-rider/queue_services/aws_sqs/sqs_received_message.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -723,21 +519,12 @@ Style/Lambda:
   Exclude:
     - 'spec/lib/dispatch-rider/logging/lifecycle_logger_spec.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/dispatch-rider/version.rb'
-
-# Offense count: 3
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
 Style/NestedParenthesizedCalls:
   Exclude:
-    - 'lib/dispatch-rider/publisher.rb'
     - 'spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb'
     - 'spec/lib/dispatch-rider/notification_services/base_spec.rb'
 
@@ -771,14 +558,6 @@ Style/OpenStructUse:
     - 'spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb'
     - 'spec/lib/dispatch-rider/queue_services/base_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'spec/lib/dispatch-rider/logging/json_formatter_spec.rb'
-    - 'spec/spec_helper.rb'
-
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
@@ -788,35 +567,6 @@ Style/PreferredHashMethods:
     - 'lib/dispatch-rider/publisher.rb'
     - 'lib/dispatch-rider/queue_services/aws_sqs/message_body_extractor.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: .
-# SupportedStyles: same_as_string_literals, single_quotes, double_quotes
-Style/QuotedSymbols:
-  EnforcedStyle: double_quotes
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantBegin:
-  Exclude:
-    - 'lib/dispatch-rider/callbacks/storage.rb'
-    - 'lib/dispatch-rider/demultiplexer.rb'
-    - 'lib/dispatch-rider/queue_services/file_system.rb'
-    - 'lib/dispatch-rider/registrars/base.rb'
-    - 'spec/lib/dispatch-rider/dispatcher_spec.rb'
-    - 'spec/lib/dispatch-rider/publisher_spec.rb'
-
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/dispatch-rider/handlers/base.rb'
-    - 'lib/dispatch-rider/notification_services/aws_sns.rb'
-    - 'lib/dispatch-rider/notification_services/file_system.rb'
-    - 'lib/dispatch-rider/publisher/configuration/destination.rb'
-    - 'lib/dispatch-rider/publisher/configuration/notification_service.rb'
-    - 'lib/dispatch-rider/queue_services/received_message.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -825,15 +575,6 @@ Style/RegexpLiteral:
   Exclude:
     - 'spec/lib/dispatch-rider/configuration_spec.rb'
 
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'lib/dispatch-rider/demultiplexer.rb'
-    - 'lib/dispatch-rider/logging/lifecycle_logger.rb'
-
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: RequireEnglish.
@@ -852,30 +593,6 @@ Style/StringConcatenation:
     - 'lib/generators/dispatch_rider/job/dispatch_job_generator.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, IgnoredMethods, AllowComments.
-# AllowedMethods: respond_to, define_method
-Style/SymbolProc:
-  Exclude:
-    - 'spec/lib/dispatch-rider/queue_services/base_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'lib/dispatch-rider/integrations/appsignal.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArrayLiteral:
-  Exclude:
-    - 'spec/lib/dispatch-rider/airbrake_error_handler_spec.rb'
-
 # Offense count: 37
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.

data/Rakefile

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require 'rubygems'
 
@@ -7,7 +8,7 @@ begin
 rescue LoadError => e
   warn e.message
   warn "Run `gem install bundler` to install Bundler."
-  exit -1
+  exit(-1)
 end
 
 begin

data/dispatch-rider.gemspec

@@ -44,14 +44,14 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'activesupport', '>= 5.2.0'
   gem.add_runtime_dependency 'activemodel', '>= 5.2.0'
   gem.add_runtime_dependency 'activerecord', '>= 5.2.0'
+  gem.add_runtime_dependency 'aws-sdk-sqs', '~> 1.30'
+  gem.add_runtime_dependency 'aws-sdk-sns', '~> 1.30'
   gem.add_runtime_dependency 'daemons', '~> 1.2'
   gem.add_runtime_dependency 'retriable', '~> 3.1', '>= 3.1.2'
   # appsignal is an optional runtime dependency,
   # I am marking it as development for those that don't need it
   gem.add_development_dependency 'appsignal', '~> 1.0'
 
-  gem.add_development_dependency 'aws-sdk-sqs', '~> 1.30'
-  gem.add_development_dependency 'aws-sdk-sns', '~> 1.30'
   gem.add_development_dependency 'bundler', '< 3.0'
   gem.add_development_dependency 'coveralls_reborn', '~> 0.25'
   gem.add_development_dependency 'simplecov-lcov'

data/lib/dispatch-rider/callbacks/access.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DispatchRider
   module Callbacks
     # Provides access for invoking callbacks.

data/lib/dispatch-rider/callbacks/storage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DispatchRider
   module Callbacks
     # Storage for callbacks.
@@ -21,11 +23,11 @@ module DispatchRider
       # @param [Proc] &block
       def after(event, block_param = nil, &block)
         around(event) do |job, *args|
-          begin
-            job.call
-          ensure
-            (block_param || block).call(*args)
-          end
+
+          job.call
+        ensure
+          (block_param || block).call(*args)
+
         end
       end
 

data/lib/dispatch-rider/callbacks/support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DispatchRider
   module Callbacks
     # Adds callback support to an object.

data/lib/dispatch-rider/callbacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DispatchRider
   module Callbacks
   end

data/lib/dispatch-rider/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'daemons'
 require 'pathname'
 require 'optparse'
@@ -23,9 +25,7 @@ module DispatchRider
       process_name = "dispatch_rider.#{@options[:identifier]}"
       Daemons.run_proc(process_name, @options) do
         $0 = File.join(@options[:prefix], process_name) if @options[:prefix]
-        Dir.chdir(@app_home.to_s) do
-          block.call
-        end
+        Dir.chdir(@app_home.to_s, &block)
       end
     end