discountnetwork 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e174ad9cc85380841cbecb16cfbaa6ae642580d3
-  data.tar.gz: 79bffd2a17871d804db24b82d3789c589ddef1e8
+  metadata.gz: 67769839fd2e1a2bc644ac1ee14347e49245a3e4
+  data.tar.gz: 2e518bbccb41f513fcb6882fa44336979831c9b1
 SHA512:
-  metadata.gz: 97d36b9148cbe85f6aeeeb389f172364ea26e8590ee2588a37e726c6e70299fc419b6112d302eb25ce2d9ffb3cfde0a8ba43be0a6557bfc28cfe2d861c72cdf1
-  data.tar.gz: 9b5a025a235808c2df27d6038a95eac95ac93d7d2b81ed52f45d969045b56fb8caf918290c50a4f1183f8808c0f327ed697ace32ce82e44786b1ce5dfc619fa3
+  metadata.gz: 491ab04c003a4c12241b31f9b432318bfa36d4302371b5179abc5ec3ce112ae0037042de6bae647f064a1ff749f69569a2fed28858f995974800790d6ba6efe2
+  data.tar.gz: a1c76ef3c1468ccfc487e0369e006a5170b4263f4df255e50f6ec59cbcf1305c08dafd2c9ed905e48978984fffbf283245380aaea01f52544ba2e143fdb756bd

data/.rubocop.yml

@@ -2,7 +2,7 @@ AllCops:
   Exclude:
     - db/schema.rb
 
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
   Enabled: false
 
@@ -21,7 +21,7 @@ Style/AsciiComments:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#english-comments'
   Enabled: false
 
-Style/AsciiIdentifiers:
+Naming/AsciiIdentifiers:
   Description: 'Use only ascii symbols in identifiers.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#english-identifiers'
   Enabled: false
@@ -90,6 +90,13 @@ Metrics/AbcSize:
                  branches, and conditions.
   Enabled: false
 
+Metrics/BlockLength:
+  CountComments: true  # count full line comments?
+  Max: 25
+  ExcludedMethods: []
+  Exclude:
+    - "spec/**/*"
+
 Metrics/CyclomaticComplexity:
   Description: >-
                  A complexity metric that is strongly correlated to the number
@@ -100,20 +107,15 @@ Rails/Delegate:
   Description: 'Prefer delegate method for delegations.'
   Enabled: false
 
-Style/DeprecatedHashMethods:
-  Description: 'Checks for use of deprecated Hash methods.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#hash-key'
+Style/PreferredHashMethods:
+  Description: 'Checks use of `has_key?` and `has_value?` Hash methods.'
+  StyleGuide: '#hash-key'
   Enabled: false
 
 Style/Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: false
 
-Style/DotPosition:
-  Description: 'Checks the position of the dot in multi-line method calls.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains'
-  EnforcedStyle: trailing
-
 Style/DoubleNegation:
   Description: 'Checks for uses of double negation (!!).'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-bang-bang'
@@ -139,15 +141,17 @@ Style/EvenOdd:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
   Enabled: false
 
-Style/ExtraSpacing:
-  Description: 'Do not use unnecessary spacing.'
-  Enabled: true
-
-Style/FileName:
+Naming/FileName:
   Description: 'Use snake_case for source file names.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-files'
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Description: >-
+    Add the frozen_string_literal comment to the top of files
+    to help transition from Ruby 2.3.0 to Ruby 3.0.
+  Enabled: false
+
 Style/FlipFlop:
   Description: 'Checks for flip flops'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-flip-flops'
@@ -216,25 +220,11 @@ Style/ModuleFunction:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#module-function'
   Enabled: false
 
-Style/MultilineOperationIndentation:
-  Description: >-
-                 Checks indentation of binary operations that span more than
-                 one line.
-  Enabled: true
-  EnforcedStyle: indented
-
 Style/MultilineBlockChain:
   Description: 'Avoid multi-line chains of blocks.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'
   Enabled: false
 
-Style/MultilineMethodCallIndentation:
-  Description: >-
-                 Checks indentation of method calls with the dot operator
-                 that span more than one line.
-  Enabled: true
-  EnforcedStyle: indented
-
 Style/NegatedIf:
   Description: >-
                  Favor unless over if for negative conditions
@@ -276,7 +266,7 @@ Style/OneLineConditional:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#ternary-operator'
   Enabled: false
 
-Style/OpMethod:
+Naming/BinaryOperatorParameterName:
   Description: 'When defining binary operators, name the argument other.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#other-arg'
   Enabled: false
@@ -296,7 +286,7 @@ Style/PerlBackrefs:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers'
   Enabled: false
 
-Style/PredicateName:
+Naming/PredicateName:
   Description: 'Check the names of predicate methods.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark'
   NamePrefixBlacklist:
@@ -352,24 +342,31 @@ Style/StringLiterals:
   EnforcedStyle: double_quotes
   Enabled: true
 
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 Style/TrailingCommaInArguments:
   Description: 'Checks for trailing comma in argument lists.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   EnforcedStyleForMultiline: comma
-  SupportedStyles:
+  SupportedStylesForMultiline:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  EnforcedStyleForMultiline: comma
+  SupportedStylesForMultiline:
     - comma
     - consistent_comma
     - no_comma
   Enabled: true
 
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   EnforcedStyleForMultiline: comma
-  SupportedStyles:
+  SupportedStylesForMultiline:
     - comma
     - consistent_comma
     - no_comma
@@ -404,6 +401,48 @@ Style/WordArray:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-w'
   Enabled: false
 
+# Layout
+
+Layout/AlignParameters:
+  Description: 'Here we check if the parameters on a multi-line method call or definition are aligned.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-double-indent'
+  Enabled: false
+
+Layout/ConditionPosition:
+  Description: >-
+                 Checks for condition placed in a confusing position relative to
+                 the keyword.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
+  Enabled: false
+
+Layout/DotPosition:
+  Description: 'Checks the position of the dot in multi-line method calls.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains'
+  EnforcedStyle: trailing
+
+Layout/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: true
+
+Layout/MultilineOperationIndentation:
+  Description: >-
+                 Checks indentation of binary operations that span more than
+                 one line.
+  Enabled: true
+  EnforcedStyle: indented
+
+Layout/MultilineMethodCallIndentation:
+  Description: >-
+                 Checks indentation of method calls with the dot operator
+                 that span more than one line.
+  Enabled: true
+  EnforcedStyle: indented
+
+Layout/InitialIndentation:
+  Description: >-
+    Checks the indentation of the first non-blank non-comment line in a file.
+  Enabled: false
+
 # Lint
 
 Lint/AmbiguousOperator:
@@ -428,13 +467,6 @@ Lint/CircularArgumentReference:
   Description: "Don't refer to the keyword argument in the default value."
   Enabled: false
 
-Lint/ConditionPosition:
-  Description: >-
-                 Checks for condition placed in a confusing position relative to
-                 the keyword.
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
-  Enabled: false
-
 Lint/DeprecatedClassMethods:
   Description: 'Check for deprecated class method calls.'
   Enabled: false
@@ -460,18 +492,7 @@ Lint/HandleExceptions:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions'
   Enabled: false
 
-Lint/InvalidCharacterLiteral:
-  Description: >-
-                 Checks for invalid character literals with a non-escaped
-                 whitespace character.
-  Enabled: false
-
-Style/InitialIndentation:
-  Description: >-
-    Checks the indentation of the first non-blank non-comment line in a file.
-  Enabled: false
-
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Description: 'Checks of literals used in conditions.'
   Enabled: false
 
@@ -512,7 +533,7 @@ Lint/UnderscorePrefixedVariableName:
   Description: 'Do not use prefix `_` for a variable that is used.'
   Enabled: false
 
-Lint/UnneededDisable:
+Lint/UnneededCopDisableDirective:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
                  Note: this cop is not disabled when disabling all cops.

data/README.md

@@ -71,6 +71,17 @@ To retrieve the user account details using the Discount Network `account` API
 DiscountNetwork::Account.find(auth_token)
 ```
 
+#### Create a user account
+
+To create a new user account you can use the `Account.create` interface, but one
+important things to remember that account creation is not available for all white
+label, so if it's failing then most likely this feature is not supported on your
+white label.
+
+```ruby
+DiscountNetwork::Account.create(subscriber_attributes)
+```
+
 #### Update user account
 
 Once the user is logged in and `auth_token` has been configured properly then

data/lib/discountnetwork/account.rb

@@ -7,6 +7,10 @@ module DiscountNetwork
       end
     end
 
+    def create(attributes)
+      DiscountNetwork.post_resource("account", subscriber: attributes)
+    end
+
     def update(attributes)
       if auth_token_exists?
         DiscountNetwork.put_resource("account", subscriber: attributes)

data/lib/discountnetwork/testing/discountnetwork_api.rb

@@ -103,6 +103,15 @@ module DiscountNetworkApi
     )
   end
 
+  def stub_account_create_api(attributes)
+    stub_api_response(
+      :post,
+      "account",
+      data: { subscriber: attributes },
+      filename: "user",
+    )
+  end
+
   def stub_activation_find_api(token)
     stub_api_response(
       :get,

data/lib/discountnetwork/version.rb

@@ -1,3 +1,3 @@
 module Discountnetwork
-  VERSION = "0.1.2".freeze
+  VERSION = "0.1.3".freeze
 end

data/spec/discountnetwork/account_spec.rb

@@ -16,6 +16,17 @@ describe DiscountNetwork::Account do
     end
   end
 
+  describe ".create" do
+    it "creates and returns created user" do
+      stub_account_create_api(user_attributes)
+
+      response = DiscountNetwork::Account.create(user_attributes)
+
+      expect(response.user.name).not_to be_nil
+      expect(response.user.status).to eq("Active")
+    end
+  end
+
   describe ".update" do
     it "updates the subscriber account" do
       auth_token = "ABCD_123"
@@ -33,4 +44,23 @@ describe DiscountNetwork::Account do
   def set_account_auth_token(token)
     DiscountNetwork.configuration.auth_token = token
   end
+
+  def user_attributes
+    @user_attributes ||= {
+      first_name: "John",
+      last_name: "Doe",
+      sex: "Male",
+      address: "123 Main Street",
+      city: "New York",
+      zip: "NY123",
+      state: "New York",
+      phone: "+1 123 456 789 0123",
+      mobile: "+1 012 345 678 9012",
+      username: "john.doe",
+      email: "john.doe@example.com",
+      country: "US",
+      password: "secret_password",
+      password_confirmation: "secret_password",
+    }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: discountnetwork
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Abu Nashir
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-12 00:00:00.000000000 Z
+date: 2018-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client