dirty_pipeline 0.8.3 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c994b31257ebb9f48ae2c67ce0d197027f9397ad407944d9f938dabf80dbbe58
-  data.tar.gz: 16684ec82ac970097e7add8f2a80e4d45d929d118d0cd88ef8e3584c3f478df0
+  metadata.gz: 000ac5cab919b0a6781a640b60a54163ce802a3c1c30a84e937a9ea1f8368e01
+  data.tar.gz: e45766b16965674ac64bd3f8c1d494435ca1af9538cc0fb229ac596c845ee28d
 SHA512:
-  metadata.gz: 99ef4a8cc4ce384654c8fc90c1b5bec987955512c942c0c82bac630034e02f8df2ad26ef03f7f7dab961456b24399f6adaa443ccbcf50a0f9a858ea82f5aeb2f
-  data.tar.gz: 8482d89667c2ba8906fe553928c37e969256b1db6be91b25364d7d1f1ab5cf253fc8fc5f6ad15e8ef81afc30ba8b07a839ada7d46056571a21d4b0f1aa29e155
+  metadata.gz: 124a17b8c4b59bbccfc90a7ca7d0bc2c8e6abbad1827db2f875643251e5b34dfbef8a66d39272b89ef775d4b9d2e43981411d8b334f8edb9401087beb4e3b4cb
+  data.tar.gz: 1fa1006ed40dddece9300d713b86d1c1fc934a775e9653615af91162a25dce92b63b9e5ebfce29d0dbfe51370f49bbb2bb415803532526d2282a253867db52cc

data/lib/dirty_pipeline/base.rb

@@ -42,12 +42,16 @@ module DirtyPipeline
       @status = Status.success(subject)
     end
 
-    def find_transition(name)
-      self.class.transitions_map.fetch(name.to_s).tap do |from:, **kwargs|
-        next unless railway.operation.eql?(:call)
-        next if from == Array(storage.status)
-        next if from.include?(storage.status.to_s)
-        raise InvalidTransition, "from `#{storage.status}` by `#{name}`"
+    def find_transition!(event)
+      tname = event.transition
+      event.source = storage.status
+      self.class.transitions_map.fetch(tname.to_s).tap do |from:, **kwargs|
+        next unless railway.operation.eql?("call")
+        next if from == Array(event.source)
+        next if from.include?(event.source.to_s)
+        raise InvalidTransition, "from `#{event.source}` by `#{tname}`"
+      end.tap do |to:, **|
+        event.destination = to if railway.operation.eql?("call")
       end
     end
 
@@ -128,12 +132,14 @@ module DirtyPipeline
     def execute(event, attempt_retry: false)
       attempt_retry ? event.attempt_retry! : event.start!
 
-      # dispatch event?
-      Transaction.new(self, event).call do |destination, action, *args|
+      Transaction.new(self, event).call do |action, *args|
         state_changes = process_action(action, event, *args)
+
         event.assign_changes(state_changes)
+        event.complete if event.start?
+
         next if status.failure?
-        Success(event, destination)
+        Success(event)
       end
       call_next
 
@@ -177,8 +183,7 @@ module DirtyPipeline
       @status = Status.failure(cause, tag: type)
     end
 
-    def Success(event, destination)
-      event.complete(destination)
+    def Success(event)
       @status = Status.success(subject)
     end
   end

data/lib/dirty_pipeline/event.rb

@@ -23,6 +23,15 @@ module DirtyPipeline
       )
     end
 
+    def dup
+      self.class.new(
+        data: data.merge(
+          "uuid" => SecureRandom.uuid,
+          "status" => NEW,
+        )
+      )
+    end
+
     attr_reader :id, :tx_id, :error, :data
     def initialize(options = {}, data: nil,  error: nil)
       unless options.empty?
@@ -54,6 +63,22 @@ module DirtyPipeline
       {data: @data, error: @error}
     end
 
+    def source
+      data["source"]
+    end
+
+    def source=(value)
+      data["source"] = value
+    end
+
+    def destination
+      data["destination"]
+    end
+
+    def destination=(value)
+      data["destination"] = value
+    end
+
     %w(args transition cache destination changes).each do |method_name|
       define_method("#{method_name}") { @data[method_name] }
     end
@@ -90,9 +115,8 @@ module DirtyPipeline
       @data["changes"] = changes
     end
 
-    def complete(destination)
+    def complete
       @data.merge!(
-        "destination" => destination,
         "updated_at" => Time.now.utc.iso8601,
         "status" => SUCCESS,
       )

data/lib/dirty_pipeline/pg/queue.rb

@@ -139,6 +139,8 @@ module DirtyPipeline
           "txid" => event.tx_id,
           "transit" => event.transition,
           "args" => event.args,
+          "source" => event.source,
+          "destination" => event.destination
         )
       end
 
@@ -151,6 +153,8 @@ module DirtyPipeline
             "transaction_uuid" => unpacked_event["txid"],
             "transition" => unpacked_event["transit"],
             "args" => unpacked_event["args"],
+            "source" => unpacked_event["source"],
+            "destination" => unpacked_event["destination"]
           }
         )
       end

data/lib/dirty_pipeline/pg/railway.rb

@@ -1,7 +1,7 @@
 module DirtyPipeline
   module PG
     class Railway
-      DEFAULT_OPERATIONS = %w(call undo finalize)
+      DEFAULT_OPERATIONS = %w(call undo finalize finalize_undo)
 
       def self.create!(connection)
         connection.exec <<~SQL

data/lib/dirty_pipeline/pg/storage.rb

@@ -59,7 +59,7 @@ module DirtyPipeline
         DO UPDATE SET data = EXCLUDED.data, error = EXCLUDED.error;
       SQL
       def commit!(event)
-        store["status"] = event.destination  if event.destination
+        store["status"] = event.destination  if event.success?
         store["state"].merge!(event.changes) unless event.changes.to_h.empty?
         data, error = {}, {}
         data = event.data.to_h if event.data.respond_to?(:to_h)

data/lib/dirty_pipeline/redis/queue.rb

@@ -52,6 +52,8 @@ module DirtyPipeline
           "txid" => event.tx_id,
           "transit" => event.transition,
           "args" => event.args,
+          "source" => event.source,
+          "destination" => event.destination,
         )
       end
 
@@ -64,6 +66,8 @@ module DirtyPipeline
             "transaction_uuid" => unpacked_event["txid"],
             "transition" => unpacked_event["transit"],
             "args" => unpacked_event["args"],
+            "source" => unpacked_event["source"],
+            "destination" => unpacked_event["destination"]
           }
         )
       end

data/lib/dirty_pipeline/redis/storage.rb

@@ -48,7 +48,7 @@ module DirtyPipeline
       end
 
       def commit!(event)
-        store["status"] = event.destination     if event.destination
+        store["status"] = event.destination     if event.success?
         store["state"].merge!(event.changes)    unless event.changes.to_h.empty?
 
         error = {}

data/lib/dirty_pipeline/transaction.rb

@@ -12,16 +12,15 @@ module DirtyPipeline
       pipeline.schedule_cleanup
 
       # Split attempts config and event dispatching
-      destination, action, max_attempts_count =
-        pipeline.find_transition(event.transition)
-                .values_at(:to, :action, :attempts)
+      action, max_attempts_count =
+        pipeline.find_transition!(event).values_at(:action, :attempts)
 
       storage.commit!(event)
 
       # FIXME: make configurable, now - hardcoded to AR API
       # subject.transaction(requires_new: true) do
       subject.transaction do
-        with_abort_handling { yield(destination, action, *event.args) }
+        with_abort_handling { yield(action, *event.args) }
       end
     rescue => exception
       event.link_exception(exception)

data/lib/dirty_pipeline/transition.rb

@@ -1,4 +1,6 @@
 module DirtyPipeline
+  class Rollback < StandardError; end
+
   class Transition
     def Failure(error)
       railway&.switch_to(:undo)
@@ -7,6 +9,10 @@ module DirtyPipeline
 
     def Success(changes = nil)
       case railway&.active
+      when "finalize_undo"
+        railway&.switch_to(:undo)
+      when "undo"
+        railway&.switch_to(:finalize_undo) if respond_to?(:finalize_undo)
       when "call"
         railway&.switch_to(:finalize) if respond_to?(:finalize)
       when "finalize"
@@ -15,6 +21,13 @@ module DirtyPipeline
       throw :success, changes.to_h
     end
 
+    def self.finalize_undo(*args, **kwargs)
+      event, pipeline, *args = args
+      instance = new(event, pipeline.railway, *args, **kwargs)
+      return unless instance.respond_to?(:finalize_undo)
+      instance.finalize_undo(pipeline.subject)
+    end
+
     def self.finalize(*args, **kwargs)
       event, pipeline, *args = args
       instance = new(event, pipeline.railway, *args, **kwargs)
@@ -25,6 +38,7 @@ module DirtyPipeline
     def self.undo(*args, **kwargs)
       event, pipeline, *args = args
       instance = new(event, pipeline.railway, *args, **kwargs)
+      pipeline&.railway&.send(:[], :finalize_undo)&.send(:<<, event)
       return unless instance.respond_to?(:undo)
       instance.undo(pipeline.subject)
     end
@@ -32,11 +46,18 @@ module DirtyPipeline
     def self.call(*args, **kwargs)
       event, pipeline, *args = args
       instance = new(event, pipeline.railway, *args, **kwargs)
-      pipeline&.railway&.send(:[], :undo)&.send(:<<, event)
       pipeline&.railway&.send(:[], :finalize)&.send(:<<, event)
+      prepare_undo(pipeline, event)
       instance.call(pipeline.subject)
     end
 
+    def self.prepare_undo(pipeline, event)
+      anti_event = event.dup
+      anti_event.source, anti_event.destination =
+        event.destination, event.source
+      pipeline&.railway&.send(:[], :undo)&.send(:unshift, anti_event)
+    end
+
     attr_reader :event, :railway
     def initialize(event, railway, *, **)
       @event = event

data/lib/dirty_pipeline/version.rb

@@ -1,3 +1,3 @@
 module DirtyPipeline
-  VERSION = "0.8.3"
+  VERSION = "0.9.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dirty_pipeline
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.9.0
 platform: ruby
 authors:
 - Sergey Dolganov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-09 00:00:00.000000000 Z
+date: 2019-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq