dirty_pipeline 0.6.4 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39b6905344a3e533c084d66709bc992996351b5ca52b1a49bd995ab5159ea7eb
-  data.tar.gz: 19176034e183e583454c99ddb72309ef1ee7b7e2db05de9d9affadae5d652dfe
+  metadata.gz: 1d44cfaa1fb0918cbce5275f04811600f667e9bcc539958cfd65e286f2dddb59
+  data.tar.gz: e0effe290c5f599d0f3cf692060768f0407a73e8c51f697be216fb2ada6d1df6
 SHA512:
-  metadata.gz: 7e4ed6d5dbfc6f015ad05065a2e571481f979d7d70265da262a8a7d8a650a09a6e6c8d99671fdd3f07ab320442022075d90db51c148f1b5d1e9fd172047a8fba
-  data.tar.gz: d1e2a3f6a925add414c6935448986c272d618a2d5f9783016406385d30d3e566b455ea5c66d054df16900b23bfe9f0c567a2fe758884c64aadb2d3eb42bf4ed2
+  metadata.gz: 9b44e2e14d5f1fd3b1b56ea9f6b567d585be488144d1beaf7aa38a47fa9fdb2ac986aef90c0a3f902ccfeacc069937ecec6b0f30b3866c9ef3aaa2760223dc6a
+  data.tar.gz: 3f7e985850e7cf8404c33d3855b314486ced5c64a28f7cb7cc3b97327fb616d85769cd854d3a2e98c4db615afb3c54b08492c338f8472a3148272b72794daf78

data/lib/dirty_pipeline/base.rb

@@ -22,8 +22,8 @@ module DirtyPipeline
       using StringCamelcase
 
       def transition(name, from:, to:, action: nil, attempts: 1)
-        action ||= const_get(name.to_s.camelcase(:upper)) rescue nil
         action ||= method(name) if respond_to?(name)
+        action ||= const_get(name.to_s.camelcase(:upper))
         @transitions_map[name.to_s] = {
           action: action,
           from: Array(from).map(&:to_s),
@@ -61,12 +61,13 @@ module DirtyPipeline
     end
 
     # FIXME operation :call - argument
-    def chain(*args)
-      railway[:call] << Event.create(*args, tx_id: @uuid)
+    def chain(*args, operation: :call)
+      railway[operation] << Event.create(*args, tx_id: @uuid)
       self
     end
 
     def call
+      # HANDLE ANOTHER ACTION IN PROGRESS EXPLICITLY
       return self if (enqueued_event = railway.next).nil?
       execute(load_event(enqueued_event))
     end
@@ -106,6 +107,11 @@ module DirtyPipeline
     def retry_delay; self.class.retry_delay || DEFAULT_RETRY_DELAY; end
     def schedule_retry; schedule("retry",   retry_delay); end
 
+    def when_skipped
+      yield(nil, self) if railway.other_transaction_in_progress?
+      self
+    end
+
     def when_success
       yield(status.data, self) if status.success?
       self
@@ -118,10 +124,10 @@ module DirtyPipeline
 
     private
 
-
     def execute(event, attempt_retry: false)
       attempt_retry ? event.attempt_retry! : event.start!
 
+      # dispatch event?
       Transaction.new(self, event).call do |destination, action, *args|
         state_changes = process_action(action, event, *args)
         next if status.failure?
@@ -137,7 +143,7 @@ module DirtyPipeline
     end
 
     def process_action(action, event, *args)
-      return catch(:success) do
+      catch(:success) do
         return if interupt_on_error(event) do
           throw :success, run_operation(action, event, *args)
         end
@@ -149,6 +155,7 @@ module DirtyPipeline
     end
 
     def run_operation(action, event, *args)
+      raise ArgumentError unless action
       return unless action.respond_to?(operation = railway.active)
       action.public_send(operation, event, self, *args)
     end

data/lib/dirty_pipeline/railway.rb

@@ -53,6 +53,11 @@ module DirtyPipeline
       DirtyPipeline.with_redis { |r| r.get(active_transaction_key) }
     end
 
+    def other_transaction_in_progress?
+      return false if running_transaction.nil?
+      running_transaction != @tx_id
+    end
+
     private
 
     def create_queue(operation_name)
@@ -75,10 +80,5 @@ module DirtyPipeline
     def finish_transaction!
       clear! if running_transaction == @tx_id
     end
-
-    def other_transaction_in_progress?
-      return false if running_transaction.nil?
-      running_transaction != @tx_id
-    end
   end
 end

data/lib/dirty_pipeline/storage.rb

@@ -47,10 +47,10 @@ module DirtyPipeline
     end
 
     def commit!(event)
-      store["status"] = event.destination if event.destination
-      store["state"].merge!(event.changes) unless event.changes.to_h.empty?
+      store["status"] = event.destination     if event.destination
+      store["state"].merge!(event.changes)    unless event.changes.to_h.empty?
       store["errors"][event.id] = event.error unless event.error.to_h.empty?
-      store["events"][event.id] = event.data unless event.data.to_h.empty?
+      store["events"][event.id] = event.data  unless event.data.to_h.empty?
       save!
     end
 

data/lib/dirty_pipeline/transaction.rb

@@ -11,6 +11,7 @@ module DirtyPipeline
     def call
       pipeline.schedule_cleanup
 
+      # Split attempts config and event dispatching
       destination, action, max_attempts_count =
         pipeline.find_transition(event.transition)
                 .values_at(:to, :action, :attempts)

data/lib/dirty_pipeline/transition.rb

@@ -14,6 +14,7 @@ module DirtyPipeline
       end
       throw :success, changes.to_h
     end
+
     def self.finalize(*args, **kwargs)
       event, pipeline, *args = args
       instance = new(event, pipeline.railway, *args, **kwargs)

data/lib/dirty_pipeline/version.rb

@@ -1,3 +1,3 @@
 module DirtyPipeline
-  VERSION = "0.6.4"
+  VERSION = "0.7.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dirty_pipeline
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.7.0
 platform: ruby
 authors:
 - Sergey Dolganov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-17 00:00:00.000000000 Z
+date: 2018-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq