dirty_associations 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 046bdd6028e751c1eb05042bd2e592bb56e6ea7d
-  data.tar.gz: 9a2d0d5a75467af5355f464e79823192adb4bd61
+  metadata.gz: 235e57664229317e7d94b3103ab45193a46d7c83
+  data.tar.gz: 6091ecd6c71b13a533e319e586f4a675d095220c
 SHA512:
-  metadata.gz: e2ff66d8d3b18a90dc006bf8c8e3b8cf6ef3db0966f426800dc4fb265c4c42c2805945063c6884c0fe2b4033e47c6dc3cd2cde66981c7105bcec11b59ae0ddc7
-  data.tar.gz: 4f247e7bc2c217d9c9342025de69662b49d5c07197a023f29bbe77cdb242505a58e5a74af8b80516c60081acb11453548484fb45d51c68de7e9d658a4fccaf9d
+  metadata.gz: 6f08073907f7c908c66ef1e4fc355970998181e428f92891dd2f559fc5fd21ddb83e038fe3e3ab822a3adadddd8ed2ae841cee22d5170de7b08cf3df26171dfc
+  data.tar.gz: f775303a0bfcee934d66b90c569470db022b79ef10a8612b3664b5d421fc95b320de1e96065806cc8fef04ef64fc38f384c438e7c38430c4881162e4c4d996bb

data/lib/dirty_associations.rb

@@ -26,7 +26,7 @@ module DirtyAssociations
       end
 
       define_method "#{association}_attributes=" do |value|
-        attribute_will_change!(association.to_s)
+        attribute_will_change!(association.to_s) if _nested_attributes_will_change?(value)
         super(value)
       end
 
@@ -56,4 +56,13 @@ module DirtyAssociations
     value = Array(value).reject &:blank?
     send(ids) != value
   end
+
+  def _nested_attributes_will_change?(attributes_collection)
+    return false unless attributes_collection.is_a?(Array) || attributes_collection.is_a?(Hash)
+    attributes_collection = attributes_collection.values if attributes_collection.is_a? Hash
+
+    # Only consider additions to be a change, i.e. attributes hashes with no id. Editing or destroying a
+    # nested model can be detected by belongs_to :touch => true on the nested model class.
+    attributes_collection.any? { |a| a[:id].blank? && a["id"].blank?}
+  end
 end

data/lib/dirty_associations/version.rb

@@ -1,3 +1,3 @@
 module DirtyAssociations
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end

data/test/dirty_associations_test.rb

@@ -53,6 +53,11 @@ class DirtyAssociationsTest < ActiveSupport::TestCase
     assert bar.foos_changed?
   end
 
+  test "editing has_many assocation attributes does not count as a change" do
+    bar.assign_attributes(:foos_attributes => [{ :id => bar.foos.first.id }])
+    refute bar.foos_changed?
+  end
+
   test "changes reset by save" do
     bar.foos = [ FactoryGirl.create(:foo) ]
     assert bar.foos_changed?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dirty_associations
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Jen Page
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails