direct_sms 0.0.3 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 48444dde721065342314bd1c75df0e7fa9c05be3
-  data.tar.gz: e3e216b10101be0217e6243a2c751e0a3ded3bec
+  metadata.gz: b0ea31d2818eaeb0b5e8952f94bb8033652efedd
+  data.tar.gz: 0cef2c4ab40c89b95a3c05601b7efc88de120ea2
 SHA512:
-  metadata.gz: 0d797e9a70867444ba43e4b48380450eb33913c906b48935ce1ae871a57945c313479d33df78c4fcaf495f7468f7702befbb426db22e891f2ab24b99f8a1b245
-  data.tar.gz: 066ddda4b80b359cd01eaf76cf8bf4f16769924741a828ef368ecae3c8a72b9c619aad01dd373c5b833e30021d840d94282c962bf4f65c97072516b3091231eb
+  metadata.gz: a3344e3970028d28fbf1abc6bc2fbcb47eadcc0a41ceb064f462f9e2c809b5e236f4d26615235946945dafbec1029e7add9e1ed4f1d20739fe6ba876d88d0fbd
+  data.tar.gz: 50c69ab7b7d3bf8fcef175cd2b016be783b3eda8d9844ba3b74f2c48ac614b58785d5b6eb42b1f2ed29dd8dbf12f8566e68d02247186536e4bece50c8769d0f6

data/bin/direct_sms

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 require 'direct_sms'
 
-sms = DirectSms::Message.new("username", "password", max_segments: 10, type: "2-way")
-sms.to = "+639178574111, +639193963389"
+sms = DirectSms::Message.new(max_segments: 10, type: "2-way")
+sms.to = "+639178574111"
 
-puts sms.balance
+puts sms.credit_balance

data/lib/direct_sms.rb

@@ -1,42 +1,15 @@
 require "direct_sms/version"
-require "httparty"
+require "direct_sms/configuration"
+require "direct_sms/message"
 
 module DirectSms
-  class Message
-    include HTTParty
 
-    base_uri "api.directsms.com.au"
-    attr_accessor :message, :to, :max_segments, :type, :message_id
-    attr_accessor :username, :password
-
-    def initialize(attrs = {})
-      attrs.each { |k, v| self.send("#{k}=", v) }
-    end
-    
-    def credit_balance
-      options = { query: fetch_credentials }
-      response = self.class.get("/s3/http/get_balance", options) # returns credit: 50.0
-      response = response.split(" ").last
-
-      response
-    end
-
-    def send_message
-      options = {
-        query: fetch_credentials.merge(message: message,
-                              to: to,
-                              max_segments: max_segments, 
-                              type: type,
-                              messageid: message_id)
-      }
-
-      self.class.get("/s3/http/send_message", options)
-    end
-
-    private
+  def self.configuration
+    @configuration ||= Configuration.new
+  end
 
-    def fetch_credentials
-      { username: username, password: password }
-    end
+  def self.configure
+    yield configuration
   end
+
 end

data/lib/direct_sms/configuration.rb

@@ -0,0 +1,5 @@
+module DirectSms
+  class Configuration
+    attr_accessor :username, :password
+  end
+end

data/lib/direct_sms/message.rb

@@ -0,0 +1,43 @@
+require "httparty"
+
+module DirectSms
+
+  class Message
+    include HTTParty
+
+    base_uri "api.directsms.com.au"
+
+    attr_accessor :message, :to, :max_segments, :type, :message_id
+
+    def initialize(attrs = {})
+      attrs.each { |k, v| self.send("#{k}=", v) }
+    end
+    
+    def credit_balance
+      options = { query: fetch_credentials }
+      response = self.class.get("/s3/http/get_balance", options) # returns credit: 50.0
+      response = response.split(" ").last
+
+      response
+    end
+
+    def send_message
+      options = {
+        query: fetch_credentials.merge(message: message,
+                              to: to,
+                              max_segments: max_segments, 
+                              type: type,
+                              messageid: message_id)
+      }
+
+      self.class.get("/s3/http/send_message", options)
+    end
+
+    private
+
+    def fetch_credentials
+      { username: DirectSms.configuration.username, password: DirectSms.configuration.password }
+    end
+  end
+
+end

data/lib/direct_sms/version.rb

@@ -1,3 +1,3 @@
 module DirectSms
-  VERSION = "0.0.3"
+  VERSION = "1.0.1"
 end

data/spec/lib/direct_sms_spec.rb

@@ -2,22 +2,26 @@ require 'spec_helper'
 require 'net/http'
 
 describe DirectSms do
-  let!(:username) { "username" }
-  let!(:password) { "password" }
+  before(:each) do
+    DirectSms.configure do |config|
+      config.username = "username"
+      config.password = "password"
+    end
+  end
 
   describe "balance" do
     it 'returns the remaining balance' do
-      stub_request(:get, "http://api.directsms.com.au/s3/http/get_balance?password=#{password}&username=#{username}").
+      stub_request(:get, "http://api.directsms.com.au/s3/http/get_balance?password=password&username=username").
       to_return(:status => 200, :body => "credit: 300.00", :headers => {})
 
-      sms = DirectSms::Message.new(username: username, password: password)
-      expect(sms.credit_balance.body).to eq "credit: 300.00"
+      sms = DirectSms::Message.new
+      expect(sms.credit_balance).to eq "300.00"
     end
   end
 
   describe "sending sms" do
     it 'attributes can be set on new' do
-      sms = DirectSms::Message.new(username: username, password: password, :type => "2-way", :max_segments => 20)
+      sms = DirectSms::Message.new(:type => "2-way", :max_segments => 20)
 
       expect(sms.max_segments).to eq 20
       expect(sms.type).to eq "2-way"
@@ -27,7 +31,7 @@ describe DirectSms do
       stub_request(:get, "http://api.directsms.com.au/s3/http/send_message?max_segments=10&message=This%20is%20a%20test&password=password&to=%2B639178574111&messageid=&type=2-way&username=username").
         to_return(:status => 200, :body => "id: 1234567890", :headers => {})
 
-      sms = DirectSms::Message.new(username: username, password: password, :type => "2-way", :max_segments => 10)
+      sms = DirectSms::Message.new(:type => "2-way", :max_segments => 10)
       sms.message = "This is a test"
       sms.to = "+639178574111"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: direct_sms
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.0.1
 platform: ruby
 authors:
 - Mark Chavez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -98,6 +98,8 @@ files:
 - bin/direct_sms
 - direct_sms.gemspec
 - lib/direct_sms.rb
+- lib/direct_sms/configuration.rb
+- lib/direct_sms/message.rb
 - lib/direct_sms/version.rb
 - spec/lib/direct_sms_spec.rb
 - spec/spec_helper.rb