dining-table 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5624a9625e338420410c971d0d7d14105cddd1a9
-  data.tar.gz: 55197b3b204db1726e9678761b490e4c26266f67
+SHA256:
+  metadata.gz: 86007b91ee4155416dab5a0c477f781a77f294892982eebc9dcc2b08dab90f7d
+  data.tar.gz: f7babfb11c2c7e06bb4cdf5a3508ea8450ac529958ff34b427c6a650965d733c
 SHA512:
-  metadata.gz: cb6e4942a3224b25c866977ae72a1759e6793d49564848d6ee7a417351a9b92bdf4655757f8589c16ae9388b79bf3c7560cb09f9b268b1d4e75b50807ddf3011
-  data.tar.gz: 1a3d5ee3346a3d7ee25f30fb28e45a003f3f656f607af4e4ce19c0af713a01fc7fcf70dbd4f4282b6fe3da507840fe706c92cf19e439cc2284115f0b9d7f8b9d
+  metadata.gz: 5b0e978e433992578a3faf64dd27d899120a1391ef7b7d1517352867f36c66fb0dc8cfd635aec8491b998bd6954f632a1e1292c732454ff1547dee0b877fd498
+  data.tar.gz: 1c0956e9c3dbf7af598d13b5058e2ff5ac5aaf0e06e8f78fb9945c6fd15ec7e1a1013b4863d83a35bcfd49b9b8fbc8ec94934ffd51428adc90e6af770a6a9dea

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
-  - 2.2.0
-  - 2.3.0
-  - jruby-9.1.5.0
+  - 2.3.8
+  - 2.6.3
+  - jruby-9.1.9.0
 script: bundle exec rake
 before_install:
 - gem install bundler

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.1.1 (12/10/2019)
+
+* Bugfix - call per-cell configuration block with correct index for footer row
+
+## 1.1.0 (28/11/2018)
+
+* Allow passing in class of object to avoid header edge case when the collection is empty
+
 ## 1.0.0 (17/06/2018)
 
 * New configuration mechanism for HTML presenter

data/Gemfile

@@ -1,7 +1,7 @@
 source "http://rubygems.org"
 
 group :development do
-  gem "bundler", "~> 1.0"
+  gem "bundler"
   gem "juwelier", "~> 2.1.0"
 end
 

data/README.md

@@ -403,14 +403,14 @@ end
 
 ### Excel (xlsx)
 
-The Excel presenter depends on [axlsx](https://github.com/randym/axlsx). Note that `dining-table` doesn't require `axlsx`, you have to add it to 
+The Excel presenter depends on [xlsxtream](https://github.com/felixbuenemann/xlsxtream) or [axlsx](https://github.com/randym/axlsx). Note that `dining-table` doesn't require either `xlsxtream` or `axlsx`, you have to add one of them to 
 your Gemfile yourself if you want to use the Excel presenter.
 
-In order to use the Excel presenter, pass it in as a presenter and provide an axlsx worksheet:
+In order to use the Excel presenter, pass it in as a presenter and provide a xlsxtream or axlsx worksheet:
 
 ```ruby
 collection = Car.order(:brand)
-# sheet is the axlsx worksheet in which the table will be rendered
+# sheet is the xlsxtream or axlsx worksheet in which the table will be rendered
 CarTable.new( collection, nil, presenter: DiningTable::Presenters::ExcelPresenter.new( sheet ) ).render
 ```
 

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.1.1

data/dining-table.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: dining-table 1.1.0 ruby lib
+# stub: dining-table 1.1.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "dining-table".freeze
-  s.version = "1.1.0"
+  s.version = "1.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
-  s.authors = ["Micha\u{eb}l Van Damme".freeze]
-  s.date = "2018-11-28"
+  s.authors = ["Micha\u00EBl Van Damme".freeze]
+  s.date = "2019-10-12"
   s.description = "Easily output tabular data, be it in HTML, CSV or XLSX. Create clean table classes instead of messing with views to create nice tables.".freeze
   s.email = "michael.vandamme@vub.ac.be".freeze
   s.extra_rdoc_files = [
@@ -54,21 +54,21 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/mvdamme/dining-table".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.6.11".freeze
+  s.rubygems_version = "2.7.6".freeze
   s.summary = "Create tables easily. Supports html, csv and xlsx.".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<bundler>.freeze, ["~> 1.0"])
+      s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
       s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
     else
-      s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
+      s.add_dependency(%q<bundler>.freeze, [">= 0"])
       s.add_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
     end
   else
-    s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
+    s.add_dependency(%q<bundler>.freeze, [">= 0"])
     s.add_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
   end
 end

data/lib/dining-table/presenters/html_presenter.rb

@@ -77,7 +77,7 @@ module DiningTable
           add_tag(:start, :tr, row_options)
           columns.each_with_index do |column, index|
             value = footers[index]
-            configuration = cell_configuration( tags_configuration, column, :header, nil )
+            configuration = cell_configuration( tags_configuration, column, :footer, nil )
             #render_footer_cell( value, column.options_for( identifier )  )
             render_footer_cell( value, configuration )
           end

data/spec/html_table_spec.rb

@@ -295,6 +295,17 @@ describe 'HTMLTableSpec' do
         end
       end
     end
+    footer = table.elements[3]
+    footer.attributes.get_attribute('class').value.must_equal 'my-tfoot-class'
+    row = footer.elements.first
+    row.attributes.get_attribute('class').value.must_equal 'footer-tr'
+    row.elements.each_with_index do |cell, index|
+      if index == 0
+        cell.attributes.get_attribute('class').value.must_equal 'left'  # brand column
+      else
+        cell.attributes.get_attribute('class').value.must_equal 'footer-td'
+      end
+    end
   end
 
   def document( html )

data/spec/tables/car_table_with_config_blocks.rb

@@ -4,6 +4,7 @@ class CarTableWithConfigBlocks < DiningTable::Table
     presenter.table_config do |config|
       config.table.class = 'my-table-class'
       config.thead.class = 'my-thead-class'
+      config.tfoot.class = 'my-tfoot-class'
     end if presenter.type?(:html)
 
     presenter.row_config do |config, index, object|
@@ -11,7 +12,8 @@ class CarTableWithConfigBlocks < DiningTable::Table
         config.tr.class = 'header-tr'
         config.th.class = 'header-th'
       elsif index == :footer
-        config.tr.class = 'header-tr'
+        config.tr.class = 'footer-tr'
+        config.td.class = 'footer-td'
       else
         config.tr.class = index.odd? ? 'odd' : 'even'
         config.tr.class += ' lowstock' if object.stock < 10
@@ -21,7 +23,7 @@ class CarTableWithConfigBlocks < DiningTable::Table
     column :brand, :html => { :td => { :class => 'left' } }
 
     number_of_doors_options = ->( config, index, object ) do
-      config.td.class = 'center'
+      config.td.class = 'center' unless index == :footer
       config.td.class += ' five_doors' if object && object.number_of_doors == 5
     end
     column :number_of_doors, :footer => 'Total', :html => number_of_doors_options

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: dining-table
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Michaël Van Damme
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2019-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: juwelier
   requirement: !ruby/object:Gem::Requirement
@@ -99,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Create tables easily. Supports html, csv and xlsx.