dineromail 0.1.1 → 0.1.2

data/.gitignore

@@ -3,3 +3,4 @@
 Gemfile.lock
 pkg/*
 /nbproject/
+.redcar/

data/LICENSE

@@ -0,0 +1,23 @@
+LICENSE
+
+The MIT License
+
+Copyright (c) 2011 Simplex. http://soluciones-simplex.com.ar
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.rdoc

@@ -46,4 +46,11 @@ You need to create a config file (config/initializers/dineromail.rb) with:
 
 == Example dineromail forward page
 
-    <%= dineromail_button('Item name',price,:transaction_id => @transaction_id) %>
+    <%= dineromail_button('Item name',price,:transaction_id => @transaction_id) %>
+
+== Contributing to Dineromail
+
+* Fork the project.
+* Make your feature addition or bug fix
+* Send me a pull request.
+

data/dineromail.gemspec

@@ -16,8 +16,9 @@ Gem::Specification.new do |s|
   s.add_dependency "httparty"
   s.add_dependency "rails", ["~> 3.0"]
   s.add_development_dependency "bundler"
-  s.add_development_dependency "rspec"
-  
+  s.add_development_dependency "rspec-rails"
+  s.add_development_dependency "rspec2-rails-views-matchers"
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }

data/lib/dineromail/notification.rb

@@ -7,9 +7,13 @@ module Dineromail
     element :transaction_id, Integer, :tag => 'ID'
     element :type, String, :tag => 'TIPO'
     
+    def initialize(options = {})
+      @options = options.symbolize_keys
+    end
+    
     def status_report
       unless @status_report
-        @status_report = StatusReport.get_report_for(transaction_id)
+        @status_report = StatusReport.get_report_for(transaction_id,@options)
       end
       @status_report
     end

data/lib/dineromail/status_report.rb

@@ -21,16 +21,25 @@ module Dineromail
     INVALID_PASSWORD_OR_ACCOUNT_NUMBER_REQUEST_STATUS = 7
     TRANSACTION_NOT_FOUND_REQUEST_STATUS = 8
     
+    
     def valid_report?
       report_status == VALID_REPORT_STATUS
     end
     
     
-    def self.get_report_for(transaction_id)
-      account_number = Dineromail.configuration.account_number
-      password = Dineromail.configuration.password
-      ipn_url = Dineromail.configuration.ipn_webservice_url
-      request_data = "<REPORTE>
+    def self.get_report_for(transaction_id,options = {})
+      options = options.symbolize_keys
+      ipn_url = options[:ipn_webservice_url] || Dineromail.configuration.ipn_webservice_url
+      request_data = xml_request_for(transaction_id,options)
+      response = HTTParty.get ipn_url , :query => {:data => request_data}
+      self.parse response.body
+    end
+    
+    def self.xml_request_for(transaction_id,options = {})
+      options = options.symbolize_keys
+      account_number = options[:account_number] || Dineromail.configuration.account_number
+      password = options[:password] || Dineromail.configuration.password
+      "<REPORTE>
             <NROCTA>#{account_number}</NROCTA>
             <DETALLE>
             <CONSULTA>
@@ -42,8 +51,6 @@ module Dineromail
             </CONSULTA>
             </DETALLE>
           </REPORTE>"
-      response = HTTParty.get ipn_url , :query => {:data => request_data}
-      self.parse response.body
     end
     
   end

data/lib/dineromail/version.rb

@@ -1,3 +1,3 @@
 module Dineromail
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/dineromail/notification_spec.rb

@@ -11,9 +11,7 @@ describe Dineromail::Notification do
   
   it 'should get automaticaly the status data associated with the notification' do
     HTTParty.stub!(:get).and_return {
-      response = Object.new
-      response.stub!(:body).and_return(File.read( 'spec/fixtures/status_report.xml'))
-      response
+      stub :body => File.read( 'spec/fixtures/status_report.xml')
     }
     notification_xml = File.read( 'spec/fixtures/notification.xml')
     notifications = Dineromail::Notification.parse(notification_xml)

data/spec/dineromail/status_report_spec.rb

@@ -1,4 +1,6 @@
 require 'spec_helper'
+require 'rspec/rails'
+require 'rspec/rails/views/matchers'
 
 describe Dineromail::StatusReport do
   it 'should load the status report from xml' do
@@ -30,4 +32,29 @@ describe Dineromail::StatusReport do
     item.count.should == 2
     item.unit_price.should == 6.9
   end
+  
+  it 'should use the configuration to get the parameters for the request if no options are given' do
+    transaction_id = 42
+    Dineromail.configure do |c|
+      c.account_number = '10000'
+      c.password = 'password-123'
+    end
+    xml_request = Dineromail::StatusReport.xml_request_for(transaction_id)
+    xml_request.should have_tag('nrocta', :text => '10000')
+    xml_request.should have_tag('clave', :text => 'password-123')
+    xml_request.should have_tag('id', :text => '42')
+  end
+  
+  it 'should use the option parameters for the request if options are given' do
+    transaction_id = 42
+    Dineromail.configure do |c|
+      c.account_number = '10000'
+      c.password = 'password-123'
+    end
+    xml_request = Dineromail::StatusReport.xml_request_for(transaction_id,{:account_number => '2000',:password => 'password-456'})
+    xml_request.should have_tag('nrocta', :text => '2000')
+    xml_request.should have_tag('clave', :text => 'password-456')
+    xml_request.should have_tag('id', :text => '42')
+  end
+  
 end

data/spec/helpers/dineromail_helper_spec.rb

@@ -0,0 +1,128 @@
+require 'spec_helper'
+require 'rspec/rails'
+require 'rspec/rails/views/matchers'
+
+describe DineromailHelper do
+  describe "#dineromail_button" do
+    it 'should create a form with hidden fields' do
+      generated_html = helper.dineromail_button('item name',9.56)
+      generated_html.should have_tag('form') do
+        with_tag "input", :with => { :name => 'NombreItem', :type => 'hidden', :value => 'item name' }
+        with_tag "input", :with => { :name => 'PrecioItem', :type => 'hidden', :value => '9.56' }
+      end
+    end
+  end
+  
+  describe "#dineromail_inputs" do
+    it 'should create hidden fields without a form' do
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should_not have_tag('form')
+      generated_html.should have_tag('input', :with => {:type => 'hidden'})
+    end
+    
+    it 'should accept a transaction_id option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :transaction_id => '1234567')
+      generated_html.should have_tag('input', :with => {:name => 'TRX_ID', :type => 'hidden', :value => '1234567'})
+    end
+    
+    it 'should accept a logo_url option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :logo_url => 'http://test.com')
+      generated_html.should have_tag('input', :with => {:name => 'image_url', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should accept a return_url option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :return_url => 'http://test.com')
+      generated_html.should have_tag('input', :with => {:name => 'DireccionExito', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should accept an error_url option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :error_url => 'http://test.com')
+      generated_html.should have_tag('input', :with => {:name => 'DireccionFracaso', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should accept a message option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :message => true)
+      generated_html.should have_tag('input', :with => {:name => 'Mensaje', :type => 'hidden', :value => '1'})
+      generated_html = helper.dineromail_inputs('item name',9.56, :message => false)
+      generated_html.should have_tag('input', :with => {:name => 'Mensaje', :type => 'hidden', :value => '0'})
+    end
+    
+    it 'should accept an account_number option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :account_number => '1234567')
+      generated_html.should have_tag('input', :with => {:name => 'E_Comercio', :type => 'hidden', :value => '1234567'})
+    end
+    
+    it 'should accept a pay_methods option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :pay_methods => '1')
+      generated_html.should have_tag('input', :with => {:name => 'MediosPago', :type => 'hidden', :value => '1'})
+    end
+    
+    it 'should accept a currency option' do
+      currency = Dineromail::Configuration::PESO
+      generated_html = helper.dineromail_inputs('item name',9.56, :currency => currency)
+      generated_html.should have_tag('input', :with => {:name => 'TipoMoneda', :type => 'hidden', :value => currency.to_s})
+    end
+    
+    it 'should accept an item_number option' do
+      generated_html = helper.dineromail_inputs('item name',9.56, :item_number => '1')
+      generated_html.should have_tag('input', :with => {:name => 'NroItem', :type => 'hidden', :value => '1'})
+    end
+    
+    it 'should read logo_url from configuration if no value is given' do
+      Dineromail.configure do |c|
+        c.logo_url = 'http://test.com'
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'image_url', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should read return_url from configuration if no value is given' do
+      Dineromail.configure do |c|
+        c.return_url = 'http://test.com'
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'DireccionExito', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should read error_url from configuration if no value is given' do
+      Dineromail.configure do |c|
+        c.error_url = 'http://test.com'
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'DireccionFracaso', :type => 'hidden', :value => 'http://test.com'})
+    end
+    
+    it 'should read account_number from configuration if no value is given' do
+      Dineromail.configure do |c|
+        c.account_number = '1234567'
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'E_Comercio', :type => 'hidden', :value => '1234567'})
+    end
+    
+    it 'should read pay_methods from configuration if no value is given' do
+      Dineromail.configure do |c|
+        c.pay_methods = '1'
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'MediosPago', :type => 'hidden', :value => '1'})
+    end
+    
+    it 'should read currency from configuration if no value is given' do
+      currency = Dineromail::Configuration::PESO
+      Dineromail.configure do |c|
+        c.currency = currency
+      end
+      
+      generated_html = helper.dineromail_inputs('item name',9.56)
+      generated_html.should have_tag('input', :with => {:name => 'TipoMoneda', :type => 'hidden', :value => currency.to_s})
+    end
+    
+  end
+end
+

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: dineromail
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 31
   prerelease: false
   segments: 
   - 0
   - 1
-  - 1
-  version: 0.1.1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - Nicolas Mosconi
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-23 00:00:00 -03:00
+date: 2011-09-05 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -78,7 +78,7 @@ dependencies:
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: rspec-rails
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
@@ -91,6 +91,20 @@ dependencies:
         version: "0"
   type: :development
   version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: rspec2-rails-views-matchers
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id006
 description: Integration with dineromail plataform for rails projects
 email: 
 - nicolas@soluciones-simplex.com.ar
@@ -105,6 +119,7 @@ extra_rdoc_files: []
 files: 
 - .gitignore
 - Gemfile
+- LICENSE
 - README.rdoc
 - Rakefile
 - dineromail.gemspec
@@ -121,6 +136,7 @@ files:
 - spec/dineromail/status_report_spec.rb
 - spec/fixtures/notification.xml
 - spec/fixtures/status_report.xml
+- spec/helpers/dineromail_helper_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: ""