dinero_mail_ipn 1.1.1 → 2.0.2

data/Gemfile.lock

@@ -1,30 +1,42 @@
 PATH
   remote: .
   specs:
-    hrbg_dinero_mail_ipn (1.0.2)
+    dinero_mail_ipn (2.0.2)
+      chronic
       httparty (~> 0.8.1)
       nokogiri (~> 1.5.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
+    chronic (0.8.0)
+    coderay (1.0.8)
     fakeweb (1.3.0)
     httparty (0.8.1)
       multi_json
       multi_xml
+    method_source (0.8.1)
     multi_json (1.0.4)
     multi_xml (0.4.1)
     nokogiri (1.5.0)
+    pry (0.9.10)
+      coderay (~> 1.0.5)
+      method_source (~> 0.8)
+      slop (~> 3.3.1)
+    rake (0.9.2.2)
     redcarpet (2.0.1)
     shoulda (2.11.3)
+    slop (3.3.3)
     yard (0.7.4)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  dinero_mail_ipn!
   fakeweb (~> 1.3.0)
-  hrbg_dinero_mail_ipn!
+  pry
+  rake
   redcarpet (~> 2.0.1)
   shoulda (~> 2.11.3)
   yard (~> 0.7.4)

data/dinero_mail_ipn.gemspec

@@ -30,4 +30,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'fakeweb', '~> 1.3.0'
   s.add_development_dependency 'yard', '~> 0.7.4'
   s.add_development_dependency 'redcarpet', '~> 2.0.1'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'pry'
 end

data/lib/dinero_mail_ipn/consulta_pago_response.rb

@@ -23,14 +23,14 @@ module DineroMailIpn
   #
   # ## Nota
   #
-  # Por ahora las collections de la consulta solo se pueden consultar por un hash (response.hash)
+  # Por ahora las collections de la consulta solo se pueden consultar por un hash (response.dm_hash)
   #
   # ## TODO
   #
   # Agregar más métodos de 'negocio' que tengan métodos útiles.
   class ConsultaPagoResponse
 
-    attr_accessor :hash
+    attr_accessor :dm_hash
 
     STATE_DESCRIPTIONS = {0 => 'Los parámetros no respetan el formato requerido', 1 => 'La consulta se realizó correctamente', 2 => 'Los valores son incorrectos para realizar la consulta'}
 
@@ -43,7 +43,7 @@ module DineroMailIpn
     #       "State"=>"1", "Pays"=>nil, "Collections"=>nil, "Tickets"=>nil, "Receptions"=>nil,
     #       "Retreats"=>nil, "Credits"=>nil, "Debits"=>nil}})
     def initialize(_hash)
-      self.hash = _hash
+      self.dm_hash = _hash
     end
 
     # Devuelve true si la respuesta no devolvió error
@@ -68,11 +68,14 @@ module DineroMailIpn
 
       @payments = []
       begin
-        pays = self.hash["Report"]["Pays"]
+        pays = self.dm_hash["Report"]["Pays"]["Pay"]
 
         if pays
-          pays.each do |key, payment_hash|
-            @payments << Payment.new(payment_hash)
+          case pays.class.name
+          when "Hash"
+            @payments << Payment.new(pays)
+          when "Array"
+            pays.each { |pay| @payments << Payment.new(pay) }
           end
         end
       rescue Exception => e
@@ -81,14 +84,14 @@ module DineroMailIpn
       @payments
     end
 
-    # Devuelve el código de estado de la respuesta. 
+    # Devuelve el código de estado de la respuesta.
     #
     # Posibilidades: "0", "1" o "2".
     #
     # @raise [MalformedResponseError] Si la respuesta no tiene /Report/State
     def state
       begin
-        self.hash["Report"]["State"]
+        self.dm_hash["Report"]["State"]
       rescue Exception => e
         raise MalformedResponseError.new("No se encontró /Report/State en el XML de respuesta")
       end

data/lib/dinero_mail_ipn/item.rb

@@ -21,8 +21,8 @@ module DineroMailIpn
   class Item
 
     # @private
-    def initialize(hash)
-      @hash = hash
+    def initialize(_h)
+      @hash = _h
     end
 
     # Devuelve un {String} o nil

data/lib/dinero_mail_ipn/payment.rb

@@ -25,14 +25,14 @@ module DineroMailIpn
   class Payment
 
     # @private
-    def initialize(hash)
-      @hash = hash
+    def initialize(_h)
+      @dm_hash = _h
     end
 
     # Devuelve un {String} o nil
     # @return [String]
     def [](key)
-      @hash[key]
+      @dm_hash[key]
     end
 
     # Devuelve un {Array} de objetos tipo {Item}
@@ -42,9 +42,9 @@ module DineroMailIpn
 
       @items = []
 
-      unless @hash["Items"].nil?
-        @hash["Items"].each do |key, hash|
-          @items << Item.new(hash)
+      unless @dm_hash["Items"].nil?
+        @dm_hash["Items"].each do |key, _h|
+          @items << Item.new(_h)
         end
       end
 

data/lib/dinero_mail_ipn/version.rb

@@ -1,3 +1,3 @@
 module DineroMailIpn
-  VERSION = "1.1.1"
+  VERSION = "2.0.2"
 end

data/test/fixtures/ConsultaPagoOKWith2Pays.xml

@@ -0,0 +1,70 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+<Report>
+  <Email>ernesto@ombushop.com</Email>
+  <Acount>17128254</Acount>
+  <Pin>AYCN7IXDTM</Pin>
+  <StartDate>20110620</StartDate>
+  <EndDate>20110703</EndDate>
+  <XML>1</XML>
+  <State>1</State>
+  <Pays>
+    <Pay trx_id="R163000000">
+      <Trx_Date>2011-12-20 05:44:56</Trx_Date>
+      <Trx_NombreComprador>Juan Perez</Trx_NombreComprador>
+      <Trx_Email>juanperez@ombushop.com</Trx_Email>
+      <Trx_Payment>108.00</Trx_Payment>
+      <Trx_ShipAddress></Trx_ShipAddress>
+      <Trx_Comment></Trx_Comment>
+      <Trx_MontoNeto>100.97</Trx_MontoNeto>
+      <Trx_SellerDocumentType>DNI</Trx_SellerDocumentType>
+      <Trx_SellerDocumentNumber>26.000.000</Trx_SellerDocumentNumber>
+      <Trx_Number>12345678</Trx_Number>
+      <Trx_PaymentMethod>Codigo de Barras</Trx_PaymentMethod>
+      <Trx_PaymentMean>Pago Facil</Trx_PaymentMean>
+      <Trx_BuyerDocumentType>DNI</Trx_BuyerDocumentType>
+      <Trx_BuyerDocumentNumber>26000000</Trx_BuyerDocumentNumber>
+      <Trx_BuyerPhone>+540351844232</Trx_BuyerPhone>
+      <Items>
+        <Item Item_Code="SKU123">
+          <Item_Quantity>1</Item_Quantity>
+          <Item_Description>Zapatos de Cuero</Item_Description>
+          <Item_Payment>68.00</Item_Payment>
+        </Item>
+      </Items>
+    </Pay>
+    <Pay trx_id="R163000001">
+      <Trx_Date>2011-12-21 05:44:56</Trx_Date>
+      <Trx_NombreComprador>Derp Herp</Trx_NombreComprador>
+      <Trx_Email>derp_herp@ombushop.com</Trx_Email>
+      <Trx_Payment>108.00</Trx_Payment>
+      <Trx_ShipAddress></Trx_ShipAddress>
+      <Trx_Comment></Trx_Comment>
+      <Trx_MontoNeto>100.97</Trx_MontoNeto>
+      <Trx_SellerDocumentType>DNI</Trx_SellerDocumentType>
+      <Trx_SellerDocumentNumber>25.000.000</Trx_SellerDocumentNumber>
+      <Trx_Number>12345679</Trx_Number>
+      <Trx_PaymentMethod>Codigo de Barras</Trx_PaymentMethod>
+      <Trx_PaymentMean>Pago Facil</Trx_PaymentMean>
+      <Trx_BuyerDocumentType>DNI</Trx_BuyerDocumentType>
+      <Trx_BuyerDocumentNumber>25000000</Trx_BuyerDocumentNumber>
+      <Trx_BuyerPhone>+540351844231</Trx_BuyerPhone>
+      <Items>
+        <Item Item_Code="SKU123">
+          <Item_Quantity>1</Item_Quantity>
+          <Item_Description>Zapatos de Cuero</Item_Description>
+          <Item_Payment>68.00</Item_Payment>
+        </Item>
+      </Items>
+    </Pay>
+  </Pays>
+  <Collections />
+  <Tickets />
+  <Receptions />
+  <Retreats />
+  <Credits />
+  <Debits />
+</Report>
+
+<!-- client = DineroMailIpn::Client.new(email: "isaac.attie@cir-med.com", account: "21353370", pin: "BZLOG9UB72")
+params = {:XML => 1, :Acount => "21353370", :Pin => "BZLOG9UB72", :Email => "isaac.attie@cir-med.com"}.merge({:StartDate => client.format_date(Date.today - 7), :EndDate => client.format_date(Date.today)})
+xml = client.class.get("https://argentina.dineromail.com/vender/ConsultaPago.asp", :query => params) -->

data/test/test_dinero_mail_ipn.rb

@@ -17,25 +17,49 @@ class TestDineroMailIpn < Test::Unit::TestCase
       assert_equal response.state_description, "La consulta se realizó correctamente"
     end
 
-    should "return OK with a collection of payments" do
+    should "return OK with 1 payment" do
       stub_get("/vender/ConsultaPago.asp?XML=1&Acount=17128254&Pin=AYCN7IXDTM&Email=ernesto%40ombushop.com&StartDate=20110702&EndDate=20110703",
-         "ConsultaPagoOkWithPays.xml")
+         "ConsultaPagoOKWith1Pay.xml")
       client = DineroMailIpn::Client.new(:email => 'ernesto@ombushop.com',
                                           :account => '17128254',
                                           :pin => 'AYCN7IXDTM')
       response = client.consulta_pago(Date.new(2011,7,2), Date.new(2011,7,3))
-      assert_equal response.state, "1"
+      assert_equal "1", response.state
+      assert_equal 1, response.payments.size
+      assert response.ok?
+      assert_equal "La consulta se realizó correctamente", response.state_description
+      assert !response.payments.empty?
+      payment = response.payments.first
+      assert_equal "juanperez@ombushop.com", payment["Trx_Email"]
+      assert_equal "R163000000", payment["trx_id"]
+      assert payment["Trx_Numbr"].nil?
+      assert !payment.items.empty?
+      item = payment.items.first
+      assert_equal "SKU123", item["Item_Code"]
+      assert_equal "68.00", item["Item_Payment"]
+      assert item["item_quantity"].nil?
+    end
+
+    should "return OK with 2 payments" do
+      stub_get("/vender/ConsultaPago.asp?XML=1&Acount=17128254&Pin=AYCN7IXDTM&Email=ernesto%40ombushop.com&StartDate=20110702&EndDate=20110703",
+         "ConsultaPagoOKWith2Pays.xml")
+      client = DineroMailIpn::Client.new(:email => 'ernesto@ombushop.com',
+                                          :account => '17128254',
+                                          :pin => 'AYCN7IXDTM')
+      response = client.consulta_pago(Date.new(2011,7,2), Date.new(2011,7,3))
+      assert_equal "1", response.state
+      assert_equal 2, response.payments.size
       assert response.ok?
       assert_equal response.state_description, "La consulta se realizó correctamente"
       assert !response.payments.empty?
       payment = response.payments.first
-      assert_equal payment["Trx_Email"], "juanperez@ombushop.com"
-      assert_equal payment["trx_id"], "R163000000"
+      assert_equal "juanperez@ombushop.com", payment["Trx_Email"]
+      assert_equal "R163000000", payment["trx_id"]
       assert payment["Trx_Numbr"].nil?
       assert !payment.items.empty?
       item = payment.items.first
-      assert_equal item["Item_Code"], "SKU123"
-      assert_equal item["Item_Payment"], "68.00"
+      assert_equal "SKU123", item["Item_Code"]
+      assert_equal "68.00", item["Item_Payment"]
       assert item["item_quantity"].nil?
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dinero_mail_ipn
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 2.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-31 00:00:00.000000000 Z
+date: 2012-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -124,6 +124,38 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.1
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Dinero Mail IPN stub
 email:
 - ernesto@ombushop.com
@@ -152,7 +184,8 @@ files:
 - resources/IPN_es.pdf
 - script/console
 - test/fixtures/ConsultaPagoErrorBadCredentials.xml
-- test/fixtures/ConsultaPagoOkWithPays.xml
+- test/fixtures/ConsultaPagoOKWith2Pays.xml
+- test/fixtures/ConsultaPagoOkWith1Pay.xml
 - test/fixtures/ConsultaPagoOkWithoutCollections.xml
 - test/fixtures/ConsultaTransacciones1-2Success.xml
 - test/fixtures/ConsultaTransacciones1Success.xml
@@ -172,12 +205,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2281383812012634155
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2281383812012634155
 requirements: []
 rubyforge_project: dinero_mail_ipn
 rubygems_version: 1.8.24