dimensional 1.0.0 → 1.0.1

data/CHANGELOG

@@ -1,3 +1,5 @@
 0.1.0
 0.1.1	Simpler conversion system-to-system and redefinition of preference semantics.
-0.1.2	Cleanup tests to work with gem check -t
+0.1.2	Cleanup tests to work with gem check -t
+1.0.0	Production Release 1
+1.0.1	Use Rationals for default values and avoid the dreaded integer division = 0 problem

data/lib/dimensional/unit.rb

@@ -48,7 +48,7 @@ module Dimensional
       @name = name.to_s
       @system = system
       @dimension = dimension
-      @reference_factor = options[:reference_factor] || 1
+      @reference_factor = options[:reference_factor] || Rational(1,1)
       @reference_units = options[:reference_units] || {}
       @abbreviation = options[:abbreviation]
       @detector = options[:detector] || /\A#{[name, abbreviation].compact.join('|')}\Z/
@@ -73,7 +73,7 @@ module Dimensional
     # The technique used is to multiply the bases' exponents by our exponent and then consolidate
     # resulting common bases by adding their exponents.
     def base
-      return {self => 1} if base?
+      return {self => Rational(1,1)} if base?
       @base ||= reference_units.inject({}) do |summary0, (ru0, exp0)|
         t = ru0.base.inject({}){|summary1, (ru1, exp1)| summary1[ru1] = exp1 * exp0;summary1}
         summary0.merge(t) {|ru, expa, expb| expa + expb}
@@ -82,13 +82,13 @@ module Dimensional
 
     # The conversion factor relative to the base unit.
     def factor
-      @factor ||= reference_factor * reference_units.inject(1){|f, (ru, exp)| f * (ru.factor**exp)}
+      @factor ||= reference_factor * reference_units.inject(Rational(1,1)){|f, (ru, exp)| f * (ru.factor**exp)}
     end
 
     # Returns the conversion factor to convert to the other unit
     def convert(other)
       raise "Units #{self} and #{other} are not commensurable" unless commensurable?(other)
-      return 1 if self == other
+      return Rational(1,1) if self == other
       self.factor / other.factor
     end
 

data/lib/dimensional/version.rb

@@ -1,3 +1,3 @@
 module Dimensional
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/metric_test.rb

@@ -161,6 +161,14 @@ class MetricTest < Test::Unit::TestCase
     assert_same @fathom, new.unit
   end
 
+  def test_convert_with_fractional_factor
+    range = Class.new(Metric)
+    range.dimension = Dimension::L
+    new = range.new(100000, @meter).convert(@kilometer)
+    assert_in_delta(100, new, 0.000001)
+    assert_same @kilometer, new.unit
+  end
+
   def test_identity_conversion
     depth = Class.new(Metric)
     depth.dimension = Dimension::L

data/test/unit_test.rb

@@ -25,7 +25,9 @@ class UnitTest < Test::Unit::TestCase
     assert_same Dimension::L, u.dimension
     assert u.base?
     assert_equal({u => 1}, u.base)
-    assert_same 1, u.factor
+    assert_kind_of Rational, u.base[u]
+    assert_equal 1, u.factor
+    assert_kind_of Rational, u.factor
   end
 
   def test_enumerability

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dimensional
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Chris Hapgood
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-06 00:00:00 -05:00
+date: 2010-02-08 00:00:00 -05:00
 default_executable: 
 dependencies: []