differential 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34db9a9aa5d5c4a0662d7ca92ad84787ca400da4
-  data.tar.gz: 3d18436809dec81d69a9a48b2bbc944520ac546b
+  metadata.gz: 338faf87efae2afbc60eaa95b20fbfe0cddbf410
+  data.tar.gz: 91afe0b117f23e33f86be2df86169fa23111152c
 SHA512:
-  metadata.gz: 9f761ad7abf2776aa1fe8221617cc6d6418b12a01356f4ce14fd302d249b7d1583f2a09e15cb6df5fafbd8f055584c46766f3ca07efb86d5c13ffa13ce65e1da
-  data.tar.gz: a7a0c48e0fd32f14c2ce63e303fa61315f6e853ea2e675e66f2eb653f5d49dc1a5c8ff8dd83025a34d01807669c02593b9a77effe8383bb1f74c867e22c17e8c
+  metadata.gz: 6a27dc65828848113eba8c0128ac39d791e2962e29ec7cfaa44e01bba160a057f5fff7b1d43d35de3fad9337316d67d75a6033e733810f41f7dd55f2d6c7c812
+  data.tar.gz: fd0615b537efe24c4df38615abe47f082447dc3299d60724978aac18e6c0d4c926a9dbf694bf06677fafbf630d7349c24894755036df6f45601dbe8a5b65cc4b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    differential (1.0.4)
+    differential (1.0.5)
 
 GEM
   remote: https://rubygems.org/

data/lib/differential/calculator/group.rb

@@ -22,7 +22,11 @@ module Differential
       def initialize(id)
         raise ArgumentError, 'id is required' unless id
 
-        @id = id
+        @id = id.is_a?(::Differential::Parser::Id) ? id : ::Differential::Parser::Id.new(id)
+      end
+
+      def sorted_items
+        items.sort_by { |item| item.id.value }
       end
 
       def items

data/lib/differential/calculator/item.rb

@@ -25,7 +25,7 @@ module Differential
 
         @a_records  = []
         @b_records  = []
-        @id         = id
+        @id         = id.is_a?(::Differential::Parser::Id) ? id : ::Differential::Parser::Id.new(id)
       end
 
       def add(record, side)

data/lib/differential/calculator/report.rb

@@ -18,6 +18,10 @@ module Differential
     class Report
       include HasTotals
 
+      def sorted_groups
+        groups.sort_by { |group| group.id.value }
+      end
+
       def groups
         groups_by_id.values
       end

data/lib/differential/version.rb

@@ -8,5 +8,5 @@
 #
 
 module Differential
-  VERSION = '1.0.4'
+  VERSION = '1.0.5'
 end

data/spec/differential/calculator/group_spec.rb

@@ -10,11 +10,35 @@
 require './spec/spec_helper'
 
 describe ::Differential::Calculator::Group do
-  let(:id) { 'matt' }
+  let(:group_id) { 'matt' }
 
-  let(:group) { ::Differential::Calculator::Group.new(id) }
+  let(:group) { ::Differential::Calculator::Group.new(group_id) }
 
   it 'should initialize correctly' do
-    expect(group.id).to eq(id)
+    expect(group.id).to eq(group_id)
+  end
+
+  it '#sorted_items should be lexicographically sorted' do
+    unsorted_ids = [
+      'zYx',
+      '123',
+      'aBC',
+      '1 AC.'
+    ]
+
+    unsorted_ids.each do |unsorted_id|
+      record = ::Differential::Parser::Record.new(id:       unsorted_id,
+                                                  group_id: group_id,
+                                                  value:    1,
+                                                  data:     {})
+
+      group.add(record, ::Differential::Calculator::Side::A)
+    end
+
+    actual_ids = group.sorted_items.map { |i| i.id.value }
+
+    expected_ids = unsorted_ids.sort
+
+    expect(actual_ids).to eq(expected_ids)
   end
 end

data/spec/differential/calculator/report_spec.rb

@@ -134,4 +134,30 @@ describe ::Differential::Calculator::Report do
       expect(group2_item2.delta).to eq(group_2_minus2.value)
     end
   end
+
+  it '#sorted_groups should be lexicographically sorted' do
+    report = ::Differential::Calculator::Report.new
+
+    unsorted_ids = [
+      'zYx',
+      '123',
+      'aBC',
+      '1 AC.'
+    ]
+
+    unsorted_ids.each do |unsorted_id|
+      record = ::Differential::Parser::Record.new(id:       '1',
+                                                  group_id: unsorted_id,
+                                                  value:    1,
+                                                  data:     {})
+
+      report.add(record, ::Differential::Calculator::Side::A)
+    end
+
+    actual_ids = report.sorted_groups.map { |i| i.id.value }
+
+    expected_ids = unsorted_ids.sort
+
+    expect(actual_ids).to eq(expected_ids)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: differential
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Matthew Ruggio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-22 00:00:00.000000000 Z
+date: 2018-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec