did_you_mean 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb27120266763f1d41479bb12b02ef1db0c8b7bd
-  data.tar.gz: cebe5a510c5fa9863d38a4f91ea384a10cbf1b76
+  metadata.gz: 95c8a3e5873fe852e2de4de33e70ada6b4695bf5
+  data.tar.gz: ab23c8333c2fb0c3df66b804a1fc1274eb21674c
 SHA512:
-  metadata.gz: 4bbab8b8a733acbb662684d9b631011920dec45e168c24274237a19f015f68db5aa49c5cec3833def7424c9066c4bf6efc76add22144f97c8b44d004fdff041f
-  data.tar.gz: 83103bcfbd0eec01e78a53b71b751eaef25f914330a44aac9f7c7e02244af29e96cf5654f6a4542d256062a97b2daa8c073522d57a34822fc16f4ac40e804adf
+  metadata.gz: 7b1d6d10f8e658fa070c97752ff09b961b57b53f71a434546a81b522f87a32129c25a398efc55a3076ed617ac9b3a6414c0005d7c0492c89d55f1398de618c23
+  data.tar.gz: 47631c99fab406a57242310173b0f4154c00b70bc8ca113f665f0b93710625c3d3811f3e352e2d181a4ffd8ca89d855b792775919d98ffec68700b4dab5a40a0

data/lib/did_you_mean/core_ext/name_error.rb

@@ -20,11 +20,11 @@ module DidYouMean
     end
 
     def corrections
-      spell_checker.corrections
+      @corrections ||= spell_checker.corrections
     end
 
     def spell_checker
-      @spell_checker ||= SPELL_CHECKERS[self.class.to_s].new(self)
+      SPELL_CHECKERS[self.class.to_s].new(self)
     end
   end
 end

data/lib/did_you_mean/spell_checkers/name_error_checkers/class_name_checker.rb

@@ -6,11 +6,14 @@ module DidYouMean
     attr_reader :class_name
 
     def initialize(exception)
-      @class_name, @receiver = exception.name, exception.receiver
+      @class_name, @receiver, @original_message = exception.name, exception.receiver, exception.original_message
     end
 
     def corrections
-      @corrections ||= SpellChecker.new(dictionary: class_names).correct(class_name).map(&:full_name)
+      @corrections ||= SpellChecker.new(dictionary: class_names)
+                         .correct(class_name)
+                         .map(&:full_name)
+                         .reject {|qualified_name| @original_message.include?(qualified_name) }
     end
 
     def class_names

data/lib/did_you_mean/version.rb

@@ -1,3 +1,3 @@
 module DidYouMean
-  VERSION = "1.0.3"
+  VERSION = "1.0.4"
 end

data/test/core_ext/name_error_extension_test.rb

@@ -20,7 +20,7 @@ class NameErrorExtensionTest < Minitest::Test
 
   def test_message
     message = <<~MESSAGE.chomp
-      undefined local variable or method `doesnt_exist' for #{method(:to_s).super_method.call}
+      undefined local variable or method `doesnt_exist' for #{to_s}
       Did you mean?  does_exist
     MESSAGE
 
@@ -36,6 +36,18 @@ class NameErrorExtensionTest < Minitest::Test
     error.to_s
     assert_equal 1, error.to_s.scan("Did you mean?").count
   end
+
+  def test_correctable_error_objects_are_dumpable
+   error = begin
+             File.open('/tmp/file').sizee
+           rescue NoMethodError => e
+             e
+           end
+
+   error.to_s
+
+   assert_equal "undefined method `sizee' for #<File:/tmp/file>", Marshal.load(Marshal.dump(error)).original_message
+  end
 end
 
 class IgnoreCallersTest < Minitest::Test

data/test/edit_distance/jaro_winkler_test.rb

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 require 'test_helper'
 
 class JaroWinklerTest < Minitest::Test

data/test/fixtures/book.rb

@@ -0,0 +1,4 @@
+class Book
+  class Cover
+  end
+end

data/test/spell_checking/class_name_test.rb

@@ -62,4 +62,16 @@ class ClassNameTest < Minitest::Test
     error = assert_raises(NameError) { ::Book::Page.new.tableof_contents }
     assert_correction "Book::TableOfContents", error.corrections
   end
+
+  def test_does_not_suggest_user_input
+    error = assert_raises(NameError) { ::Book::Cover }
+
+    # This is a weird require, but in a multi-threaded condition, a constant may
+    # be loaded between when a NameError occurred and when the spell checker
+    # attemps to find a possible suggestion. The manual require here simulates
+    # a race condition a single test.
+    require_relative '../fixtures/book'
+
+    assert_empty error.corrections
+  end
 end

data/test/verbose_formatter_test.rb

@@ -7,7 +7,7 @@ class VerboseFormatterTest < Minitest::Test
 
   def test_message
     assert_equal <<~MESSAGE.chomp, @error.message
-      undefined method `inspectt' for #{method(:to_s).super_method.call}
+      undefined method `inspectt' for #{to_s}
 
           Did you mean? inspect
        

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: did_you_mean
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-25 00:00:00.000000000 Z
+date: 2019-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -102,6 +102,7 @@ files:
 - test/experimental/initializer_name_correction_test.rb
 - test/experimental/key_error_test.rb
 - test/experimental/method_name_checker_test.rb
+- test/fixtures/book.rb
 - test/spell_checker_test.rb
 - test/spell_checking/class_name_test.rb
 - test/spell_checking/method_name_test.rb
@@ -109,6 +110,7 @@ files:
 - test/spell_checking/variable_name_test.rb
 - test/test_helper.rb
 - test/verbose_formatter_test.rb
+- tmp/.keep
 homepage: https://github.com/yuki24/did_you_mean
 licenses:
 - MIT
@@ -129,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: '"Did you mean?" experience in Ruby'
@@ -140,6 +142,7 @@ test_files:
 - test/experimental/initializer_name_correction_test.rb
 - test/experimental/key_error_test.rb
 - test/experimental/method_name_checker_test.rb
+- test/fixtures/book.rb
 - test/spell_checker_test.rb
 - test/spell_checking/class_name_test.rb
 - test/spell_checking/method_name_test.rb