did_you_mean 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 28e1952e8b23b15341dd32e2b069ff5a1095c214
-  data.tar.gz: ab42a54b71d2ea36821f135af2182dbc42671abf
+  metadata.gz: cb27120266763f1d41479bb12b02ef1db0c8b7bd
+  data.tar.gz: cebe5a510c5fa9863d38a4f91ea384a10cbf1b76
 SHA512:
-  metadata.gz: d91287f29b78c81341da7c6154272f25f8d9ca28b1d71599079746f24182830d1833493a270705fa3bdc20e003fb1566307772974b88fc6c7b904a7fe3b7a923
-  data.tar.gz: 36a5296b2b247ff3a8791623108e3518571f2d8ad4864bc3eddfb9e17cb648726ba7af9ab4f5dc26d1ad5b4fc47e66044a41e62e066ef4d68727fb64ad8bec59
+  metadata.gz: 4bbab8b8a733acbb662684d9b631011920dec45e168c24274237a19f015f68db5aa49c5cec3833def7424c9066c4bf6efc76add22144f97c8b44d004fdff041f
+  data.tar.gz: 83103bcfbd0eec01e78a53b71b751eaef25f914330a44aac9f7c7e02244af29e96cf5654f6a4542d256062a97b2daa8c073522d57a34822fc16f4ac40e804adf

data/.travis.yml

@@ -11,6 +11,10 @@ after_success:
   - bundle exec rake benchmark:memory
 
 rvm:
-  - 2.3.0
+  - 2.3.1
   - ruby-head
   - jruby-head
+
+matrix:
+  allow_failures:
+    - rvm: jruby-head

data/lib/did_you_mean/core_ext/name_error.rb

@@ -10,7 +10,10 @@ module DidYouMean
       msg = super.dup
       bt  = caller(1, 6)
 
-      msg << Formatter.new(corrections).to_s if IGNORED_CALLERS.all? {|ignored| bt.grep(ignored).empty? }
+      if IGNORED_CALLERS.all? {|ignored| bt.grep(ignored).empty? } && (!cause.respond_to?(:corrections) || cause.corrections.empty?)
+        msg << Formatter.new(corrections).to_s
+      end
+
       msg
     rescue
       super

data/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb

@@ -6,7 +6,7 @@ module DidYouMean
 
     def initialize(exception)
       @name       = exception.name.to_s.tr("@", "")
-      @lvar_names = RUBY_ENGINE == 'jruby' ? [] : exception.local_variables
+      @lvar_names = exception.respond_to?(:local_variables) ? exception.local_variables : []
       receiver    = exception.receiver
 
       @method_names = receiver.methods + receiver.private_methods

data/lib/did_you_mean/version.rb

@@ -1,3 +1,3 @@
 module DidYouMean
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/test/spell_checking/method_name_test.rb

@@ -9,6 +9,12 @@ class MethodNameTest < Minitest::Test
       raiae NoMethodError
     end
 
+    def raise_no_method_error
+      self.firstname
+    rescue NoMethodError => e
+      raise e, e.message, e.backtrace
+    end
+
     protected
     def the_protected_method; end
 
@@ -71,4 +77,28 @@ class MethodNameTest < Minitest::Test
     assert_correction :raise, error.corrections
     assert_match "Did you mean?  raise", error.to_s
   end
+
+  def test_does_not_append_suggestions_twice
+    error = assert_raises NoMethodError do
+      begin
+        @user.firstname
+      rescue NoMethodError => e
+        raise e, e.message, e.backtrace
+      end
+    end
+
+    assert_equal 1, error.to_s.scan(/Did you mean/).count
+  end
+
+  def test_does_not_append_suggestions_three_times
+    error = assert_raises NoMethodError do
+      begin
+        @user.raise_no_method_error
+      rescue NoMethodError => e
+        raise e, e.message, e.backtrace
+      end
+    end
+
+    assert_equal 1, error.to_s.scan(/Did you mean/).count
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: did_you_mean
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-20 00:00:00.000000000 Z
+date: 2017-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: '"Did you mean?" experience in Ruby'