did_you_mean 0.9.4 → 0.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 17d1aa077937ae14999fe9cf7f30ad339b9d7ff0
-  data.tar.gz: f93090d72fbafed6291f073926a32c36930adcfb
+  metadata.gz: 1ca4eb20ca371d3757c5f06e9edd950b12678e52
+  data.tar.gz: b628df2f452d7708b600c84664322005d797cee9
 SHA512:
-  metadata.gz: a73eb4adec3501a186751d7806190d763db5f96fc848ca990ef28a6c736309739090c40aff0914634d7f9448b99e77e45167a4e24cc338fd807ed98ec3a6bf54
-  data.tar.gz: f344c68e841947506a6ee465a7f8bc74f0ee7eaf4d749f438e5f57c38c50c5fa7191a995c4bc3afee02fd8680cfc86a5bdb93d7b98214e4ace701cf42a8c9805
+  metadata.gz: cc2fbb68045d990ce50f4a3aa260037736f5ad480d3cdaad352d3666020fc88c2e3be7fdbfe27525773d556244c1cfc0c4e7aa8ad3f9174e4b03342be28b9035
+  data.tar.gz: 75e974ffc415ab2fd3d78fdef7de4ce44cb37245124a57a9ae73019f16d9a75025789f34ce2b7c67144f692b609b8acf45bee49e048cc7e033934273b3b6a85d

data/.travis.yml

@@ -1,17 +1,19 @@
-script: bundle exec rake test
+language: ruby
+script:   bundle exec rake test
+cache:    bundler
+sudo:     false
 
 rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.5
-  - 2.2.0-preview1
+  - 2.2.0
   - ruby-head
-  - jruby
-  - rbx
+  - jruby-1.7.17
+  - jruby-head
+  - rbx-2.4.1
 
 gemfile:
-  - gemfiles/activerecord_30.gemfile
-  - gemfiles/activerecord_31.gemfile
   - gemfiles/activerecord_32.gemfile
   - gemfiles/activerecord_40.gemfile
   - gemfiles/activerecord_41.gemfile
@@ -19,10 +21,15 @@ gemfile:
   - gemfiles/activerecord_edge.gemfile
 
 matrix:
-  allow_failures:
-    - rvm: jruby
-      gemfile: gemfiles/activerecord_42.gemfile
-    - rvm: jruby
+  exclude:
+    - rvm: 1.9.3
+      gemfile: gemfiles/activerecord_edge.gemfile
+    - rvm: 2.0.0
       gemfile: gemfiles/activerecord_edge.gemfile
-    - rvm: rbx
+    - rvm: 2.1.5
+      gemfile: gemfiles/activerecord_edge.gemfile
+  allow_failures:
+    - rvm: jruby-head
+    - rvm: rbx-2.4.1
+    - gemfile: gemfiles/activerecord_edge.gemfile
   fast_finish: true

data/Appraisals

@@ -1,11 +1,3 @@
-appraise "activerecord_30" do
-  gem "activerecord", "~> 3.0.0"
-end
-
-appraise "activerecord_31" do
-  gem "activerecord", "~> 3.1.0"
-end
-
 appraise "activerecord_32" do
   gem "activerecord", "~> 3.2.0"
 end
@@ -19,7 +11,7 @@ appraise "activerecord_41" do
 end
 
 appraise "activerecord_42" do
-  gem "activerecord", "~> 4.2.0.beta4"
+  gem "activerecord", "~> 4.2.0"
 end
 
 appraise "activerecord_edge" do

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [v0.9.5](https://github.com/yuki24/did_you_mean/tree/v0.9.5)
+
+_<sup>released on 2015-01-07 12:41:23 UTC</sup>_
+
+#### Bug Fixes
+
+- Whitelist `#safe_constantize` method from `ActiveSupport::Inflector` to avoid significant performance slowdown ( [@tleish](https://github.com/tleish), [#19](https://github.com/yuki24/did_you_mean/issues/19 "Significant Slowdown when Using Debugger"), [#20](https://github.com/yuki24/did_you_mean/pull/20 "Whitelisting safe\_constantize (ActiveSupport::Inflector) method"))
+
 ## [v0.9.4](https://github.com/yuki24/did_you_mean/tree/v0.9.4)
 
 _<sup>released on 2014-11-18 03:51:41 UTC</sup>_

data/gemfiles/activerecord_42.gemfile

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", "~> 4.2.0.beta4"
+gem "activerecord", "~> 4.2.0"
 
 platforms :ruby do
   gem "sqlite3"

data/lib/did_you_mean/core_ext/name_error.rb

@@ -1,18 +1,18 @@
 class NameError
   attr_reader :frame_binding
 
-  begin
-    require "active_support/core_ext/name_error"
-
-    def missing_name
-      if /undefined local variable or method/ !~ original_message
-        $1 if /((::)?([A-Z]\w*)(::[A-Z]\w*)*)$/ =~ original_message
-      end
-    end if method_defined?(:missing_name)
-  rescue LoadError; end
+  IGNORED_CALLERS = [
+    /( |`)missing_name'/,
+    /( |`)safe_constantize'/
+  ].freeze
+  private_constant :IGNORED_CALLERS
 
   def to_s_with_did_you_mean
-    original_message + did_you_mean?.to_s rescue original_message
+    msg = original_message
+    msg << did_you_mean?.to_s if IGNORED_CALLERS.all? {|ignored| caller.first(8).grep(ignored).empty? }
+    msg
+  rescue
+    original_message
   end
 
   alias original_message to_s

data/lib/did_you_mean/version.rb

@@ -1,3 +1,3 @@
 module DidYouMean
-  VERSION = "0.9.4"
+  VERSION = "0.9.5"
 end

data/test/name_error_extension_test.rb

@@ -17,8 +17,49 @@ class NameErrorExtensionTest < Minitest::Test
     DidYouMean.finders["NameError"] = @old_finder
   end
 
-  def test_message?
+  def test_message
     assert_match "Y U SO SLOW?", @error.to_s
     assert_match "Y U SO SLOW?", @error.message
   end
 end
+
+class IgnoreCallersTest < Minitest::Test
+  class Boomer
+    def initialize(*)
+      raise Exception, "finder was created when it shouldn't!"
+    end
+  end
+
+  def setup
+    @org = DidYouMean.finders["NameError"]
+    DidYouMean.finders["NameError"] = Boomer
+
+    @error = assert_raises(NameError){ doesnt_exist }
+  end
+
+  def teardown
+    DidYouMean.finders["NameError"] = @org
+  end
+
+  def test_ignore_missing_name
+    assert_nothing_raised { missing_name }
+  end
+
+  def test_ignore_safe_constantize
+    assert_nothing_raised { safe_constantize }
+  end
+
+  private
+
+  def safe_constantize
+    @error.message
+  end
+
+  def missing_name
+    @error.message
+  end
+
+  def assert_nothing_raised
+    yield
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: did_you_mean
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.5
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-18 00:00:00.000000000 Z
+date: 2015-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: interception
@@ -104,8 +104,6 @@ files:
 - ext/did_you_mean/extconf.rb
 - ext/did_you_mean/method_missing.c
 - ext/did_you_mean/org/yukinishijima/ReceiverCapturer.java
-- gemfiles/activerecord_30.gemfile
-- gemfiles/activerecord_31.gemfile
 - gemfiles/activerecord_32.gemfile
 - gemfiles/activerecord_40.gemfile
 - gemfiles/activerecord_41.gemfile
@@ -152,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: '"Did you mean?" experience in Ruby'

data/gemfiles/activerecord_30.gemfile

@@ -1,21 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 3.0.0"
-
-platforms :ruby do
-  gem "sqlite3"
-end
-
-platforms :jruby do
-  gem "activerecord-jdbcsqlite3-adapter"
-end
-
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "racc"
-  gem "rubinius-developer_tools"
-end
-
-gemspec :path => "../"

data/gemfiles/activerecord_31.gemfile

@@ -1,21 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 3.1.0"
-
-platforms :ruby do
-  gem "sqlite3"
-end
-
-platforms :jruby do
-  gem "activerecord-jdbcsqlite3-adapter"
-end
-
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "racc"
-  gem "rubinius-developer_tools"
-end
-
-gemspec :path => "../"