dial 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31949e2dbaf8b3ca4f422ae02115747913ce3bd704b0aaf8d45d5956d0ba2ac5
-  data.tar.gz: aecdd78df3d7e50c0dd9b98c67c0f7633d6cc2fa43ea33d01987a148dff53cf0
+  metadata.gz: 60920a66ef5fc1cfba31a668f5b582c26d95a821b589bda396964a6946bb82bb
+  data.tar.gz: de23202b1c41cc4be4e0f51c40904001fc573ce1894802c7c331fc99fa45ad47
 SHA512:
-  metadata.gz: 21ed80548f3559308cfdc13ff69df8168ef87ffa6268faea8d5901e2209cbd1e9f775bcbd48db355e83c1d3e48cb59f285af0c0271fc1fa14442852c84dab521
-  data.tar.gz: 202f8d84d6ce0520b7bf53df0cac7545a85f1c6f723c845158c9161cf52f1a1a6fbe55e70671a70c9bf1ca43aad052d28d2f10b3a7572ea34c5747090121ab98
+  metadata.gz: b5852b9db8040af2e14c082b38fe2a31dabcb9a6191db373eaee5f4fa18c45db8577b54309e41c3a065ef7aa5277262483f8cff72286c8ef554808eb083c4ab8
+  data.tar.gz: 15616a0cb158f916b6e1d0b61fe1e3ca10ddfab848f87eb51d65edc9a986553f23a1e48487bbea991fbc28c8d934a60d3a229d5c3b69ae89100a827c94563d03

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## [Unreleased]
 
+## [0.2.0] - 2025-02-22
+
+- Perf: Eagerly check content type to avoid profiling incompatible requests
+- Perf: Manually write vernier output files in background thread
+- Use gzipped vernier output files by default
+- UI: Use inline color properties to prevent overriding by user styles
+
 ## [0.1.9] - 2025-01-27
 
 - Increase default vernier allocation interval from 10k to 100k

data/lib/dial/constants.rb

@@ -1,11 +1,16 @@
 # frozen_string_literal: true
 
+require "rack"
+
 require_relative "version"
 
 module Dial
   PROGRAM_ID = Process.getsid Process.pid
 
-  REQUEST_TIMING_HEADER = "dial_request_timing"
+  HTTP_ACCEPT = "HTTP_ACCEPT"
+  CONTENT_TYPE = ::Rack::CONTENT_TYPE
+  CONTENT_LENGTH = ::Rack::CONTENT_LENGTH
+  REQUEST_TIMING = "dial_request_timing"
 
   FILE_STALE_SECONDS = 60 * 60
 

data/lib/dial/engine/routes.rb

@@ -4,7 +4,7 @@ Dial::Engine.routes.draw do
   scope path: "/dial", as: "dial" do
     get "profile", to: lambda { |env|
       uuid = env[::Rack::QUERY_STRING].sub "uuid=", ""
-      path = String ::Rails.root.join Dial::VERNIER_PROFILE_OUT_RELATIVE_DIRNAME, "#{uuid}.json"
+      path = String ::Rails.root.join Dial::VERNIER_PROFILE_OUT_RELATIVE_DIRNAME, "#{uuid}.json.gz"
 
       if File.exist? path
         [

data/lib/dial/middleware/panel.rb

@@ -91,7 +91,6 @@ module Dial
             flex-direction: column;
             padding: 0.5rem;
             font-size: 0.85rem;
-            color: black;
 
             #dial-preview {
               display: flex;
@@ -121,12 +120,17 @@ module Dial
 
             span {
               text-align: left;
+              color: black;
+            }
+
+            a {
+              color: blue;
             }
 
             hr {
               width: -moz-available;
               margin: 0.65rem 0 0 0;
-              background-color: black;
+              border-color: black;
             }
 
             details {
@@ -137,6 +141,7 @@ module Dial
             summary {
               margin: 0.25rem 0 0 0;
               cursor: pointer;
+              color: black;
             }
           }
         CSS
@@ -171,18 +176,18 @@ module Dial
         rescue ::ActionController::RoutingError
           {}
         end.then do |info|
-          "<b>Controller:</b> #{info[:controller] || "NA"} | <b>Action:</b> #{info[:action] || "NA"}"
+          "<b>Controller:</b> #{info[:controller] || "N/A"} | <b>Action:</b> #{info[:action] || "N/A"}"
         end
       end
 
       def formatted_request_timing env
-        "<b>Request timing:</b> #{env[REQUEST_TIMING_HEADER]}ms"
+        "<b>Request timing:</b> #{env[REQUEST_TIMING]}ms"
       end
 
       def formatted_profile_output env, profile_out_filename
         url_base = ::Rails.application.routes.url_helpers.dial_url host: env[::Rack::HTTP_HOST]
         prefix = "/" unless url_base.end_with? "/"
-        uuid = profile_out_filename.delete_suffix ".json"
+        uuid = profile_out_filename.delete_suffix ".json.gz"
         profile_out_url = URI.encode_www_form_component url_base + "#{prefix}dial/profile?uuid=#{uuid}"
 
         "<a href='https://vernier.prof/from-url/#{profile_out_url}' target='_blank'>View profile</a>"
@@ -206,7 +211,7 @@ module Dial
             .sort_by { |_, timing| -timing }
             .map { |event, timing| "<span><b>#{event}:</b> #{timing}</span>" }.join
         else
-          "NA"
+          "<span>N/A</span>"
         end
       end
 
@@ -224,7 +229,7 @@ module Dial
             HTML
           end.join
         else
-          "NA"
+          "<span>N/A</span>"
         end
       end
 

data/lib/dial/middleware.rb

@@ -17,15 +17,18 @@ module Dial
     end
 
     def call env
+      unless env[HTTP_ACCEPT]&.include? "text/html"
+        return @app.call env
+      end
+
       start_time = Process.clock_gettime Process::CLOCK_MONOTONIC
 
-      profile_out_filename = "#{Util.uuid}_vernier.json"
+      profile_out_filename = "#{Util.uuid}_vernier.json.gz"
       profile_out_pathname = "#{profile_out_dir_pathname}/#{profile_out_filename}"
 
-      status, headers, rack_body = nil
-      ruby_vm_stat, gc_stat, gc_stat_heap = nil
+      status, headers, rack_body, ruby_vm_stat, gc_stat, gc_stat_heap, vernier_result = nil
       ::Prosopite.scan do
-        ::Vernier.profile out: profile_out_pathname, interval: VERNIER_INTERVAL, allocation_interval: VERNIER_ALLOCATION_INTERVAL, hooks: [:memory_usage, :rails] do
+        vernier_result = ::Vernier.profile interval: VERNIER_INTERVAL, allocation_interval: VERNIER_ALLOCATION_INTERVAL, hooks: [:memory_usage, :rails] do
           ruby_vm_stat, gc_stat, gc_stat_heap = with_diffed_ruby_stats do
             status, headers, rack_body = @app.call env
           end
@@ -33,14 +36,15 @@ module Dial
       end
       server_timing = server_timing headers
 
-      unless headers[::Rack::CONTENT_TYPE]&.include? "text/html"
+      unless headers[CONTENT_TYPE]&.include? "text/html"
         return [status, headers, rack_body]
       end
 
+      write_vernier_result! vernier_result, profile_out_pathname
       query_logs = clear_query_logs!
 
       finish_time = Process.clock_gettime Process::CLOCK_MONOTONIC
-      env[REQUEST_TIMING_HEADER] = ((finish_time - start_time) * 1_000).round 2
+      env[REQUEST_TIMING] = ((finish_time - start_time) * 1_000).round 2
 
       body = String.new.tap do |str|
         rack_body.each { |chunk| str << chunk }
@@ -50,7 +54,7 @@ module Dial
         </body>
       HTML
 
-      headers[::Rack::CONTENT_LENGTH] = body.bytesize.to_s
+      headers[CONTENT_LENGTH] = body.bytesize.to_s
 
       [status, headers, [body]]
     end
@@ -69,6 +73,15 @@ module Dial
       ]
     end
 
+    def write_vernier_result! result, pathname
+      Thread.new do
+        Thread.current.name = "Dial::Middleware#write_vernier_result!"
+        Thread.current.report_on_exception = false
+
+        result.write out: pathname
+      end
+    end
+
     def clear_query_logs!
       [].tap do |query_logs|
         File.open("#{query_log_dir_pathname}/#{PROSOPITE_LOG_FILENAME}", "r+") do |file|

data/lib/dial/railtie.rb

@@ -19,7 +19,7 @@ module Dial
     end
 
     initializer "dial.clean_up_vernier_profile_out_files" do |app|
-      stale_files("#{profile_out_dir_pathname}/*.json").each do |profile_out_file|
+      stale_files("#{profile_out_dir_pathname}/*.json.gz").each do |profile_out_file|
         File.delete profile_out_file rescue nil
       end
     end

data/lib/dial/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dial
-  VERSION = "0.1.9"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dial
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Joshua Young
 bindir: bin
 cert_chain: []
-date: 2025-01-27 00:00:00.000000000 Z
+date: 2025-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties