dhl-get_quote 0.5.1 → 0.5.2

data/README.md

@@ -1,4 +1,5 @@
 [![Build Status](https://travis-ci.org/deseretbook/dhl-get_quote.png)](https://travis-ci.org/deseretbook/dhl-get_quote)
+[![Code Climate](https://codeclimate.com/github/deseretbook/dhl-get_quote.png)](https://codeclimate.com/github/deseretbook/dhl-get_quote)
 
 # Dhl::GetQuote
 
@@ -41,10 +42,10 @@ Or install it yourself as:
   r.from('US', 84010)
 
   r.pieces << Dhl::GetQuote::Piece.new(
-    :height => 20,
-    :weight => 20,
-    :width => 20,
-    :depth => 19
+    :height => 20.0,
+    :weight => 20.0,
+    :width => 20.0,
+    :depth => 19.0
   )
 
   response = r.post
@@ -196,15 +197,15 @@ To add items to the shipping quote request, generate a new Dhl::GetQuote::Piece
 
 ```ruby
   # minimal
-  request.pieces << Dhl::GetQuote::Piece.new( :weight => 20 )
+  request.pieces << Dhl::GetQuote::Piece.new( :weight => 20.0 )
 
   # more details
   request.pieces << Dhl::GetQuote::Piece.new(
-    :weight => 20, :height => 20, :width => 20, :depth => 19
+    :weight => 20.0, :height => 20.0, :width => 20.0, :depth => 19.0
   )
 ```
 
-Dhl::GetQuote::Piece requires *at least* :weight to be specified, and it must be a nonzero integer.  Optionally, you can provide :width, :depth and :height. The measurement options must all be added at once and cannot be added individually. They must be integers.
+Dhl::GetQuote::Piece requires *at least* :weight to be specified, and it must be a nonzero integer or float.  Optionally, you can provide :width, :depth and :height. The measurement options must all be added at once and cannot be added individually. They must be integers or floats.
 
 #### Posting to DHL
 

data/lib/dhl/get_quote/piece.rb

@@ -3,7 +3,7 @@ class Dhl::GetQuote::Piece
 
   def initialize(options = {})
     [ :width, :height, :depth, :weight ].each do |i|
-      options[i] = options[i].to_i if !!options[i]
+      options[i] = options[i].to_f if !!options[i]
     end
 
     if options[:weight] && options[:weight] > 0
@@ -14,8 +14,8 @@ class Dhl::GetQuote::Piece
 
     if options[:width] || options[:height] || options[:depth]
       [ :width, :height, :depth ].each do |req|
-        if options[req].to_i > 0
-          instance_variable_set("@#{req}", options[req].to_i)
+        if options[req].to_f > 0.0
+          instance_variable_set("@#{req}", options[req].to_f)
         else
           raise Dhl::GetQuote::OptionsError, required_option_error_message(req)
         end
@@ -54,6 +54,6 @@ eos
 private
 
   def required_option_error_message(field)
-    ":#{field} is a required for Dhl::GetQuote::Piece. Must be nonzero integer."
+    ":#{field} is a required for Dhl::GetQuote::Piece. Must be nonzero integer or float."
   end
 end

data/lib/dhl/get_quote/version.rb

@@ -1,6 +1,6 @@
 class Dhl
   class GetQuote
-    VERSION = "0.5.1"
+    VERSION = "0.5.2"
 
     PostInstallMessage = <<EOS
 
@@ -13,6 +13,10 @@ This version introduces the following changes from 0.4.x:
 
 * dutiable() replaces dutiable! now requires arguments (dutiable value and currency).
 
+This version introduces the following changes from 0.5.1:
+
+* Product.new() can accept weights and measures as float as well as by integer.
+
 EOS
   end
 end

data/spec/lib/dhl/get_quote/piece_spec.rb

@@ -72,10 +72,10 @@ describe Dhl::GetQuote::Piece do
       subject.to_xml.must == <<eos
 <Piece>
   <PieceID>1</PieceID>
-  <Height>1</Height>
-  <Depth>4</Depth>
-  <Width>3</Width>
-  <Weight>2</Weight>
+  <Height>1.0</Height>
+  <Depth>4.0</Depth>
+  <Width>3.0</Width>
+  <Weight>2.0</Weight>
 </Piece>
 eos
     end
@@ -85,7 +85,7 @@ eos
       dhl.to_xml.must == <<eos
 <Piece>
   <PieceID>1</PieceID>
-  <Weight>99</Weight>
+  <Weight>99.0</Weight>
 </Piece>
 eos
     end
@@ -96,7 +96,7 @@ eos
       dhl.to_xml.must == <<eos
 <Piece>
   <PieceID>88</PieceID>
-  <Weight>1</Weight>
+  <Weight>1.0</Weight>
 </Piece>
 eos
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dhl-get_quote
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-03 00:00:00.000000000 Z
+date: 2013-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -148,7 +148,7 @@ files:
 - lib/dhl/get_quote/request.rb
 - lib/dhl/get_quote/response.rb
 - lib/dhl/get_quote/version.rb
-- spec/lib/dhl/dh-get_quote_spec.rb
+- spec/lib/dhl/dhl-get_quote_spec.rb
 - spec/lib/dhl/get_quote/market_service_spec.rb
 - spec/lib/dhl/get_quote/piece_spec.rb
 - spec/lib/dhl/get_quote/request_spec.rb
@@ -160,7 +160,9 @@ licenses: []
 post_install_message: ! "\n*** NOTE Dhl-GetQuote ***\n\nThis version introduces the
   following changes from 0.4.x:\n\n* #inches!, #pounds!, #kilograms! and #centimeters
   have been depricated.\n  Please use #us_measurements! or #metric_measurements!.\n\n*
-  dutiable() replaces dutiable! now requires arguments (dutiable value and currency).\n\n"
+  dutiable() replaces dutiable! now requires arguments (dutiable value and currency).\n\nThis
+  version introduces the following changes from 0.5.1:\n\n* Product.new() can accept
+  weights and measures as float as well as by integer.\n\n"
 rdoc_options: []
 require_paths:
 - lib
@@ -183,7 +185,7 @@ signing_key:
 specification_version: 3
 summary: Gem to interface with DHL's XML-PI shipping quote service.
 test_files:
-- spec/lib/dhl/dh-get_quote_spec.rb
+- spec/lib/dhl/dhl-get_quote_spec.rb
 - spec/lib/dhl/get_quote/market_service_spec.rb
 - spec/lib/dhl/get_quote/piece_spec.rb
 - spec/lib/dhl/get_quote/request_spec.rb