dhl-bcs 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de9c80a9486c4d7c02e9c2f08bce20e4519297b65a7e56e45292b6d81da1b7d1
-  data.tar.gz: df4f7998310675845b3033b38f4e4e82985361491b84a827cb3a21c841ecadd7
+  metadata.gz: 99dd25ad1a742a8726594746c03ec739238f0dbde358fd100bddf87204c42cb6
+  data.tar.gz: 98d402939ab3d9dcff91f433613dd54887912fc5a65fa8434b7332390b60c463
 SHA512:
-  metadata.gz: 6df55ab919ded0e7388011f21dccce2f19a2c27eba6f641e5f34b325b8f33046281be1131bcdebf3586a64396b4b9e6198c45e77fa498660800f9ea29766b70d
-  data.tar.gz: 42e880a8ea72c3c7cedeadc5fa1292831e5ae24b021aa66b208e62efadbe017c61504d64286bdea044a36340a54ac67fcb4aff7329f49a726af7cac3784b4b88
+  metadata.gz: df164db19806cce7b8ecebcbc9ccb3d234280eaa7ee7e0fcea867785addb58deab6ac362beea500fd16965201898cdde49329d15bad54ba4e966cf44c7c393dd
+  data.tar.gz: fdc4e23269be4df34b440fc6e8a6644620e0eb6deb74282c705e04c149f57c5982f4d70cd1d6ada8e440aa0c5d8a633e6ffe37effc853ad491c2e77a4e50fbdd

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/Gemfile.lock

@@ -0,0 +1,73 @@
+PATH
+  remote: .
+  specs:
+    dhl-bcs (0.3.0)
+      savon (~> 2.12)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    akami (1.3.1)
+      gyoku (>= 0.4.0)
+      nokogiri
+    builder (3.2.4)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    crack (0.4.5)
+      rexml
+    gyoku (1.4.0)
+      builder (>= 2.1.2)
+      rexml (~> 3.0)
+    hashdiff (1.0.1)
+    httpi (2.5.0)
+      rack
+      socksify
+    method_source (1.0.0)
+    minitest (5.15.0)
+    nokogiri (1.13.10-x86_64-linux)
+      racc (~> 1.4)
+    nori (2.6.0)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.7)
+    racc (1.6.1)
+    rack (3.0.4.2)
+    rake (13.0.6)
+    rexml (3.2.5)
+    savon (2.12.1)
+      akami (~> 1.2)
+      builder (>= 2.1.2)
+      gyoku (~> 1.2)
+      httpi (~> 2.3)
+      nokogiri (>= 1.8.1)
+      nori (~> 2.4)
+      wasabi (~> 3.4)
+    socksify (1.7.1)
+    wasabi (3.7.0)
+      addressable
+      httpi (~> 2.0)
+      nokogiri (>= 1.4.2)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+
+PLATFORMS
+  x86_64-linux
+
+DEPENDENCIES
+  bundler (~> 2.3)
+  dhl-bcs!
+  minitest (~> 5.15)
+  pry-byebug (~> 3.9)
+  rake (~> 13.0)
+  webmock (~> 3.14)
+
+BUNDLED WITH
+   2.3.4

data/dhl-bcs.gemspec

@@ -21,9 +21,9 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "savon", "~> 2.12"
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 12.3"
-  spec.add_development_dependency "minitest", "~> 5.11"
-  spec.add_development_dependency "webmock", "~> 3.3"
-  spec.add_development_dependency "pry-byebug", "~> 3.6"
+  spec.add_development_dependency "bundler", "~> 2.3"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "minitest", "~> 5.15"
+  spec.add_development_dependency "webmock", "~> 3.14"
+  spec.add_development_dependency "pry-byebug", "~> 3.9"
 end

data/lib/dhl/bcs/v2/buildable.rb

@@ -6,7 +6,7 @@ module Dhl::Bcs::V2
     end
 
     module ClassMethods
-      def build(attributes)
+      def build(**attributes)
         attrib = attributes[underscore(name.split('::').last).to_sym]
         if attrib.is_a?(self)
           attrib
@@ -16,9 +16,9 @@ module Dhl::Bcs::V2
             value = attributes.delete(prop)
             klass_attributes[prop] = value if value
           end
-          new(klass_attributes)
+          new(**klass_attributes)
         elsif attrib.is_a?(Hash)
-          new(attrib)
+          new(**attrib)
         end
       end
 

data/lib/dhl/bcs/v2/client.rb

@@ -50,7 +50,7 @@ module Dhl::Bcs::V2
     end
 
     def validate_shipment(*shipments, **options)
-      request(:validate_shipment, build_shipment_orders(shipments, options)) do |response|
+      request(:validate_shipment, build_shipment_orders(shipments, **options)) do |response|
         [response.body[:validate_shipment_response][:validation_state]].flatten.map do |validation_state|
           validation_state[:status]
         end
@@ -58,7 +58,7 @@ module Dhl::Bcs::V2
     end
 
     def create_shipment_order(*shipments, **options)
-      request(:create_shipment_order, build_shipment_orders(shipments, options)) do |response|
+      request(:create_shipment_order, build_shipment_orders(shipments, **options)) do |response|
         [response.body[:create_shipment_order_response][:creation_state]].flatten.map do |creation_state|
           creation_state[:label_data]
         end
@@ -66,7 +66,7 @@ module Dhl::Bcs::V2
     end
 
     def update_shipment_order(shipment_number, shipment, **options)
-      request(:update_shipment_order, { 'cis:shipmentNumber' => shipment_number }.merge(build_shipment_orders([shipment], options))) do |response|
+      request(:update_shipment_order, { 'cis:shipmentNumber' => shipment_number }.merge(build_shipment_orders([shipment], **options))) do |response|
         clean_response_data(response.body[:update_shipment_order_response][:label_data])
       end
     end

data/lib/dhl/bcs/v2/export_document.rb

@@ -2,8 +2,11 @@ module Dhl::Bcs::V2
   class ExportDocument
     include Buildable
 
-    PROPERTIES = %i(invoice_number export_type export_type_description terms_of_trade place_of_commital additional_fee permit_number attestation_number with_electronic_export_notification export_doc_positions).freeze
-    attr_accessor(*PROPERTIES)
+    ACCESSOR_PROPERTIES = %i[invoice_number export_type_description place_of_commital additional_fee permit_number attestation_number with_electronic_export_notification export_doc_positions].freeze
+    READER_PROPERTIES = %i[export_type terms_of_trade]
+    PROPERTIES = (ACCESSOR_PROPERTIES + READER_PROPERTIES).freeze
+    attr_accessor(*ACCESSOR_PROPERTIES)
+    attr_reader(*READER_PROPERTIES)
 
     EXPORT_TYPES = %w(OTHER PRESENT COMMERCIAL_SAMPLE DOCUMENT RETURN_OF_GOODS).freeze
     TERMS_OF_TRADES = %w(DDP DXV DDU DDX).freeze
@@ -11,9 +14,9 @@ module Dhl::Bcs::V2
     def self.build(export_doc_positions = [], **attributes)
       array_of_export_doc_positions = []
       export_doc_positions.each do |export_doc_position|
-        array_of_export_doc_positions << ExportDocPosition.build(export_doc_position) if export_doc_position.is_a?(Hash)
+        array_of_export_doc_positions << ExportDocPosition.build(**export_doc_position) if export_doc_position.is_a?(Hash)
       end
-      new({ export_doc_positions: array_of_export_doc_positions }.merge(attributes))
+      new(**{ export_doc_positions: array_of_export_doc_positions }.merge(attributes))
     end
 
     def initialize(**attributes)

data/lib/dhl/bcs/v2/locator.rb

@@ -2,12 +2,12 @@ module Dhl::Bcs::V2
   # finds proper class from attributes and builds object
   class Locator
 
-    def self.for(attributes = {})
-      location_class = location_class_finder(attributes)
+    def self.for(**attributes)
+      location_class = location_class_finder(**attributes)
       location_builder(attributes, location_class: location_class)
     end
 
-    def self.location_class_finder(attributes)
+    def self.location_class_finder(**attributes)
       if attributes.key?(:packstation_number)
         Packstation
       elsif attributes.key?(:postfilial_number)
@@ -20,7 +20,7 @@ module Dhl::Bcs::V2
     end
 
     def self.location_builder(attributes = {}, location_class: Address)
-      location_class.build(attributes)
+      location_class.build(**attributes)
     end
 
   end

data/lib/dhl/bcs/v2/receiver.rb

@@ -7,9 +7,9 @@ module Dhl::Bcs::V2
     attr_accessor(*PROPERTIES)
 
     def self.build(name: nil, **attributes)
-      communication = Communication.build(attributes)
-      location = Locator.for(attributes)
-      new(attributes.merge(name: name, communication: communication, location: location))
+      communication = Communication.build(**attributes)
+      location = Locator.for(**attributes)
+      new(**attributes.merge(name: name, communication: communication, location: location))
     end
 
     def initialize(**attributes)

data/lib/dhl/bcs/v2/shipment.rb

@@ -23,14 +23,14 @@ module Dhl::Bcs::V2
 
     # build a shipment from hash data
     def self.build(shipper:, receiver:, bank_data: nil, export_document: nil, **shipment_attributes)
-      shipper = Shipper.build(shipper) if shipper.is_a?(Hash)
-      receiver = Receiver.build(receiver) if receiver.is_a?(Hash)
-      bank_data = BankData.build(bank_data) if bank_data.is_a?(Hash)
-      export_document = ExportDocument.build(export_document.delete(:export_doc_positions),export_document) if export_document.is_a?(Hash)
-      new({ shipper: shipper, receiver: receiver, bank_data: bank_data, export_document: export_document }.merge(shipment_attributes))
+      shipper = Shipper.build(**shipper) if shipper.is_a?(Hash)
+      receiver = Receiver.build(**receiver) if receiver.is_a?(Hash)
+      bank_data = BankData.build(**bank_data) if bank_data.is_a?(Hash)
+      export_document = ExportDocument.build(export_document.delete(:export_doc_positions), **export_document) if export_document.is_a?(Hash)
+      new(**{ shipper: shipper, receiver: receiver, bank_data: bank_data, export_document: export_document }.merge(shipment_attributes))
     end
 
-    def initialize(attributes = {})
+    def initialize(**attributes)
       assign_attributes(
         {
           product: 'V01PAK',

data/lib/dhl/bcs/v2/shipper.rb

@@ -6,9 +6,9 @@ module Dhl::Bcs::V2
     attr_accessor(*PROPERTIES)
 
     def self.build(company: nil, **attributes)
-      address = Address.build(attributes)
-      communication = Communication.build(attributes)
-      new(attributes.merge(address: address, communication: communication, company: company))
+      address = Address.build(**attributes)
+      communication = Communication.build(**attributes)
+      new(**attributes.merge(address: address, communication: communication, company: company))
     end
 
     def initialize(**attributes)

data/lib/dhl/bcs/version.rb

@@ -1,5 +1,5 @@
 module Dhl
   module Bcs
-    VERSION = "0.3.0"
+    VERSION = "0.4.0"
   end
 end

data/lib/dhl/bcs.rb

@@ -19,24 +19,24 @@ require 'dhl/bcs/v2/export_document'
 module Dhl
   module Bcs
 
-    def self.client(config, options = {})
-      V2::Client.new(config, options)
+    def self.client(config, **options)
+      V2::Client.new(config, **options)
     end
 
-    def self.build_shipment(*args)
-      V2::Shipment.build(*args)
+    def self.build_shipment(**opts)
+      V2::Shipment.build(**opts)
     end
 
-    def self.build_shipper(*args)
-      V2::Shipper.build(*args)
+    def self.build_shipper(**opts)
+      V2::Shipper.build(**opts)
     end
 
-    def self.build_receiver(*args)
-      V2::Receiver.build(*args)
+    def self.build_receiver(**opts)
+      V2::Receiver.build(**opts)
     end
 
-    def self.build_service(*args)
-      V2::Service.new(*args)
+    def self.build_service(**opts)
+      V2::Service.new(**opts)
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dhl-bcs
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Christoph Wagner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-06-18 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -30,70 +30,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.15'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.14'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '3.9'
 description: This is inspired by the dhl-intraship gem that is a little bit outdated
   and doesn't support the new DHL API. If you need DHL Express Services this is not
   for you.
@@ -109,6 +109,7 @@ files:
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -137,7 +138,7 @@ homepage: https://github.com/webit-de/dhl-bcs
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -152,9 +153,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Client for DHL Business-Customer-Shipping SOAP API 2.0
 test_files: []