dhl-bcs 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0edf9d48f49c8c00bd677e058a1b9a81728dbbf1
-  data.tar.gz: ae7cd220247f3b37aae0604d30ce3bb01acdbd16
+  metadata.gz: 266d8258d3a8678be51463d1148afd001473943e
+  data.tar.gz: a9feb88be17f8acf306b66363fc869aae592f919
 SHA512:
-  metadata.gz: 726e19231bda1db3dc47835ac20c9d95bc68f3fac5a29140fdc456f741c76ee767a156b8dde6b705f25510f534159f1fb2bf16d04435962c372ae73b1c48c3b7
-  data.tar.gz: d358004816955f652956f13756b46fca01dd73e4217dd38f1362f9e04e6b825f2fd04839a6bf90e23071cd7b0c04532a7d1904832b539d8706946de0c979b289
+  metadata.gz: c5863fa920acf37223595ef5c16b5f779e2b2505f91abc9c6895d1abc895a020c85d18ac8023ab76a853ed11402bd3d65c1b0d82320bc9cdcfbabde5e7fe8f6f
+  data.tar.gz: 314a2e6fe4ecebbb1a47f933ac82af1d8b102bb82852906f9de2ea06be728e3e67a38d5f02253896fbbc18de489e299542d3dadc6eb577a160772848d04248f1

data/.gitignore

@@ -7,6 +7,7 @@
 /pkg/
 /spec/reports/
 /tmp/
+/*.gem
 
 /TAGS
 /tags

data/README.md

@@ -38,7 +38,7 @@ config = {
   user: 'your BCS user name', #mandatory
   signature: 'Your BCS user password', #mandatory
   ekp: 'Your DHL EKP (first part of your DHL Account number)', #mandatory
-  participation_number: 'Your DHL EKP (last two characters of your DHL Account number)' #mandatory
+  participation_number: 'Your DHL participation_number (last two characters of your DHL Account number)' #mandatory
 }
 ```
 
@@ -51,6 +51,25 @@ options = {
 }
 ```
 
+### Where do I get all these numbers?
+If you are confused about all the number and credential stuff here is a short explanation.
+
+DHL uses a customer integration gateway (cig) for its services.
+You have to register your app first at the developer portal of dhl, define an app_id and get a token for that.
+`api_user` is your app_id and `api_pwd` is the token you get.
+This is basically needed to communicate with the DHL services.
+
+To identify as a BCS user you have to give your credentials of the BCS website as `user` and `signature`.
+
+The billing works with a number (Abrechnungsnummer) with 14 chars that consists of three parts.
+The first 10 digits are your EKP (Einheitliche Kunden- und Produktnummer) that you get from your DHL contract.
+
+The next 2 digits are product dependent (Verfahren), so you don't have to specify it, because they are known if you specify a product at the shipment.
+
+The last 2 chars, the participation_number (Teilnahme-Nummer) can be digits or uppercase characters.
+This is contract dependent and used to specify billing conditions.
+
+
 ### Create shipments
 
 To create a shipment at DHL you need a sender_address, a receiver_address, and informations about the parcel.

data/dhl-bcs.gemspec

@@ -21,9 +21,9 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "savon", "~> 2.11"
 
-  spec.add_development_dependency "bundler", "~> 1.12"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
-  spec.add_development_dependency "webmock", "~> 2.1"
+  spec.add_development_dependency "bundler", "~> 1.15"
+  spec.add_development_dependency "rake", "~> 12.0"
+  spec.add_development_dependency "minitest", "~> 5.10"
+  spec.add_development_dependency "webmock", "~> 3.0"
   spec.add_development_dependency "pry-byebug", "~> 3.4"
 end

data/lib/dhl/bcs/v2/client.rb

@@ -19,7 +19,7 @@ module Dhl::Bcs::V2
       @participation_number = config[:participation_number]
 
       @logIO = StringIO.new
-      @logger = Logger.new($stdout) if log
+      @logger = log && Logger.new($stdout)
 
       @client = Savon.client({
         endpoint: (test ? 'https://cig.dhl.de/services/sandbox/soap' : 'https://cig.dhl.de/services/production/soap'),

data/lib/dhl/bcs/v2/shipment.rb

@@ -43,18 +43,18 @@ module Dhl::Bcs::V2
     end
 
     def product=(product)
-      raise Error, "No valid product code #{product}. Please use one of these: #{PRODUCTS.join(', ')}" unless PRODUCTS.include?(product)
+      raise Dhl::Bcs::Error, "No valid product code #{product}. Please use one of these: #{PRODUCTS.join(', ')}" unless PRODUCTS.include?(product)
       @product = product
     end
 
     def to_soap_hash(ekp, participation_number)
-      raise Error, 'Packing weight in kilo must be set!' unless weight
-      raise Error, 'Sender address must be set!' unless shipper
-      raise Error, 'Receiver address must be set!' unless receiver
-      raise Error, 'Product must be set!' unless product
+      raise Dhl::Bcs::Error, 'Packing weight in kilo must be set!' unless weight
+      raise Dhl::Bcs::Error, 'Sender address must be set!' unless shipper
+      raise Dhl::Bcs::Error, 'Receiver address must be set!' unless receiver
+      raise Dhl::Bcs::Error, 'Product must be set!' unless product
 
       account_number = "#{ekp}#{PRODUCT_PROCEDURE_NUMBERS[product]}#{participation_number}"
-      raise Error, 'Need a 14 character long account number. Check EKP and participation_number' if account_number.size != 14
+      raise Dhl::Bcs::Error, 'Need a 14 character long account number. Check EKP and participation_number' if account_number.size != 14
       {
         'ShipmentDetails' => {}.tap { |h|
           h['product'] = product

data/lib/dhl/bcs/version.rb

@@ -1,5 +1,5 @@
 module Dhl
   module Bcs
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dhl-bcs
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Christoph Wagner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-08 00:00:00.000000000 Z
+date: 2017-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -30,56 +30,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.15'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.10'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Client for DHL Business-Customer-Shipping SOAP API 2.0