devpack 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9502f5bb5412be236b272450cf30b9410a37676ce9a8ff7a769e01e08ebedc0f
-  data.tar.gz: f96bfcfbd97d530ee6a93ff54a8fef02066e5206c468d50d0ef0e4e8501055bc
+  metadata.gz: 9d17e8b2f27d6bf6dc15ff37e549e3f97a3550339daa6fba5db14174483c2197
+  data.tar.gz: e85c8dc654ae6fdf89c24ebaff90f0a14d2ae67b802b33a25430dde625c72a4b
 SHA512:
-  metadata.gz: b94fee5740d2a0a57db65fdb9533d63397f0a1200babc95ea48104789084eab958570d0e659ba76cae1bbfc65e00839ab822ba9ebe300e8edc66d7490d28f266
-  data.tar.gz: 8d05d1b3839e26b658357613fa6f5a3f2c2251aa939aa6ac68b509cc9733530dddf21024933c11b84e52894bd48c7290fc713307b1e1882c04bd1d0b477d7eb6
+  metadata.gz: 6095f9fe4d862df8a9a50ceccc1de6415f95a3e7a6749fd10076ff05e22244f343364e23231bb0270af7a1d0b9c02b5e627b82f49775c1cfa95cea10dc3f3c58
+  data.tar.gz: 79363c38a26853e07ef07ae3675ab867ce1d16bc52f1e31f6489ab1fd33e7cc09a45121a588c0b645a72a93c0adf1a0e5dfceb34424f0f1e5398d628e79f879e

data/README.md

@@ -8,7 +8,7 @@ Add the gem to your `Gemfile`:
 
 ```ruby
 group :development, :test do
-  gem 'devpack', '~> 0.2.1'
+  gem 'devpack', '~> 0.3.0'
 end
 ```
 
@@ -41,6 +41,8 @@ require 'devpack'
 
 Any gems that fail to load (due to `LoadError`) will generate a warning.
 
+All dependencies are recursively verified for compatibily before loading. If no compatible version can be located then the gem will not be loaded.
+
 It is recommended that `.devpack` is added to your `.gitignore`.
 
 ### Initializers

data/lib/devpack.rb

@@ -2,6 +2,7 @@
 
 require 'rubygems'
 require 'pathname'
+require 'set'
 
 require 'devpack/timeable'
 require 'devpack/config'

data/lib/devpack/gem_glob.rb

@@ -4,7 +4,9 @@ module Devpack
   # Locates gems by searching in paths listed in GEM_PATH
   class GemGlob
     def find(name)
-      matched_paths(name).max { |a, b| version(a) <=> version(b) }
+      matched_paths(name)
+        .sort { |a, b| version(a) <=> version(b) }
+        .reverse
     end
 
     private

data/lib/devpack/gem_spec.rb

@@ -4,30 +4,68 @@ module Devpack
   # Locates relevant gemspec for a given gem and provides a full list of paths
   # for all `require_paths` listed in gemspec.
   class GemSpec
-    def initialize(glob, name)
+    def initialize(glob, name, requirement)
       @name = name
       @glob = glob
+      @requirement = requirement
+      @dependency = Gem::Dependency.new(@name, @requirement)
     end
 
     def require_paths(visited = Set.new)
-      return [] unless gemspec_path&.exist? && gem_path&.exist?
+      raise LoadError, Messages.no_compatible_version(@dependency) if gemspec.nil?
 
-      (immediate_require_paths + dependency_require_paths(visited))
-        .compact.flatten.uniq
+      (immediate_require_paths + dependency_require_paths(visited)).compact.flatten.uniq
     end
 
     def gemspec
-      @gemspec ||= Gem::Specification.load(gemspec_path.to_s)
+      @gemspec ||= gemspecs.find do |spec|
+        next false if spec.nil?
+
+        @dependency.requirement.satisfied_by?(spec.version) && compatible?(spec)
+      end
     end
 
     private
 
+    def compatible?(spec)
+      return false if spec.nil?
+      return false if incompatible_version_loaded?(spec)
+
+      compatible_specs?(Gem.loaded_specs.values, [@dependency] + spec.runtime_dependencies)
+    end
+
+    def incompatible_version_loaded?(spec)
+      matched = Gem.loaded_specs[spec.name]
+      return false if matched.nil?
+
+      matched.version != spec.version
+    end
+
+    def compatible_specs?(specs, dependencies)
+      specs.all? { |spec| compatible_dependencies?(dependencies, spec) }
+    end
+
+    def compatible_dependencies?(dependencies, spec)
+      dependencies.all? { |dependency| compatible_dependency?(dependency, spec) }
+    end
+
+    def compatible_dependency?(dependency, spec)
+      return false if spec.nil?
+      return true unless dependency.name == spec.name
+
+      dependency.requirement.satisfied_by?(spec.version)
+    end
+
+    def gemspecs
+      @gemspecs ||= gemspec_paths.map { |path| Gem::Specification.load(path.to_s) }
+    end
+
     def dependency_require_paths(visited)
       dependencies.map do |dependency|
         next nil if visited.include?(dependency)
 
         visited << dependency
-        GemSpec.new(@glob, name_with_version(dependency)).require_paths(visited)
+        GemSpec.new(@glob, dependency.name, dependency.requirement).require_paths(visited)
       end
     end
 
@@ -35,34 +73,28 @@ module Devpack
       gemspec.runtime_dependencies
     end
 
-    def gem_path
-      return nil if located_gem.nil?
+    def gem_paths
+      return nil if candidates.empty?
 
-      Pathname.new(located_gem)
+      candidates.map { |candidate| Pathname.new(candidate) }
     end
 
-    def gemspec_path
-      return nil if gem_path.nil?
+    def gemspec_paths
+      return [] if gem_paths.nil?
 
-      gem_path.join('..', '..', 'specifications', "#{gem_path.basename}.gemspec")
-              .expand_path
+      gem_paths.map do |path|
+        path.join('..', '..', 'specifications', "#{path.basename}.gemspec").expand_path
+      end
     end
 
     def immediate_require_paths
       gemspec
         .require_paths
-        .map { |path| gem_path.join(path).to_s }
-    end
-
-    def name_with_version(dependency)
-      spec = dependency.to_spec
-      "#{spec.name}:#{spec.version}"
-    rescue Gem::MissingSpecError
-      dependency.name
+        .map { |path| File.join(gemspec.full_gem_path, path) }
     end
 
-    def located_gem
-      @located_gem ||= @glob.find(@name)
+    def candidates
+      @candidates ||= @glob.find(@name)
     end
   end
 end

data/lib/devpack/gems.rb

@@ -5,8 +5,9 @@ module Devpack
   class Gems
     include Timeable
 
-    def initialize(config)
+    def initialize(config, glob = GemGlob.new)
       @config = config
+      @gem_glob = glob
     end
 
     def load
@@ -21,18 +22,21 @@ module Devpack
     private
 
     def load_devpack
-      @config.requested_gems.map { |name| load_gem(name) }.compact
+      @config.requested_gems.map do |requested|
+        name, _, version = requested.partition(':')
+        load_gem(name, version.empty? ? nil : Gem::Requirement.new("= #{version}"))
+      end.compact
     end
 
-    def load_gem(name)
-      [name, activate(name)]
+    def load_gem(name, requirement)
+      [name, activate(name, requirement)]
     rescue LoadError => e
       warn(Messages.failure(name, load_error_message(e)))
       nil
     end
 
-    def activate(name)
-      spec = GemSpec.new(gem_glob, name)
+    def activate(name, version)
+      spec = GemSpec.new(@gem_glob, name, version)
       update_load_path(spec.require_paths)
       loaded = Kernel.require(name)
       Gem.loaded_specs[name] = spec.gemspec
@@ -51,10 +55,6 @@ module Devpack
       %[(#{error.message})\n#{error.backtrace.join("\n")}]
     end
 
-    def gem_glob
-      @gem_glob ||= GemGlob.new
-    end
-
     def update_load_path(paths)
       $LOAD_PATH.concat(paths)
     end

data/lib/devpack/messages.rb

@@ -6,8 +6,7 @@ module Devpack
     class << self
       def failure(name, error_message)
         base = "Failed to load `#{name}`"
-        install = "bundle exec gem install #{name}"
-        "#{base}. Try `#{install}` #{error_message}"
+        "#{base}. #{error_message}"
       end
 
       def initializer_failure(path, error_message)
@@ -26,6 +25,10 @@ module Devpack
         "Loaded #{initializers.compact.size} initializer(s) from '#{path}' in #{time} seconds"
       end
 
+      def no_compatible_version(dependency)
+        "No compatible version found for `#{dependency.requirement}`"
+      end
+
       private
 
       def indented(message)

data/lib/devpack/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Devpack
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devpack
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Bob Farrell
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-03 00:00:00.000000000 Z
+date: 2020-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -117,7 +117,7 @@ metadata:
   homepage_uri: https://github.com/bobf/devpack
   source_code_uri: https://github.com/bobf/devpack
   changelog_uri: https://github.com/bobf/devpack/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -133,7 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Conveniently tailor your development environment
 test_files: []