devpack 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ec75af91bddba1020bdc23508c881dfc9da92c5c0a69793935c1839d699139e
-  data.tar.gz: 7751b678c8a59010a8a5160a108e3c0c672d37104ca44e41c8f4d0c2c6ec280c
+  metadata.gz: 57a7f13b41361d7f9c45a147a99221d6f88e3b8d0ee1ede4f59ccdaeb878c7e8
+  data.tar.gz: 5e631a6efa73d770ecafcb8b55278240f83f4ffb58702fbc7c6f48cd101e45ef
 SHA512:
-  metadata.gz: '09208ee73b785fbf9c67ad5375ab672e15241bf561216e27cab3db7292d0e7f2ed198d0cf159f544acaef4cd6241f9ed1f0e9e44beb31b1fef236f8ccd47fe36'
-  data.tar.gz: e4301ef053caf42a34463f9ffc1f816d6203144d36e9920c21895d92cbb17354c27b90716c1e5177b878d0d4cae73b6523a7e2e2f96db3643be6164144d68ccb
+  metadata.gz: 057fcdb72061f64c1fd330722e958eb2680936756b861fb1d6777878e860cda2a645d050721e2d29f9518a2057bfaaf386d5d166938c9c4de1cb498cee83dd1e
+  data.tar.gz: 5f145c0cac07ae44eb0375aa62d68cf12bf0d1966d353eed205857f5e9d5d69ebe13387df2c44fd0b8914fc7ab34bbe9572e1192908df5452d2337f75ff1aa09

data/CHANGELOG.md

@@ -21,3 +21,9 @@ Use `Gem::Specification` to load "rendered" gemspec (i.e. the file created by ru
 Recursively include gem dependencies in `$LOAD_PATH` rather than assuming that any dependencies are already loaded.
 
 Include original error message when warning that a gem was unable to be loaded.
+
+## 0.1.3
+
+Use a more appropriate method of identifying the latest version of a gem (use `Gem::Version` to sort matched gem paths).
+
+Fix edge case where e.g. `pry-rails-0.1.0` was matching for `pry` due to naive match logic. Split on last dash instead of first (i.e. don't assume gems will not have a dash in their name; last dash separates gem name from version in directory name).

data/README.md

@@ -8,7 +8,7 @@ Add the gem to your `Gemfile`:
 
 ```ruby
 group :development, :test do
-  gem 'devpack', '~> 0.1.2'
+  gem 'devpack', '~> 0.1.3'
 end
 ```
 

data/lib/devpack/gem_glob.rb

@@ -4,13 +4,7 @@ module Devpack
   # Locates gems by searching in paths listed in GEM_PATH
   class GemGlob
     def find(name)
-      glob.select do |path|
-        pathname = Pathname.new(path)
-        next unless pathname.directory?
-
-        basename = pathname.basename.to_s
-        match?(name, basename)
-      end.max # FIXME: Quick-and-dirty way to get latest version - will have many edge cases.
+      matched_paths(name).max { |a, b| version(a) <=> version(b) }
     end
 
     private
@@ -27,10 +21,24 @@ module Devpack
 
     def match?(name_with_version, basename)
       name, _, version = name_with_version.partition(':')
-      return true if version.empty? && basename.start_with?("#{name}-")
+      return true if version.empty? && basename.rpartition('-').first == name
       return true if !version.empty? && basename == "#{name}-#{version}"
 
       false
     end
+
+    def matched_paths(name)
+      glob.select do |path|
+        pathname = Pathname.new(path)
+        next unless pathname.directory?
+
+        basename = pathname.basename.to_s
+        match?(name, basename)
+      end
+    end
+
+    def version(path)
+      Gem::Version.new(File.split(path).last.rpartition('-').last)
+    end
   end
 end

data/lib/devpack/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Devpack
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devpack
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Bob Farrell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-20 00:00:00.000000000 Z
+date: 2020-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug