devise_custom_authenticatable 0.2.0 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 5dc5774c65c328dcfa617054bf761c78e0d5d9c0
+  data.tar.gz: db9eae55f8650c0a47af5e5f33b567d32c66ff57
+SHA512:
+  metadata.gz: b33d874f8bc81ac725729af24354da1f687a3be9334407c41d1a71fa7397edcc162dd3bc4d9a46e63e4885ad8cd2883f1f5426b18529a1e39772fc7eae155543
+  data.tar.gz: 0593a3a5f6848671f483ba07d55162e4a4d7ebdd0148d77b048938cd3e22b9821058b0e7f76aeab6d70ce3175fa112e7d499ac9fb97ae4ab3bbd97ed5aa19449

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+examples.txt

data/.rspec

@@ -1 +1,2 @@
 --color
+--require spec_helper

data/.travis.yml

@@ -2,6 +2,9 @@ language: ruby
 script: "bundle exec rspec spec"
 rvm:
   - 1.9.3
-  - 2.0.0
-  - 2.1.0
-  - jruby
+  - 2.3.1
+  - jruby-1.7.26
+  - jruby-9.1.5.0
+
+sudo: false
+cache: bundler

data/CHANGELOG.md

@@ -18,3 +18,7 @@
 
 * Feature: fail authentication if `#valid_for_custom_authentication?` returns false (use `#skip_custom_strategies` in order to pass to another stategy)
 * Feature: `#after_custom_authentication` method added
+
+## v0.3.0
+
+* works with devise 4.2

data/devise_custom_authenticatable.gemspec

@@ -18,10 +18,20 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
 
-  spec.add_dependency "devise", ">= 2", "< 4"
 
+  if defined?(RUBY_VERSION) && RUBY_VERSION >= "2.1" || defined?(JRUBY_VERSION) && JRUBY_VERSION >= "9000"
+    spec.add_development_dependency "activemodel", ">= 3.1"
+
+    spec.add_dependency "devise", ">= 2", "< 5"
+  else
+    spec.add_development_dependency "activemodel", "< 5"
+    spec.add_development_dependency "activesupport", "< 5"
+    spec.add_development_dependency "rack", "~> 1.6.4"
+
+    spec.add_dependency "devise", ">= 2", "< 4"
+  end
 end

data/lib/devise/strategies/custom_authenticatable.rb

@@ -1,7 +1,7 @@
 require 'devise/strategies/authenticatable'
 
 module Devise::Strategies
-  # Strategy for delegateing authentication logic to custom model's method
+  # Strategy for delegating authentication logic to custom model's method
   class CustomAuthenticatable < Authenticatable
 
     def authenticate!

data/lib/devise_custom_authenticatable/version.rb

@@ -1,3 +1,3 @@
 module DeviseCustomAuthenticatable
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/devise/models/custom_authenticatable_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe Devise::Models::CustomAuthenticatable do
+RSpec.describe Devise::Models::CustomAuthenticatable do
   before(:each) do
     @it = CustomAuthenticatableTestClass.new
   end
@@ -12,8 +10,8 @@ describe Devise::Models::CustomAuthenticatable do
 
   describe "#authenticated_by_any_custom_strategy? helper" do
     before(:each) do
-      @it.stub(authenticated_by_test1_strategy?: true)
-      @it.stub(authenticated_by_test2_strategy?: true)
+      allow(@it).to receive(:authenticated_by_test1_strategy?).and_return(true)
+      allow(@it).to receive(:authenticated_by_test2_strategy?).and_return(true)
     end
 
     context "should call all given strategy methods and" do
@@ -21,18 +19,18 @@ describe Devise::Models::CustomAuthenticatable do
         expect(@it).to receive(:authenticated_by_test1_strategy?).with('password').and_return(false)
         expect(@it).to receive(:authenticated_by_test2_strategy?).and_return(false)
 
-        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_false
+        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_falsey
       end
 
       it "return true if any of them return true" do
         expect(@it).to receive(:authenticated_by_test1_strategy?).with('password').and_return(false)
         expect(@it).to receive(:authenticated_by_test2_strategy?).and_return(true)
 
-        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_true
+        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_truthy
       end
 
       it "return true if all of them return true" do
-        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_true
+        expect(@it.authenticated_by_any_custom_strategy?('password', :test1, :test2)).to be_truthy
       end
     end
   end

data/spec/devise/strategies/custom_authenticatable_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe Devise::Models::CustomAuthenticatable do
+RSpec.describe Devise::Models::CustomAuthenticatable do
   before(:each) do
     @resource = CustomAuthenticatableTestClass.new
     @it = Devise::Strategies::CustomAuthenticatable.new(env_with_params, :user)
@@ -8,17 +6,19 @@ describe Devise::Models::CustomAuthenticatable do
 
   describe "#authenticate!" do
     before(:each) do
-      password_hash = { password: 'password' }
-      @it.stub( password_hash )
-      @it.stub(authentication_hash: password_hash)
-      @it.stub_chain(:mapping, :to, :find_for_authentication).and_return(@resource)
-      @it.stub(:validate) do |resource, &block|
+      allow(@it).to receive(:password).and_return('password')
+      allow(@it).to receive(:authentication_hash).and_return(password: 'password')
+      allow(@it).to receive_message_chain("mapping.to.find_for_authentication").and_return(@resource)
+
+      allow(@it).to receive(:validate) do |resource, &block|
         expect(resource).to eq @resource
         block.call
       end
     end
 
     it "should pass to another strategy if #valid_for_custom_authentication? is not defined" do
+      @resource.instance_eval('undef :valid_for_custom_authentication?')
+
       expect(@resource).to receive(:after_custom_authentication).never
       expect(@it).to receive(:validate).never
       expect(@it).to receive(:pass).once.and_return('skip')

data/spec/spec_helper.rb

@@ -1,2 +1,102 @@
 require 'devise_custom_authenticatable'
 require 'support/helpers'
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = false
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+end

data/spec/support/helpers.rb

@@ -1,5 +1,9 @@
 class CustomAuthenticatableTestClass
   include Devise::Models::CustomAuthenticatable
+
+  def valid_for_custom_authentication?(*args); end
+  def authenticated_by_test1_strategy?(*args); end
+  def authenticated_by_test2_strategy?(*args); end
 end
 
 def env_with_params(path = "/", params = {}, env = {})

metadata

@@ -1,86 +1,91 @@
 --- !ruby/object:Gem::Specification
 name: devise_custom_authenticatable
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors:
 - Artūrs Mekšs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2016-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: devise
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
 description: Simple way to customize devise authentication logic and still be inline
   with all other devise parts
 email:
@@ -89,9 +94,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -109,34 +114,27 @@ files:
 homepage: https://github.com/AMekss/devise_custom_authenticatable
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1558931694658309700
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1558931694658309700
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
-summary: ! 'Extends Devise with new module :custom_authenticatable, when enabled it
+specification_version: 4
+summary: 'Extends Devise with new module :custom_authenticatable, when enabled it
   will call #valid_for_custom_authentication? method on resource model for your customizations'
 test_files:
 - spec/devise/models/custom_authenticatable_spec.rb