devise_cas_authenticatable 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e7a21d56c086e07750dfdf7e6ad8759233919ae
-  data.tar.gz: 3a9d7c28cf8889001a89e3f4eb5cdb46439b42e9
+  metadata.gz: e218be1e32158092b12200997cd9766d7bd44dc9
+  data.tar.gz: 06134730c16d3512594ee8d7958f0d8af8e9ad95
 SHA512:
-  metadata.gz: ba4cffad023fd9a1507c20f2a4145e4575f8173232e3aab9784f3c258082c6f1a82371f9f2ad300be5bbe3e491a7e97350bed01aff273a0ab0178673fd78ec61
-  data.tar.gz: 9512c05944ed91ae97221ba2f3ce22a89ee12384cd04c6a87e139cf203d9d1e132c8de754124e326dd11c327d8e62188543c092bf76372cedf95bf4be0c7ca2e
+  metadata.gz: 72cbc90c0c374573af01d0021a5ba0be3aa612fcb4493da084c56d8bb6c0469ef65d4ffb2055a508081bcd2f8086c8461f6662a935f68f1f36e47b36068eca4e
+  data.tar.gz: 3419752f94b6f9e5d44f3b51ded704c0da466c619109b267c76d9c527a2a7736ef9885829e9308f520884833870d45b7c8cadfe321145dafd3ef32c68698f7e8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog for devise\_cas\_authenticatable
 
+## Version 1.9.0 - May 10, 2016
+
+* No longer requires net/telnet in order to work properly, so Ruby 2.3 can work out-of-the-box
+
 ## Version 1.8.0 - May 4, 2016
 
 * May the 4th be with you!

data/Gemfile

@@ -0,0 +1 @@
+Gemfile.devise21

data/devise_cas_authenticatable.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{devise_cas_authenticatable}
-  s.version = "1.8.0"
+  s.version = "1.9.0"
 
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nat Budin", "Jeremy Haile"]

data/lib/devise_cas_authenticatable/memcache_checker.rb

@@ -1,4 +1,5 @@
-require 'net/telnet'
+require 'socket'
+require 'timeout'
 
 module DeviseCasAuthenticatable
   class MemcacheChecker
@@ -17,14 +18,21 @@ module DeviseCasAuthenticatable
       memcache_servers.each do |server|
         host, port = server.split(":")
         begin
-          Net::Telnet.new("Host" => host, "Port" => port, "Timeout" => 1)
+          try_connect host, port
+
           return true
-        rescue Errno::ECONNREFUSED
+        rescue Errno::ECONNREFUSED, Timeout::Error
           return false
         end
       end
     end
 
+    def try_connect(host, port)
+      Timeout::timeout(1) do
+        TCPSocket.open(host, port)
+      end
+    end
+
     private
 
     def session_store_class

data/spec/memcache_checker_spec.rb

@@ -37,7 +37,7 @@ describe DeviseCasAuthenticatable::MemcacheChecker do
       subject(:alive?) { described_class.new(conf_double).alive? }
 
       before do
-        Net::Telnet.stubs(:new)
+        DeviseCasAuthenticatable::MemcacheChecker.any_instance.stubs(:try_connect)
       end
 
       it { expect(alive?).to eq true }

data/spec/strategy_spec.rb

@@ -3,8 +3,8 @@ require 'spec_helper'
 describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
   include RSpec::Rails::RequestExampleGroup
   include Capybara::DSL
-  
-  before do    
+
+  before do
     Devise.cas_base_url = "http://www.example.com/cas_server"
     TestAdapter.reset_valid_users!
 
@@ -13,11 +13,11 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       u.username = "joeuser"
     end
   end
-  
+
   after do
     visit destroy_user_session_url
   end
-  
+
   def cas_login_url
     @cas_login_url ||= begin
       uri = URI.parse(Devise.cas_base_url + "/login")
@@ -25,11 +25,11 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       uri.to_s
     end
   end
-  
+
   def cas_logout_url
     @cas_logout_url ||= Devise.cas_base_url + "/logout?service"
   end
-  
+
   def sign_into_cas(username, password)
     visit root_url
     current_url.should == cas_login_url
@@ -37,7 +37,7 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
     fill_in "Password", :with => password
     click_on "Login"
   end
-  
+
   describe "GET /protected/resource" do
     before { get '/' }
 
@@ -46,28 +46,28 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       response.should redirect_to(new_user_session_url)
     end
   end
-  
+
   describe "GET /users/sign_in" do
     before { get new_user_session_url }
-    
+
     it 'should redirect to CAS server' do
       response.should be_redirect
       response.should redirect_to(cas_login_url)
     end
   end
-  
+
   it "should sign in with valid user" do
     sign_into_cas "joeuser", "joepassword"
     current_url.should == root_url
   end
-  
+
   it "should fail to sign in with an invalid user" do
     sign_into_cas "invaliduser", "invalidpassword"
     current_url.should_not == root_url
   end
 
   describe "with a deactivated user" do
-    before do 
+    before do
       @user = User.first
       @user.deactivated = true
       @user.save!
@@ -78,13 +78,13 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       current_url.should == cas_logout_url
     end
   end
-  
+
   it "should register new CAS users if set up to do so" do
     User.count.should == 1
     TestAdapter.register_valid_user("newuser", "newpassword")
     Devise.cas_create_user = true
     sign_into_cas "newuser", "newpassword"
-    
+
     current_url.should == root_url
     User.count.should == 2
     User.find_by_username("newuser").should_not be_nil
@@ -102,7 +102,7 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       TestAdapter.register_valid_user("newuser", "newpassword")
       Devise.cas_create_user = false
       sign_into_cas "newuser", "newpassword"
-      
+
       current_url.should == root_url
       User.count.should == 2
       User.find_by_username("newuser").should_not be_nil
@@ -112,13 +112,13 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
       end
     end
   end
-  
+
   it "should fail CAS login if user is unregistered and cas_create_user is false" do
     User.count.should == 1
     TestAdapter.register_valid_user("newuser", "newpassword")
     Devise.cas_create_user = false
     sign_into_cas "newuser", "newpassword"
-    
+
     current_url.should_not == root_url
     User.count.should == 1
     User.find_by_username("newuser").should be_nil
@@ -129,12 +129,12 @@ describe Devise::Strategies::CasAuthenticatable, :type => "acceptance" do
     click_on "Login"
     current_url.should == root_url
   end
-  
+
   it "should work correctly with Devise trackable" do
     user = User.first
     user.update_attributes!(:last_sign_in_at => 1.day.ago, :last_sign_in_ip => "1.2.3.4", :sign_in_count => 41)
     sign_into_cas "joeuser", "joepassword"
-    
+
     user.reload
     user.last_sign_in_at.should >= 1.hour.ago
     user.sign_in_count.should == 42

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devise_cas_authenticatable
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Nat Budin
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -310,7 +310,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: CAS authentication module for Devise

data/Gemfile

@@ -1,13 +0,0 @@
-source "http://rubygems.org"
-
-# Specify your gem's dependencies in devise_cas_authenticatable.gemspec
-gemspec
-
-gem 'rails', '~> 3.2.0'
-gem 'devise', '~> 2.1.0'
-
-group :test do
-  gem 'castronaut', :git => 'https://github.com/nbudin/castronaut.git', :branch => 'dam5s-merge'
-	gem 'minitest'
-  gem 'test-unit'
-end