devise_cas_authenticatable 1.7.1 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 982f05c3b4f817eeeb431e6a342014e70beca12b
-  data.tar.gz: 880dcb8f9fd445e2e3d19de68abd6d202484434e
+  metadata.gz: 4e7a21d56c086e07750dfdf7e6ad8759233919ae
+  data.tar.gz: 3a9d7c28cf8889001a89e3f4eb5cdb46439b42e9
 SHA512:
-  metadata.gz: db03ed7056af129f37a7dfcdf8cb9486484f69e5a739060eca124087a2146affbc108cc37c42dfe1f2411041846c0b4e5414fb2bb5e0c36c7ef10c332e9b42cd
-  data.tar.gz: 8bd1b15e5740dda654de992bbe12e68ad85138e2a130440c944ac5253cdc7291a6fd3a70403b8f22fbb16cb2841f778f051ca4c2f54b4b626acb37b1edea3945
+  metadata.gz: ba4cffad023fd9a1507c20f2a4145e4575f8173232e3aab9784f3c258082c6f1a82371f9f2ad300be5bbe3e491a7e97350bed01aff273a0ab0178673fd78ec61
+  data.tar.gz: 9512c05944ed91ae97221ba2f3ce22a89ee12384cd04c6a87e139cf203d9d1e132c8de754124e326dd11c327d8e62188543c092bf76372cedf95bf4be0c7ca2e

data/.rspec

@@ -0,0 +1 @@
+--color

data/.travis.yml

@@ -1,6 +1,11 @@
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.2
+  - 2.2.4
+  - 2.3.0
+before_install:
+  - gem update bundler
 gemfile:
   - Gemfile.devise12
   - Gemfile.devise13
@@ -10,4 +15,5 @@ gemfile:
   - Gemfile.devise21
   - Gemfile.devise30
 script: "bundle exec rake spec"
-
+sudo: required
+dist: trusty

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog for devise\_cas\_authenticatable
 
+## Version 1.8.0 - May 4, 2016
+
+* May the 4th be with you!
+* Prevent redirect loops when using memcached as a session store (thanks @fabioperrella!)
+
 ## Version 1.7.1 - February 2, 2016
 
 * Work around weird `#try` behavior on older Rails versions

data/app/controllers/devise/cas_sessions_controller.rb

@@ -8,6 +8,10 @@ class Devise::CasSessionsController < Devise::SessionsController
   skip_before_filter :verify_authenticity_token, :only => [:single_sign_out]
 
   def new
+    if memcache_checker.session_store_memcache? && !memcache_checker.alive?
+      raise "memcache is down, can't get session data from it"
+    end
+
     redirect_to(cas_login_url)
   end
 
@@ -115,4 +119,8 @@ class Devise::CasSessionsController < Devise::SessionsController
       ::Devise.cas_client.logout_url(cas_destination_url, cas_follow_url)
     end
   end
+
+  def memcache_checker
+    @memcache_checker ||= DeviseCasAuthenticatable::MemcacheChecker.new(Rails.configuration)
+  end
 end

data/devise_cas_authenticatable.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{devise_cas_authenticatable}
-  s.version = "1.7.1"
+  s.version = "1.8.0"
 
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nat Budin", "Jeremy Haile"]
@@ -26,6 +26,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency("rails", ">= 3.0.7")
   s.add_development_dependency("rspec-rails")
+  s.add_development_dependency("test-unit", "~> 3.0")
   s.add_development_dependency("mocha")
   s.add_development_dependency("shoulda")
   s.add_development_dependency("sqlite3")

data/lib/devise_cas_authenticatable.rb

@@ -5,6 +5,7 @@ require 'devise_cas_authenticatable/routes'
 require 'devise_cas_authenticatable/strategy'
 require 'devise_cas_authenticatable/exceptions'
 
+require 'devise_cas_authenticatable/session_store_identifier'
 require 'devise_cas_authenticatable/single_sign_out'
 
 require 'devise_cas_authenticatable/cas_action_url_factory_base'
@@ -12,6 +13,7 @@ require 'devise_cas_authenticatable/cas_action_url_factory_base'
 require 'rubycas-client'
 
 require 'devise_cas_authenticatable/railtie' if defined?(Rails::Railtie)
+require 'devise_cas_authenticatable/memcache_checker'
 
 # Register as a Rails engine if Rails::Engine exists
 begin
@@ -22,7 +24,7 @@ else
     class Engine < Rails::Engine
       initializer "devise_cas_authenticatable.single_sign_on.warden_failure_app" do |app|
         # requiring this here because the parent class calls Rails.application, which
-        # isn't set up until after bundler has required the modules in this engine 
+        # isn't set up until after bundler has required the modules in this engine
         require 'devise_cas_authenticatable/single_sign_out/warden_failure_app'
       end
     end
@@ -33,13 +35,13 @@ module Devise
   # The base URL of the CAS server.  For example, http://cas.example.com.  Specifying this
   # is mandatory.
   @@cas_base_url = nil
-  
+
   # The login URL of the CAS server.  If undefined, will default based on cas_base_url.
   @@cas_login_url = nil
-  
+
   # The login URL of the CAS server.  If undefined, will default based on cas_base_url.
   @@cas_logout_url = nil
-  
+
   # The login URL of the CAS server.  If undefined, will default based on cas_base_url.
   @@cas_validate_url = nil
 
@@ -64,18 +66,18 @@ module Devise
   # Should devise_cas_authenticatable attempt to create new user records for
   # unknown usernames?  True by default.
   @@cas_create_user = true
-  
+
   # The model attribute used for query conditions. Should be the same as
   # the rubycas-server username_column. :username by default
   @@cas_username_column = :username
-  
+
   # The CAS reponse value used to find users in the local database
   # it is required that this field be in cas_extra_attributes
   @@cas_user_identifier = nil
 
-  # Name of the parameter passed in the logout query 
+  # Name of the parameter passed in the logout query
   @@cas_destination_logout_param_name = nil
-  
+
   # Additional options for CAS client object
   @@cas_client_config_options = {}
 
@@ -96,21 +98,21 @@ module Devise
         :validate_url => @@cas_validate_url,
         :enable_single_sign_out => @@cas_enable_single_sign_out
       }
-      
+
       cas_options.merge!(@@cas_client_config_options) if @@cas_client_config_options
-      
+
       CASClient::Client.new(cas_options)
     end
   end
-  
+
   def self.cas_service_url(base_url, mapping)
     cas_action_url(base_url, mapping, "service")
   end
-  
+
   def self.cas_unregistered_url(base_url, mapping)
     cas_action_url(base_url, mapping, "unregistered")
   end
-  
+
   private
   def self.cas_action_url(base_url, mapping, action)
     cas_action_url_factory_class.new(base_url, mapping, action).call

data/lib/devise_cas_authenticatable/memcache_checker.rb

@@ -0,0 +1,34 @@
+require 'net/telnet'
+
+module DeviseCasAuthenticatable
+  class MemcacheChecker
+    attr_reader :rails_configuration
+
+    def initialize(rails_configuration)
+      @rails_configuration = rails_configuration
+    end
+
+    def session_store_memcache?
+      !!(session_store_class.name =~ /memcache/i)
+    end
+
+    def alive?
+      memcache_servers = rails_configuration.session_options[:memcache_server] || ["127.0.0.1:11211"]
+      memcache_servers.each do |server|
+        host, port = server.split(":")
+        begin
+          Net::Telnet.new("Host" => host, "Port" => port, "Timeout" => 1)
+          return true
+        rescue Errno::ECONNREFUSED
+          return false
+        end
+      end
+    end
+
+    private
+
+    def session_store_class
+      @session_store_class ||= DeviseCasAuthenticatable::SessionStoreIdentifier.new.session_store_class
+    end
+  end
+end

data/lib/devise_cas_authenticatable/session_store_identifier.rb

@@ -0,0 +1,29 @@
+module DeviseCasAuthenticatable
+  class SessionStoreIdentifier
+
+    def current_session_store
+      app = Rails.application.app
+      begin
+        app = (app.instance_variable_get(:@backend) || app.instance_variable_get(:@app) || app.instance_variable_get(:@target))
+      end until app.nil? or app.class == session_store_class
+      app
+    end
+
+    def session_store_class
+      @session_store_class ||=
+        begin
+          # Rails 3 & 4 session store
+          if ::DeviseCasAuthenticatable::SingleSignOut.rails3_or_greater?
+            Rails.configuration.session_store
+            ::Rails.application.config.session_store
+          else
+            # => Rails 2
+            ActionController::Base.session_store
+          end
+        rescue NameError => e
+          # for older versions of Rails (prior to 2.3)
+          ActionController::Base.session_options[:database_manager]
+        end
+    end
+  end
+end

data/lib/devise_cas_authenticatable/single_sign_out.rb

@@ -7,31 +7,6 @@ module DeviseCasAuthenticatable
 
     # Supports destroying sessions by ID for ActiveRecord and Redis session stores
     module DestroySession
-      def session_store_class
-        @session_store_class ||=
-          begin
-            # Rails 3 & 4 session store
-            if ::DeviseCasAuthenticatable::SingleSignOut.rails3_or_greater?
-              Rails.configuration.session_store
-              ::Rails.application.config.session_store
-            else
-              # => Rails 2
-              ActionController::Base.session_store
-            end
-          rescue NameError => e
-            # for older versions of Rails (prior to 2.3)
-            ActionController::Base.session_options[:database_manager]
-          end
-      end
-
-      def current_session_store
-        app = Rails.application.app
-        begin
-          app = (app.instance_variable_get(:@backend) || app.instance_variable_get(:@app) || app.instance_variable_get(:@target))
-        end until app.nil? or app.class == session_store_class
-        app
-      end
-
       def destroy_session_by_id(sid)
         logger.debug "Single Sign Out from session store: #{current_session_store.class}"
 
@@ -61,6 +36,18 @@ module DeviseCasAuthenticatable
           false
         end
       end
+
+      def session_store_identifier
+        @session_store_identifier ||= DeviseCasAuthenticatable::SessionStoreIdentifier.new
+      end
+
+      def current_session_store
+        session_store_identifier.current_session_store
+      end
+
+      def session_store_class
+        session_store_identifier.session_store_class
+      end
     end
 
   end

data/spec/memcache_checker_spec.rb

@@ -0,0 +1,49 @@
+require "spec_helper"
+
+describe DeviseCasAuthenticatable::MemcacheChecker do
+  let(:conf_double) { stub(session_options: {}) }
+
+  describe '#session_store_memcache?' do
+    subject(:session_store_memcache?) { described_class.new(conf_double).session_store_memcache? }
+
+    before do
+      DeviseCasAuthenticatable::SessionStoreIdentifier.any_instance
+        .stubs(:session_store_class).returns(session_store_class)
+    end
+
+    context "when session store is memcache" do
+      let(:session_store_class) { FakeMemcacheStore }
+
+      it { expect(session_store_memcache?).to eq true  }
+    end
+
+    context "when session store is NOT memcache" do
+      let(:session_store_class) { String }
+
+      it { expect(session_store_memcache?).to eq false  }
+    end
+  end
+
+  describe 'alive?' do
+    context "when memcache is down" do
+      let(:conf_double) { stub(session_options: {memcache_server: ['127.0.0.1:11223']}) }
+      subject(:alive?) { described_class.new(conf_double).alive? }
+
+      it { expect(alive?).to eq false }
+    end
+
+    context "when memcache is running" do
+      let(:conf_double) { stub(session_options: {memcache_server: ['127.0.0.1:11214']}) }
+      subject(:alive?) { described_class.new(conf_double).alive? }
+
+      before do
+        Net::Telnet.stubs(:new)
+      end
+
+      it { expect(alive?).to eq true }
+    end
+  end
+end
+
+class FakeMemcacheStore
+end

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@ require 'rspec/rails'
 require 'sham_rack'
 require 'capybara/rspec'
 require 'timecop'
+require 'pry'
 
 RSpec.configure do |config|
   config.mock_with :mocha
@@ -15,7 +16,7 @@ end
 ShamRack.at('www.example.com') do |env|
   request = Rack::Request.new(env)
   request.path_info = request.path_info.sub(/^\/cas_server/, '')
-  
+
   Castronaut::Application.call(request.env)
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devise_cas_authenticatable
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.8.0
 platform: ruby
 authors:
 - Nat Budin
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-02 00:00:00.000000000 Z
+date: 2016-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -67,6 +67,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -202,6 +216,7 @@ extra_rdoc_files:
 files:
 - ".gitignore"
 - ".project"
+- ".rspec"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -222,10 +237,12 @@ files:
 - lib/devise_cas_authenticatable.rb
 - lib/devise_cas_authenticatable/cas_action_url_factory_base.rb
 - lib/devise_cas_authenticatable/exceptions.rb
+- lib/devise_cas_authenticatable/memcache_checker.rb
 - lib/devise_cas_authenticatable/model.rb
 - lib/devise_cas_authenticatable/railtie.rb
 - lib/devise_cas_authenticatable/routes.rb
 - lib/devise_cas_authenticatable/schema.rb
+- lib/devise_cas_authenticatable/session_store_identifier.rb
 - lib/devise_cas_authenticatable/single_sign_out.rb
 - lib/devise_cas_authenticatable/single_sign_out/rack.rb
 - lib/devise_cas_authenticatable/single_sign_out/strategies.rb
@@ -235,6 +252,7 @@ files:
 - lib/devise_cas_authenticatable/strategy.rb
 - rails/init.rb
 - spec/config_spec.rb
+- spec/memcache_checker_spec.rb
 - spec/model_spec.rb
 - spec/routes_spec.rb
 - spec/scenario/.gitignore
@@ -298,6 +316,7 @@ specification_version: 4
 summary: CAS authentication module for Devise
 test_files:
 - spec/config_spec.rb
+- spec/memcache_checker_spec.rb
 - spec/model_spec.rb
 - spec/routes_spec.rb
 - spec/scenario/.gitignore