devise-async 0.3.1 → 0.4.0

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## Unreleased
 
+## 0.4.0
+
+* Enhancements
+  * Add support for queue config to DelayedJob backend
+  * Use Devise third party modules API insted of including module directly.
+    This fixes the ordering issue when including.
+
 ## 0.3.1
 
 * Fixes

data/README.md

@@ -26,18 +26,23 @@ Or install it yourself as:
 
 ## Usage
 
-### Devise >= 2.1.1
-
-Include `Devise::Async::Model` to your Devise model
+Add `:async` to the `devise` call in your model:
 
 ```ruby
 class User < ActiveRecord::Base
-  devise :database_authenticatable, :confirmable # etc ...
-
-  include Devise::Async::Model # should be below call to `devise`
+  devise :database_authenticatable, :async, :confirmable # etc ...
 end
 ```
 
+Set your queuing backend by creating `config/initializers/devise_async.rb`:
+
+```ruby
+# Supported options: :resque, :sidekiq, :delayed_job
+Devise::Async.backend = :resque
+```
+
+Tip: it defaults to Resque. You don't need to create the initializer if using it.
+
 ### Devise < 2.1.1
 
 Set `Devise::Async::Proxy` as Devise's mailer in `config/initializers/devise.rb`:
@@ -46,16 +51,9 @@ Set `Devise::Async::Proxy` as Devise's mailer in `config/initializers/devise.rb`
 # Configure the class responsible to send e-mails.
 config.mailer = "Devise::Async::Proxy"
 ```
-### All
-
-Set your queuing backend by creating `config/initializers/devise_async.rb`:
 
-```ruby
-# Supported options: :resque, :sidekiq, :delayed_job
-Devise::Async.backend = :resque
-```
-
-Tip: it defaults to Resque. You don't need to create the initializer if using it.
+Note: before devise 2.1.1 devise-async had issues with background jobs trying to run
+before the record was committed to the DB if the creation was transactioned.
 
 ## Advanced Options
 

data/lib/devise/async.rb

@@ -56,3 +56,5 @@ module DeviseAsync
     Devise::Async.backend = value
   end
 end
+
+Devise.add_module(:async, :model => 'devise/async/model')

data/lib/devise/async/backend/delayed_job.rb

@@ -3,7 +3,7 @@ module Devise
     module Backend
       class DelayedJob < Base
         def self.enqueue(*args)
-          new.delay.perform(*args)
+          new.delay(:queue => Devise::Async.queue).perform(*args)
         end
       end
     end

data/lib/devise/async/model.rb

@@ -1,8 +1,19 @@
 module Devise
+  # TODO remove when appropriate
   module Async
     module Model
       extend ActiveSupport::Concern
 
+      included do
+        warn "Including Devise::Async::Model directly in your models is no longer supported and won't work. Please add `:async` to your `devise` call."
+      end
+    end
+  end
+
+  module Models
+    module Async
+      extend ActiveSupport::Concern
+
       included do
         if respond_to?(:after_commit) # AR only
           after_commit :send_devise_pending_notifications

data/lib/devise/async/version.rb

@@ -1,5 +1,5 @@
 module Devise
   module Async
-    VERSION = "0.3.1"
+    VERSION = "0.4.0"
   end
 end

data/test/support/rails_app/app/models/admin.rb

@@ -1,7 +1,5 @@
 class Admin < ActiveRecord::Base
   devise :database_authenticatable, :confirmable, :lockable, :recoverable,
     :registerable, :rememberable, :timeoutable, :token_authenticatable,
-    :trackable, :validatable
-
-  include Devise::Async::Model
+    :trackable, :validatable, :async
 end

data/test/test_helper.rb

@@ -5,9 +5,9 @@ require "minitest/spec"
 require "minitest/mock"
 require "mocha"
 
+require "devise"
 require "devise/async"
 require "rails/all"
-require "devise"
 require "resque"
 require "sidekiq"
 require "delayed_job_active_record"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devise-async
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-15 00:00:00.000000000 Z
+date: 2012-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -232,7 +232,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -215577202643201492
+      hash: -1947628383257764484
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -241,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -215577202643201492
+      hash: -1947628383257764484
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23