devise-async 0.3.0 → 0.3.1

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## Unreleased
 
+## 0.3.1
+
+* Fixes
+  * Do not register after_commit unless ORM supports it
+  * Only enqueue notifications for after_commit if model is dirty
+
+## 0.3.0
+
 * Fixes
   * Added `Devise::Async::Model` to use new devise's after_commit hooks to resolve #6 (only devise >=2.1.1)
 

data/lib/devise/async/model.rb

@@ -4,13 +4,21 @@ module Devise
       extend ActiveSupport::Concern
 
       included do
-        after_commit :send_devise_pending_notifications
+        if respond_to?(:after_commit) # AR only
+          after_commit :send_devise_pending_notifications
+        else # mongoid
+          after_save :send_devise_pending_notifications
+        end
       end
 
       protected
 
       def send_devise_notification(notification)
-        devise_pending_notifications << notification
+        if changed?
+          devise_pending_notifications << notification
+        else
+          Devise::Async::Worker.enqueue(notification, self.class.name, self.id.to_s)
+        end
       end
 
       def send_devise_pending_notifications

data/lib/devise/async/version.rb

@@ -1,5 +1,5 @@
 module Devise
   module Async
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/test/devise/async/model_test.rb

@@ -3,18 +3,38 @@ require "test_helper"
 module Devise
   module Async
     describe "Model" do
-      it "accumulates notifications to be send after commit" do
+      it "accumulates notifications to be sent after commit on Model creation" do
+        Admin.transaction do
+          admin = create_admin
+          admin.send(:devise_pending_notifications).must_equal [:confirmation_instructions]
+        end
+      end
+      
+      it "immediately sends notifications when the model has not changed" do
         admin = create_admin
+        Worker.expects(:enqueue).with(:confirmation_instructions, "Admin", admin.id.to_s)
         admin.send_confirmation_instructions
-        admin.send(:devise_pending_notifications).must_equal [:confirmation_instructions]
-        Worker.expects(:enqueue).never
+      end
+      
+      it "accumulates notifications to be sent after commit when Model has been changed" do
+        admin = create_admin
+        Admin.transaction do
+          admin[:username] = "changed_username"
+          admin.send_confirmation_instructions
+          admin.send(:devise_pending_notifications).must_equal [:confirmation_instructions]
+          Worker.expects(:enqueue).never # after_commit will not fire without save
+        end
       end
 
-      it "triggers enqueues the notifications on save" do
+      it "triggers the enqueued notifications on save" do
         admin = create_admin
-        admin.send_confirmation_instructions
-        Worker.expects(:enqueue).with(:confirmation_instructions, "Admin", admin.id.to_s)
-        admin.update_attribute(:username, "newusername")
+        Admin.transaction do
+          admin[:username] = "changed_username"
+          admin.send_confirmation_instructions
+          admin.send(:devise_pending_notifications).must_equal [:confirmation_instructions]
+          admin.save
+          Worker.expects(:enqueue).with(:confirmation_instructions, "Admin", admin.id.to_s)
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devise-async
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-21 00:00:00.000000000 Z
+date: 2012-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -232,7 +232,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1160752069777007952
+      hash: -215577202643201492
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -241,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1160752069777007952
+      hash: -215577202643201492
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23