devise-async-stretch 0.0.1 → 0.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjAyNzE3NzFhNWE4YzUxNzllZDI5YmYxYWQ5MDc0OTE4ZDE3ZGE0ZA==
+    OTI2MDhjNWJiYTUwMDUwN2RjMjk3OTE4ODAwMWJiNDAxMGE1NDU5ZA==
   data.tar.gz: !binary |-
-    MjFkYjg0NDUyYTg1NjcwNzE1YWM2MjRhM2ZjY2VjMTc4MTZlNGYyZg==
+    YzJkMjIwNTczMjgxMmM4ZjljYTMzYmVkNWI1ZmU5MmViZDViNGFiYw==
 SHA512:
   metadata.gz: !binary |-
-    YTg3ODA2YmM4YTFmNjIzMDIyMzE3MmI1NzIwNzQ3ODk0YTQ3YTFhMTQ1OTNl
-    NDY4ZWIxNWEwNzk1NzViNDUzYjU5MGE3NDZhMjdhZDdlYjc3MTYxNGQ1ZTcw
-    M2E4ZjA0NzQ4NDZjYjMyZTU0NjdlYmNlODljMjUzODNlZjVkNWI=
+    NzQ5MGVhMTJiMmM0ZWM0NzUzNmFhNTYwYmU1ZGZlNWI5NTc1NmY5NTdjYjEw
+    MGM1ZmJjMWZhNjE1ZGRhYmZiMTdmMzU2OGQ4ODdiOWVhZGMxOWI2MzI4MTZh
+    ZjhlZjM1YWU0MWU4OWQ5NTU0YWRiYzg4MWExOTU5ZmUyY2NjOWU=
   data.tar.gz: !binary |-
-    NzQ2ZjY3MjM5ZTI3MGMyMWEwYzE1YzA5MTdhMGE5YTg0YWUwMTIyNzkyODJh
-    YjBmZGY3MzIyODJjN2E1NjgzMTg5ZWEzZDBiY2NjNTUwMDcxZWJlNzE2ZDMy
-    ZTliZjc2ZTVkNGM0N2Q2ZWM3NTBhNTMzYTcyNGZjMzEyNjg4MTM=
+    YTVhZTc0YmUyNjIxM2E3ZTBlMDgwMzE4OTQ0YTQ4NjNmYTJmOTM1YTY3NDA0
+    ZDk4YzZmZjRkNWVlYTJmNTljODFkZGMxYjYzYTk4MWNmODM1NTdjZmRlNzYy
+    M2ZlMGJmNDUwNmFjNzE0NGE4OGU0MmRhOGNjZTFjNDI4YzQ0YTA=

data/.travis.yml

@@ -7,3 +7,6 @@ deploy:
   provider: rubygems
   api_key:
     secure: F1Drh/pkUEDBvn0l6ZpFJeCeJk0FGReu98Ce3PMiIHjHngGsC3xDOTbkQ7+TUQHlfc0g3Hpc4pYmHxL3w/6TJwbx9csRX0Np4yaNfJZJdHR8uzAi7mpY32APXeLCJkV5En3h1B/G1V3qQ+AhH0Ez6nlOiSEhocJ+MVq9jFXagM4=
+addons:
+  code_climate:
+    repo_token: e1fe9dfcd049fee242692f3589fef93579fe012c3874f31ae2afc82013a194b0

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in devise-async-stretch.gemspec
 gemspec
+
+gem "codeclimate-test-reporter", group: :test, require: nil

data/README.md

@@ -1,26 +1,8 @@
 # Devise::Async::Stretch
 
-TODO: Write a gem description
+Move password stretching into a background job for fast user creation but while maintaining difficult to crack storage.
 
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'devise-async-stretch'
-```
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install devise-async-stretch
-
-## Usage
-
-TODO: Write usage instructions here
+Who, why, and how? See the [website](http://devise-async-stretch.onsimplybuilt.com/).
 
 ## Contributing
 

data/devise-async-stretch.gemspec

@@ -22,7 +22,8 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rails", "~> 4.1.0"
+  spec.add_development_dependency "rails", "~> 4.2.0"
+  spec.add_development_dependency "activejob"
   spec.add_development_dependency "mocha", "~> 0.11"
   spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "sidekiq"

data/lib/devise/async/stretch/backend/active_job.rb

@@ -0,0 +1,23 @@
+module Devise
+  module Async
+    module Stretch
+      module Backend
+        class ActiveJob < Base
+          class Job < ::ActiveJob::Base
+            queue_as Devise::Async::Stretch.queue
+
+            def perform(resource, password)
+              encrypted_password = resource.bcrypt(password, resource.class.stretches)
+              resource.update(encrypted_password: encrypted_password)
+            end
+          end
+
+          def self.enqueue_job(klass, id, password)
+            resource = klass.constantize.to_adapter.get!(id)
+            Job.perform_later(resource, password)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/devise/async/stretch/backend/base.rb

@@ -3,7 +3,7 @@ module Devise
     module Stretch
       module Backend
         class Base
-          def self.enqueue(*args)
+          def self.enqueue_job(*args)
             raise NotImplementedError, "Any Devise::Async::Stretch::Backend subclass should implement `self.enqueue`."
           end
 

data/lib/devise/async/stretch/backend/sidekiq.rb

@@ -7,7 +7,7 @@ module Devise
 
           sidekiq_options queue: Devise::Async::Stretch.queue
 
-          def self.enqueue(klass, id, password)
+          def self.enqueue_job(klass, id, password)
             perform_async(klass, id, password)
           end
         end

data/lib/devise/async/stretch/model.rb

@@ -25,7 +25,7 @@ module Devise
       protected
 
       def enqueue_stretch_worker
-        Devise::Async::Stretch::Worker.enqueue(self.class, id, @password) unless @password.nil?
+        Devise::Async::Stretch::Worker.enqueue(self.class.name, id, @password) unless @password.nil?
         @password = nil
       end
 

data/lib/devise/async/stretch/version.rb

@@ -1,7 +1,7 @@
 module Devise
   module Async
     module Stretch
-      VERSION = "0.0.1"
+      VERSION = "0.0.2"
     end
   end
 end

data/lib/devise/async/stretch/worker.rb

@@ -4,7 +4,7 @@ module Devise
       class Worker
 
         def self.enqueue(klass, id, password)
-          backend_klass.enqueue(klass, id, password)
+          backend_klass.enqueue_job(klass, id, password)
         end
 
         private

data/lib/devise/async/stretch.rb

@@ -1,3 +1,9 @@
+# Copyright (c) 2014 Daniel Westendorf
+#
+# Much credit and thanks goes to Marcelo Silveira's wonderfull devise-async gem
+# https://github.com/mhfs/devise-async for inspiration on the backend
+# queuing support.
+
 require "active_support/dependencies"
 require "devise"
 require "devise/async/stretch/version"
@@ -13,6 +19,7 @@ module Devise
       module Backend
         autoload :Base,         "devise/async/stretch/backend/base"
         autoload :Sidekiq,      "devise/async/stretch/backend/sidekiq"
+        autoload :ActiveJob,      "devise/async/stretch/backend/active_job"
       end
 
       # Defines the queue backend to be used. Sidekiq by default.

data/test/devise/async/stretch/backend/active_job_test.rb

@@ -0,0 +1,50 @@
+require 'test_helper'
+# require 'active_job/test_helper'
+
+module Devise
+  module Async
+    module Stretch
+      module Backend
+        class ActiveJobTest < ActiveSupport::TestCase
+          include ::ActiveJob::TestHelper
+
+          setup do
+            @user = users(:bob)
+            Devise::Async::Stretch.enabled = true
+            Devise::Async::Stretch.backend = :active_job
+
+            clear_enqueued_jobs
+          end
+
+          test "the job is queued" do
+            Rails.application.config.active_job.queue_adapter = :sidekiq
+
+            ActiveJob.enqueue_job("User", @user.id, 'password')
+            assert_enqueued_jobs 1
+          end
+
+          test "the password gets updated when peformed" do
+            perform_enqueued_jobs do
+              ActiveJob.enqueue_job("User", @user.id, 'password')
+            end
+            assert_not_empty @user.reload.encrypted_password
+          end
+
+          test "the stretch_mark gets updated" do
+            User.stretches = 2
+
+            user = User.new(email: 'ed@example.com', password: 'password1')
+            encrypted_password = user.encrypted_password
+
+            perform_enqueued_jobs do
+              user.save # Should trigger the ActiveJob job
+            end
+
+            refute_equal encrypted_password, user.reload.encrypted_password
+          end
+
+        end
+      end
+    end
+  end
+end

data/test/devise/async/stretch/backend/base_test.rb

@@ -14,7 +14,7 @@ module Devise
 
           test "an error is raised with the built in enqueue" do
             assert_raises NotImplementedError do
-              Base.enqueue
+              Base.enqueue_job
             end
           end
 

data/test/devise/async/stretch/backend/sidekiq_test.rb

@@ -14,7 +14,7 @@ module Devise
 
           test "the job is queued" do
             assert_difference 'Devise::Async::Stretch::Backend::Sidekiq.jobs.size' do
-              Sidekiq.enqueue("User", @user.id, "password")
+              Sidekiq.enqueue_job("User", @user.id, "password")
             end
           end
 

data/test/rails_app/config/environments/test.rb

@@ -13,7 +13,7 @@ Rails.application.configure do
   config.eager_load = false
 
   # Configure static asset server for tests with Cache-Control for performance.
-  config.serve_static_assets  = true
+  config.serve_static_files  = true
   config.static_cache_control = 'public, max-age=3600'
 
   # Show full error reports and disable caching.
@@ -34,6 +34,11 @@ Rails.application.configure do
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
+  config.active_support.test_order = :random
+
+  # Active Job config
+  config.active_job.queue_adapter = :sidekiq
+
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
 end

data/test/test_helper.rb

@@ -1,3 +1,6 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require "devise/async/stretch"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devise-async-stretch
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Daniel Westendorf
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-29 00:00:00.000000000 Z
+date: 2015-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -58,14 +58,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 4.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 4.2.0
+- !ruby/object:Gem::Dependency
+  name: activejob
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -125,6 +139,7 @@ files:
 - devise-async-stretch.gemspec
 - lib/devise/async/stretch.rb
 - lib/devise/async/stretch/backend.rb
+- lib/devise/async/stretch/backend/active_job.rb
 - lib/devise/async/stretch/backend/base.rb
 - lib/devise/async/stretch/backend/sidekiq.rb
 - lib/devise/async/stretch/model.rb
@@ -133,6 +148,7 @@ files:
 - lib/generators/devise/async/stretch/install_generator.rb
 - lib/generators/templates/devise_async_stretch.rb
 - log/test.log
+- test/devise/async/stretch/backend/active_job_test.rb
 - test/devise/async/stretch/backend/base_test.rb
 - test/devise/async/stretch/backend/sidekiq_test.rb
 - test/devise/async/stretch/backend_test.rb
@@ -227,6 +243,7 @@ signing_key:
 specification_version: 4
 summary: Move password stretching into a background job for fast user creation.
 test_files:
+- test/devise/async/stretch/backend/active_job_test.rb
 - test/devise/async/stretch/backend/base_test.rb
 - test/devise/async/stretch/backend/sidekiq_test.rb
 - test/devise/async/stretch/backend_test.rb