development_notification 0.1.3 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa8acdb52671206f355b55f8ba4ce31de3814aeb
-  data.tar.gz: b39316615517d9fd3fbf5c5a9684a299ce786b7d
+  metadata.gz: 057b1d2eebadf0cbd3e250b83a1b3f84c63a989b
+  data.tar.gz: c4797eb0d6bf04f13ada5c0aec985cd94d06313f
 SHA512:
-  metadata.gz: f8d14b5351eaae50c32b1fb6be4301d3150f62e0767a008ae0d0d5f62b68279435ce8ba7772e0451723f8cce7e6ad0a900d35d426cfdb1a94d40cd4d69d6fd59
-  data.tar.gz: 9b9c79718071ea829cc19730e7c4f2a040ce9b9f4acd9f102029109e0defb2e7499bb17ce29ec097e7546908cd508c97caa4789058ac4ee355c7d9e3845bf172
+  metadata.gz: e46b59ea251b1ed71d4879ffb51868cbb2b0188ee2264094443f2967ca59aeebb6124d2df9322627cd4f9b50901ee15917bc0a250cfbcc2508286ac9c528d6c3
+  data.tar.gz: a409e905ff6c4f30601a7c3b2c8f95ab847ac163a87fb759b1c03233bd46625803f1a6f00594d6d8608ef3ac870f79bc5f8167d7c7c70424c028c9ffc642f141

data/README.md

@@ -2,6 +2,14 @@
 
 ## Installation
 
+__Rails5__
+
+```
+gem 'development_notification', "2.0.0" # and bundle
+```
+
+__Rails4__
+
 ```
 gem 'development_notification', "0.1.3" # and bundle
 ```
@@ -30,12 +38,20 @@ After setup you gain access to:
 * DevelopmentNotification::Email.send_email(parameter_hash) #=> sends emails
 
 ### Email sending :bear: (the good stuff) :honeybee:
-DevelopmentNotification::Email.send_email(title: "Systemside identifier", to: ["dump@example1.com", "dump@example2.com"], from: "creative@inbox.lv", fromname: "Creative", subject: "test", template: "html body")
+```
+DevelopmentNotification::Email.send_email(
+  title: "Systemside identifier",
+  to: ["dump@example1.com", "dump@example2.com"],
+  from: "creative@inbox.lv",
+  fromname: "Creative",
+  subject: "test",
+  template: "html body"
+)
+```
 
 `to:` key accepts both array of strings and a single string  
 
 ## Gotchas
-* Engine uses smart migration inclusion, this works well in development, but production deployment that migrates selectively (like mina) may fail at detecting migrations. Be sure to __force migration__ in production.
 * Sometimes production does not load the gem. Append `require: false` in gemfile, and add the line `require 'development_notification'` to `/config/application.rb`
 
 ## Development

data/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/app/models/development_notification/email.rb

@@ -1,9 +1,5 @@
 module DevelopmentNotification
-  class Email < ActiveRecord::Base
-    # def self.params
-    #   return %i|title to_address subject body response status|
-    # end
-
+  class Email < ApplicationRecord
     validates :title, presence: true
     validates :to_address, presence: true
     validates :subject, presence: true
@@ -13,7 +9,10 @@ module DevelopmentNotification
       mail_object = nil
 
       [to].flatten.each do |to_email|
-        mailer = Leadersend::Mail.new(title: title, to: to_email, from: from, fromname: fromname, subject: subject, template: template)
+        mailer = Leadersend::Mail.new(
+          title: title, to: to_email, from: from,
+          fromname: fromname, subject: subject, template: template
+        )
         leadersend_response_hash = mailer.send
 
         mail_object = DevelopmentNotification::Email.create_from_leadersend_response_hash(leadersend_response_hash)
@@ -34,7 +33,7 @@ module DevelopmentNotification
 
       def self.create_from_leadersend_response_hash(**hash)
         hash[:status] = self.statuses[hash[:status]]
-        sent_mail = self.new(hash.symbolize_keys, :without_protection => true)
+        sent_mail = new(hash.symbolize_keys)  # .merge(without_protection: true)
         sent_mail.save
         return sent_mail
       end

data/db/migrate/20151106101824_create_development_notification_emails.rb

@@ -1,6 +1,5 @@
-class CreateDevelopmentNotificationEmails < ActiveRecord::Migration
+class CreateDevelopmentNotificationEmails < ActiveRecord::Migration[4.2]
   def change
-    return if table_exists?(:development_notification_emails)
     create_table :development_notification_emails do |t|
       t.string :title, index: true, null: false
       t.string :to_address, index: true, null: false
@@ -10,6 +9,6 @@ class CreateDevelopmentNotificationEmails < ActiveRecord::Migration
       t.integer :status, index: true, null: false, default: 0
 
       t.timestamps
-    end
+    end unless table_exists?(:development_notification_emails)
   end
 end

data/lib/development_notification/version.rb

@@ -1,3 +1,3 @@
 module DevelopmentNotification
-  VERSION = "0.1.3"
+  VERSION = "2.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: development_notification
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 2.0.0
 platform: ruby
 authors:
 - Creative
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-25 00:00:00.000000000 Z
+date: 2017-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: leadersend
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.1
 description: Enables sending simple emails to app owners. Wraps [Leadersend](http://www.leadersend.com)
   mail delivery service and defines a DevelopmentNotification::Email model for logging.
 email:
@@ -119,6 +133,7 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
+- app/models/application_record.rb
 - app/models/development_notification/email.rb
 - config/routes.rb
 - db/migrate/20151106101824_create_development_notification_emails.rb
@@ -145,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Allow your rails app to send emails to dev team.