devcenter-parser 2.4.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6be89b82bc3dd6e4a40c3b7f1e3871fca55e301c4ff09f934457d84f01dc00b
-  data.tar.gz: 686278e2a9a08bacd5f17124adaaa0d6a3e728a5701814dc9ef15cedecd8a430
+  metadata.gz: c4c53f614ec9479adb0fb78be87cdd30515834c467d1451515ab13abe121f4ac
+  data.tar.gz: 055c8a01895dc7b4646feab0727e71506b3caa4a4b6a48ae61f8abf2bffdbd52
 SHA512:
-  metadata.gz: 1d2cb1e536549ba20c82e76cee60a42d5394872232a815d4ecb0b10fcb29b3d726ec19cc76862e68df78fbd5763173ed6feaa7a3dc4804883f67d78c486b3e32
-  data.tar.gz: c3d69be0dedf80b7db4d70c5a0a188e82717207f65d2bd799ba1264a009b2d9c0e25c3ba73d993331927f43b7f64fb35decc85ab33ea65fbb6bb1f46f0108841
+  metadata.gz: 38d174aaf87c2b54b14b4b17ad9b4145a86b9eb276b1edcff4ab691aee8acb812adcf692c15365f6f6ca22997fb3807f016254c96191485bf780d3c6c62e3fe4
+  data.tar.gz: 6bf94117132dde0e04fa438cf1e0c9fb851ec89db9960b0ffb6db8e3dbd21d0d750cdb7713835c1c0df07657c23e2e1426d3facb892a5d7f10a60501f3cdd5a5

data/.gitignore

@@ -1 +1,2 @@
 pkg/
+.DS_Store

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    devcenter-parser (2.4.0)
-      nokogiri (>= 1.13.10)
+    devcenter-parser (2.5.1)
+      nokogiri (~> 1.16)
       redcarpet (= 3.6.0)
       sanitize (~> 6.0.2)
 
@@ -12,11 +12,11 @@ GEM
     crass (1.0.6)
     mini_portile2 (2.8.5)
     minitest (5.19.0)
-    nokogiri (1.15.5)
+    nokogiri (1.16.2)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     racc (1.7.3)
-    rake (13.0.6)
+    rake (13.1.0)
     redcarpet (3.6.0)
     sanitize (6.0.2)
       crass (~> 1.0.2)
@@ -28,7 +28,7 @@ PLATFORMS
 DEPENDENCIES
   devcenter-parser!
   minitest (~> 5.19.0)
-  rake
+  rake (~> 13.1.0)
 
 BUNDLED WITH
-   2.2.33
+   2.5.6

data/devcenter-parser.gemspec

@@ -16,10 +16,10 @@ Gem::Specification.new do |gem|
 
   gem.required_ruby_version = '>= 3.0.0'
 
-  gem.add_runtime_dependency 'nokogiri', '>= 1.13.10'
+  gem.add_runtime_dependency 'nokogiri', '~> 1.16'
   gem.add_runtime_dependency 'redcarpet', '3.6.0'
   gem.add_runtime_dependency 'sanitize', '~> 6.0.2'
 
   gem.add_development_dependency 'minitest', '~> 5.19.0'
-  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rake', '~>13.1.0'
 end

data/lib/devcenter-parser/version.rb

@@ -1,3 +1,3 @@
 module DevcenterParser
-  VERSION = '2.4.0'.freeze
+  VERSION = '2.5.1'.freeze
 end

data/lib/devcenter-parser.rb

@@ -33,7 +33,7 @@ module DevcenterParser
     convert_to_article_links_all_relative_links_with_missing_initial_slashes(doc, options)
     html = doc.to_html(:encoding => 'utf-8')
     verify_raw_html(html)
-    html
+    html 
   end
 
   def self.normalize_markdown(markdown)
@@ -71,12 +71,12 @@ module DevcenterParser
     return @@sanitize_config if defined?(@@sanitize_config)
     frozen_config = Sanitize::Config::RELAXED
     config = Marshal.load(Marshal.dump(frozen_config))
-    config[:attributes][:all] += %w{ id class style name width height border align data-next-message data-step-title }
+    config[:attributes][:all] += %w{ id class style name width height border align data-next-message data-step-title data-uuid data-type data-v }
     config[:attributes]['a'] += %w{ target }
     config[:elements] += %w{ div span hr tt }
 
     # embedded videos
-    config[:attributes][:all] += %w{ value src type allowscriptaccess allowfullscreen webkitallowfullscreen mozallowfullscreen frameborder }
+    config[:attributes][:all] += %w{ value src type allowscriptaccess allowfullscreen webkitallowfullscreen mozallowfullscreen frameborder allow }
     config[:elements] += %w{ object param embed iframe }
     config[:add_attributes] = {
       'object' => {'allowscriptaccess' => 'never'},
@@ -121,9 +121,11 @@ module DevcenterParser
   def self.sanitize_node_with_invalid_src
     lambda do |env|
       return unless env[:node].attributes['src']
+      # convert youtube.com to youtube-nocookies.com
+      env[:node].attributes['src'].value = env[:node].attributes['src'].value.sub('youtube.com', 'youtube-nocookie.com')
       # disallow javascript in src for all attributes
       env[:node].unlink if env[:node].attributes['src'].value =~ /\Ajavascript:/i
-      # allow iframes if they have src that is from vimeo
+      # allow iframes only if they have src that is from vimeo, YouTube (no-cookies version)
       env[:node].unlink if iframe?(env[:node]) && iframe_has_invalid_src?(env[:node])
     end
   end

data/test/devcenter-parser_test.rb

@@ -60,9 +60,15 @@ describe 'DevcenterParser' do
       assert_parsing_result src, src
     end
 
-    it 'removes youtube videos embedded from the with-cookies domain' do
-      src = '<iframe width="560" height="315" src="https://www.youtube.com/embed/123456ABCDEF" frameborder="0" allowfullscreen=""></iframe>'
-      assert_parsing_result src, ''
+    it 'allows embedding youtube videos from its no-cookies domain with allow attribute' do
+      src = '<iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/123456ABCDEF" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen=""></iframe>'
+      assert_parsing_result src, src
+    end
+
+    it 'converts youtube videos embedded from the with-cookies domain to the no-cookies domain' do
+      src = '<iframe width="560" height="315" src="https://www.youtube.com/embed/123456ABCDEF" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen=""></iframe>'
+      src_result = '<iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/123456ABCDEF" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen=""></iframe>'
+      assert_parsing_result src, src_result
     end
       
     it 'does not allow embedding vimeo videos when their do-no-track param is set to something different than true' do
@@ -75,6 +81,11 @@ describe 'DevcenterParser' do
       assert_parsing_result src, ''
     end
 
+    it 'allows embedding vidyard videos with data attributes' do
+      src = '<p><img style="width: 100%; margin: auto; display: block;" class="vidyard-player-embed" src="https://play.vidyard.com/123456ABCDEFG.jpg" data-uuid="123456ABCDEFG" data-v="4" data-type="inline"></p>'
+      assert_parsing_result src, src
+    end
+
     it 'allows images' do
       src = '<p><img src="http://nav.heroku.com/images/logos/logo.png" alt="image"></p>'
       assert_parsing_result src, src
@@ -517,4 +528,8 @@ HTML
     assert DevcenterParser.to_html(md).include?("<#{header} id=\"#{id}\">"), "GitHub does not generate a #{header} with id #{id}"
   end
 
+  def assert_contains(md, contains)
+    assert DevcenterParser.to_html(md).include?(contains), "Failed when parsing #{md}\n.\n\nDid not contain: #{contains}\n\n"
+  end
+
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: devcenter-parser
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Heroku
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-16 00:00:00.000000000 Z
+date: 2024-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.10
+        version: '1.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.10
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +70,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.1.0
 description: Parser for Heroku Dev Center's content
 email:
 - heroku-front-end@salesforce.com
@@ -122,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Parser for Heroku Dev Center's content