devcenter-parser 2.2.9 → 2.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4517ced26a3c0b03ada92affbbaafb25545d0f9bd05ae347a6da9c7567c5b858
-  data.tar.gz: '05685be056b302fb593c431dc2db6247404f607c382d7e3784cd0cfd267826be'
+  metadata.gz: 251949c020f60adc81bbaa2dc0851b5d594486d74620db779cb8030ba8b41c45
+  data.tar.gz: e700ec53adb5a531eaaf93f7c70677aabaa6959e801b6fed79bf5ac7f8c559f4
 SHA512:
-  metadata.gz: 73e20f5674e995e617b74cf6192032d0ee1d80db4bfdd13246c15b872def1cfb09e27c875cd77ea2ff8d795b1f93787c1d48f0fa7d5ce577e055b9709572af07
-  data.tar.gz: 69b95cdbd69ff72cb8afaa940b5479730ed2e3781ceccfd22570e1093ba25c8a4c9ab198cb031e2983143016b70b047dc161c6cf4c100f7fa66617e7cb46ea47
+  metadata.gz: 9746c03c129900fbc006b96927cfd5f0ffd50169ffc444490e4f219b1a14aa46c8b764d81e21667b0c07a8d6f17cec5277f5da1956070c9b404c3e9af3b96968
+  data.tar.gz: d41b9cd6f6248178991096e1c2bbb26fdc1a9dfc6b9f02cb4a1e511a2f36de83b60a44b1e7c6a0218b5983713cd7aadb93d2214b0a5cad7e8c2f923dc59b4814

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    devcenter-parser (2.2.8)
+    devcenter-parser (2.2.10)
       nokogiri (>= 1.7.1)
       redcarpet (= 3.5.0)
       sanitize (~> 5.2.1)

data/lib/devcenter-parser.rb

@@ -129,7 +129,7 @@ module DevcenterParser
   end
 
   def self.iframe_has_invalid_src?(node)
-    node.attributes['src'].value !~ /\Ahttps:\/\/player.vimeo.com\//i && node.attributes['src'].value !~ /\Ahttps:\/\/www.youtube.com\/embed/i
+    node.attributes['src'].value !~ /https:\/\/player.vimeo.com(.+)(&|\?)dnt=true/i && node.attributes['src'].value !~ /\Ahttps:\/\/www\.youtube-nocookie\.com\/embed/i
   end
 
   def self.iframe?(node)

data/lib/devcenter-parser/header_id_generator.rb

@@ -72,7 +72,13 @@ class HeaderIdGenerator
   end
 
   def add_default_ids
-    @nodes_ids.each{ |node, id| @nodes_ids[node] = subheader_id(node.content) }
+    @nodes_ids.each do |node, _|
+      if node['id'].to_s.empty?
+        @nodes_ids[node] = subheader_id(node.content)
+      else
+        @nodes_ids[node] = node['id']
+      end
+    end
   end
 
   def subheader_id(content)

data/lib/devcenter-parser/version.rb

@@ -1,3 +1,3 @@
 module DevcenterParser
-  VERSION = '2.2.9'.freeze
+  VERSION = '2.2.10'.freeze
 end

data/test/devcenter-parser_test.rb

@@ -42,11 +42,31 @@ describe 'DevcenterParser' do
       assert_parsing_result md, html
     end
 
-    it 'allows embedding vimeo videos' do
-      src = '<iframe src="https://player.vimeo.com/video/61044807?title=0&amp;byline=0&amp;portrait=0&amp;color=a086ee" width="50" height="281" frameborder="0" webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>'
+    it 'allows embedding vimeo videos when their do-no-track param is set to true' do
+      src = '<iframe src="https://player.vimeo.com/video/143343818?api=1&amp;dnt=true&amp;title=foo" width="50" height="281" frameborder="0" webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>'
       assert_parsing_result src, src
     end
 
+    it 'allows embedding youtube videos from its no-cookies domain' do
+      src = '<iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/123456ABCDEF" frameborder="0" allowfullscreen=""></iframe>'
+      assert_parsing_result src, src
+    end
+
+    it 'removes youtube videos embedded from the with-cookies domain' do
+      src = '<iframe width="560" height="315" src="https://www.youtube.com/embed/123456ABCDEF" frameborder="0" allowfullscreen=""></iframe>'
+      assert_parsing_result src, ''
+    end
+      
+    it 'does not allow embedding vimeo videos when their do-no-track param is set to something different than true' do
+      src = '<iframe src="https://player.vimeo.com/video/143343818?api=1&amp;dnt=foo&amp;title=foo" width="50" height="281" frameborder="0" webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>'
+      assert_parsing_result src, ''
+    end
+
+    it 'does not allow embedding vimeo videos when their do-no-track param is not passed' do
+      src = '<iframe src="https://player.vimeo.com/video/143343818?api=1&&amp;title=foo" width="50" height="281" frameborder="0" webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>'
+      assert_parsing_result src, ''
+    end
+
     it 'allows images' do
       src = '<p><img src="http://nav.heroku.com/images/logos/logo.png" alt="image"></p>'
       assert_parsing_result src, src

data/test/header_id_generator_test.rb

@@ -13,6 +13,12 @@ describe 'HeaderIdGeneratorTest' do
     assert_id result(html), 'h2', 'foo-bar-header-123'
   end
 
+  it 'does not replace existing ids' do
+    html = '<h2 id="foo">Foo Bar</h2><p>Content</p><h3>Baz</h3>'
+    assert_id result(html), 'h2', 'foo'
+    assert_id result(html), 'h3', 'baz'
+  end
+
   it 'generates ids replacing inner non-alphanum chars with dashes' do
     ['Foo Bar', 'Foo-Bar', 'Foo#bar', 'Foo##Bar', 'Foo##Bar', '-$Foo##Bar$-'].each do |title|
       html = "<h2>#{title}</h2>"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devcenter-parser
 version: !ruby/object:Gem::Version
-  version: 2.2.9
+  version: 2.2.10
 platform: ruby
 authors:
 - Heroku
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-03 00:00:00.000000000 Z
+date: 2020-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri