devcenter-parser 1.4.6 → 1.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0830bf58ad740ad5831ebd3d90b7045b3163b337
-  data.tar.gz: fbba31fbf961ced6e017c28c93f753d5d466d28e
+  metadata.gz: ed18f1b8a6e84f0183d3596de7b36aea8e7c3275
+  data.tar.gz: 54c43006783052812ed750c842d502173d3022f8
 SHA512:
-  metadata.gz: 3cf8eb95c7849e2a23976644e32d6f8a45785269b8e1ffda900f473ad7fedddb431e9a7cef847d95774145e6f83d6288194b23f099a8f0e4f4e21db206603a37
-  data.tar.gz: 28f287f3983f65daf07e6e122c2ee6ad3b7502f9adb2acb2ca7bd1516eac6df1a3da2966c022ab8736a32d339840f48060358e3655d6a3c7def45ce221439bf7
+  metadata.gz: b3118fb98d3979c1fae417d05be13eb0e1d6bee53c1a10160ab4b7e0806571b73d9d14e1beda12d84628a65e57502d7b1e1a3804b904e30f98a9b437532e9c42
+  data.tar.gz: 4410ebecb05957bb2a04cc79755c58bd2318522cb0178066a4f84d5b715a71231bb7d40657ef8b7807b950dd70e40ab0abe18224ce59c35489d820f28cc2fd60

data/lib/devcenter-parser.rb

@@ -48,6 +48,7 @@ module DevcenterParser
 
   def self.normalize_markdown(markdown)
     markdown = normalize_newlines(markdown.to_s)
+    markdown = remove_tags_inside_html_comments(markdown)
     separate_consecutive_blockquote_blocks(markdown)
   end
 
@@ -66,6 +67,15 @@ module DevcenterParser
     markdown.lines.map{ |l| l.rstrip }.join("\n")
   end
 
+  def self.remove_tags_inside_html_comments(markdown)
+    markdown.gsub /<!--((.|\s)*?)-->/ do
+      inner = $1
+      inner.gsub!(/\[|\]|\(|\)|\<|\>/,'')
+      "<!--#{inner}-->"
+    end
+  end
+
+
   # Note that Sanitize requires all the elements/attributes downcased
   def self.sanitize_config
     return @@sanitize_config if defined?(@@sanitize_config)

data/lib/devcenter-parser/maruku_parser.rb

@@ -8,6 +8,11 @@ module MarukuParser
     doc
   end
 
+  # This parser seem to deal correctly with tags inside HTML comments
+  def self.remove_tags_inside_html_comments(markdown)
+    markdown
+  end
+
   private
 
   def self.code_blocks(doc)

data/lib/devcenter-parser/version.rb

@@ -1,3 +1,3 @@
 module DevcenterParser
-  VERSION = '1.4.6'
+  VERSION = '1.4.7'
 end

data/test/devcenter-parser_test.rb

@@ -56,6 +56,60 @@ SRC
 
     describe 'github markdown' do
 
+      it 'removes markdown links or nested tags inside HTML comments' do
+        md = <<-MD
+<!-- c1 -->
+1<!-- c2 -->
+<!-- c3 -->2
+3<!-- c4 -->4
+
+One
+
+<!-- [c1](c1) -->
+5<!-- [c2](c2) -->
+<!-- [c3](c3) -->6
+7<!-- [c4](c4) -->8
+
+Two
+
+<!-- <a href="#">c1</a> -->
+9<!-- <a href="#">c2</a> -->
+<!-- <a href="#">c3</a> -->10
+11<!-- <a href="#">c4</a> -->12
+
+Three
+MD
+
+        html = <<-HTML
+<!-- c1 -->
+
+<p>1<!-- c2 -->
+<!-- c3 -->2
+3<!-- c4 -->4</p>
+
+<p>One</p>
+
+<!-- c1c1 -->
+
+<p>5<!-- c2c2 -->
+<!-- c3c3 -->6
+7<!-- c4c4 -->8</p>
+
+<p>Two</p>
+
+<!-- a href="#"c1/a -->
+
+<p>9<!-- a href=&quot;#&quot;c2/a -->
+<!-- a href=&quot;#&quot;c3/a -->10
+11<!-- a href=&quot;#&quot;c4/a -->12</p>
+
+<p>Three</p>
+HTML
+
+        assert_github_result md, html
+      end
+
+
       it 'generates apostrophes from single quotes in plain text' do
         md = "That's it"
         html = "<p>That’s it</p>"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devcenter-parser
 version: !ruby/object:Gem::Version
-  version: 1.4.6
+  version: 1.4.7
 platform: ruby
 authors:
 - Heroku
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-04 00:00:00.000000000 Z
+date: 2014-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: maruku