devcenter-parser 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 !binary "U0hBMQ==":
-  metadata.gz: 00864c53d10600e6cccd5e25c00d06f137f64f7e
-  data.tar.gz: 84f810e795e30e8da6f0a9ac870caf3120b20ef7
+  metadata.gz: 3431e9dabf9d7ca6f57b68cdfdcc3072cb78f6ef
+  data.tar.gz: f598db39a54c8a0d2dc1790a9e892251bc39a474
 !binary "U0hBNTEy":
-  metadata.gz: 0b7343fe802c7a3940b47b8c8ab8651dc694d65db9ecb5eeafe47e862c9707a71415c6a35839dff891f39ca80ef60a0ba68bd69337539d69849013cf53d50beb
-  data.tar.gz: fffb99dddf5e8cb7102a7129d8ee0022e04d6547e419baf8149fb47af5a73b1145d63fe16585d5e8580117a77a7e1840049d69a21459acae5947a873f69bb205
+  metadata.gz: 7c8a1f16903ec6d5c0028e61f28bcdd0953366fc7e549f8b330d4bd027c9687be2bf14a18a0a08b395ee232b4f4e4566c245a6fdb85f3cc98dfd1af2161ae941
+  data.tar.gz: 63cf77e86c96ce0f00bd8d3db171826e04bbf6b6cb62797dbc32ee4dd17efa8f155bb3b0a46da83ba675e3c99681f9918d88f5df844e7d6654f83d42ac1ffb13

data/lib/devcenter-parser.rb

@@ -6,7 +6,7 @@ require 'sanitize'
 
 module DevcenterParser
 
-  VERSION = '1.3.4'
+  VERSION = '1.3.5'
 
   AVAILABLE_FLAVOURS = [:github, :maruku]
 
@@ -23,23 +23,8 @@ module DevcenterParser
     sanitize(html)
   end
 
-  # The current parsers consider something like:
-  # > foo
-  # 
-  # > bar
-  # as a single blockquote, while we want it to be two different ones.
-  # This method adds an empty paragraph between consecutive blocks so parsers process them separately
-  def self.separate_consecutive_blockquote_blocks(markdown)
-    separator = '<p class="devcenter-parser-special-block-separator" style="display:none">&nbsp;</p>'
-    markdown.gsub(/^>(.*)?\s\s>/, '>\1' + "\n\n#{separator}\n\n>")
-  end
-
-  def self.normalize_newlines(markdown)
-    markdown.lines.map{ |l| l.chomp }.join("\n")
-  end
-
   def self.to_unsanitized_html(markdown, flavour)
-    markdown = normalize_newlines(markdown)
+    markdown = normalize_newlines(markdown.to_s)
     markdown = separate_consecutive_blockquote_blocks(markdown)
     doc = case flavour.to_sym
           when :maruku
@@ -71,6 +56,21 @@ module DevcenterParser
 
   private
 
+  # The current parsers consider something like:
+  # > foo
+  # 
+  # > bar
+  # as a single blockquote, while we want it to be two different ones.
+  # This method adds an empty paragraph between consecutive blocks so parsers process them separately
+  def self.separate_consecutive_blockquote_blocks(markdown)
+    separator = '<p class="devcenter-parser-special-block-separator" style="display:none">&nbsp;</p>'
+    markdown.gsub(/^>(.*)?\s\s>/, '>\1' + "\n\n#{separator}\n\n>")
+  end
+
+  def self.normalize_newlines(markdown)
+    markdown.lines.map{ |l| l.chomp }.join("\n")
+  end
+
   def self.github_parser
     @@github_parser ||= Redcarpet::Markdown.new(HTMLWithPantsRenderer, fenced_code_blocks: true, tables: true)
   end

data/test/devcenter-parser_test.rb

@@ -5,15 +5,27 @@ require_relative '../lib/devcenter-parser'
 describe 'DevcenterParser' do
 
   describe '.to_unsanitized_html' do
+    
+    it 'returns empty string for nil input' do
+      assert_parsing_unsanitized_result nil, :maruku, ''
+      assert_parsing_unsanitized_result nil, :maruku, ''
+    end
+
     it 'maintains script tags' do
       md = '<script>alert("hi")</script>'
       assert_parsing_unsanitized_result md, :maruku, md
       assert_parsing_unsanitized_result md, :github, '<script>alert("hi")</script>'
     end
+
   end
 
   describe '.to_html' do
 
+    it 'returns empty string for nil input' do
+      assert_maruku_result nil, ''
+      assert_github_result nil, ''
+    end
+
     it 'raises InvalidMarkdownError when parsing invalid markdown' do
       md = '[foo](bar'
       assert_raises DevcenterParser::InvalidMarkdownError do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devcenter-parser
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Heroku
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-24 00:00:00.000000000 Z
+date: 2013-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: maruku