determinator 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e45f2f0be23112e3ef9836aa58973333a2bb409ac3718d02dcc464f117c4911
-  data.tar.gz: 4489393bdd074715f545a1ce35419f0794fb47ed99a72af90f63d8885cf5c4fe
+  metadata.gz: 107d9dbd0e80451d7934e19754830957a212778442e66704246d824ceb666ff3
+  data.tar.gz: 8c3ef015c15768f2af180a70dac6fc08d1b91fac4386aca6becc93f038861875
 SHA512:
-  metadata.gz: e9c6833636ff9724dd8c6533d532aee97edac0303168bda759d8e2a693221bd4f9d10c55bde8adcd51d8859d35902892188f023a15482aad054a273b426ff169
-  data.tar.gz: ab4692c91ffcceb61018d08c165bf6c3bb7a6873103ffe91c6bf494d64f103a8f9a88e46462291024ea9476a00a9afdcfc32c863ade7807dc112857516e218e4
+  metadata.gz: 449e7fed34b10af10140322795618d1b43db7b6afe77d8e6b355d4e49f7f3f9fe637b7c6f59f78e79b6f0fc632363f191842f6d5cfa12d720ef77e675a1a9cb8
+  data.tar.gz: 2068ca12069b9255c9b91a097f74128af8cf0eb5b4f96e3cfd734eafd9301bb9db9989487444e2c20aaf3cc06468a2c90fb485eff7a49b57480e1c6c73634f71

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# v2.1.0 (2019-07-25)
+
+Feature:
+- Adds support for `app_version` constraints (#60)
+
 # v2.1.0 (2019-05-01)
 
 Feature:

data/README.md

@@ -194,6 +194,20 @@ determinator.which_variant(:my_experiment_name)
 
 Check the example Rails app in the `examples` directory for more information on how to make use of this gem.
 
+### app_version constraint
+
+Feature flags and experiments can also be limited to actors with a [semantic versioning](https://semver.org/) property using an `app_version` property:
+```ruby
+variant = determinator.which_variant(
+  :my_experiment_name,
+  properties: {
+    app_version: "1.2.3"
+  }
+)
+``` 
+The `app_version` constraint for that flag needs to follow ruby gem version constraints. We support the following operators: `>, <, >=, <=, ~>`. For example:
+`app_version: ">=1.2.0"`
+
 ### Using Determinator in RSpec
 
 * Include the  `spec_helper.rb`.

data/lib/determinator/control.rb

@@ -1,5 +1,6 @@
 require 'digest/md5'
 require 'determinator/actor_control'
+require 'semantic'
 
 module Determinator
   class Control
@@ -115,12 +116,41 @@ module Determinator
 
         tg.constraints.reduce(true) do |fit, (scope, *required)|
           present = [*normalised_properties[scope]]
-          fit && (required.flatten & present.flatten).any?
+          fit && matches_requirements?(scope, required, present)
         end
-      # Must choose target group deterministically, if more than one match
+        # Must choose target group deterministically, if more than one match
       }.sort_by { |tg| tg.rollout }.last
     end
 
+    def matches_requirements?(scope, required, present)
+      case scope
+        when "app_version" then has_any_app_version?(required, present)
+        else has_any?(required, present)
+      end
+    end
+
+    def has_any?(required, present)
+      (required.flatten & present.flatten).any?
+    end
+
+    def has_any_app_version?(required, present)
+      invalid_properties = present.flatten.select do |v|
+        !v.match?(Semantic::Version::SemVerRegexp)
+      end
+      invalid_groups = required.flatten.select do |v|
+        !v.match?(/\d/)
+      end
+
+      return false if (invalid_properties + invalid_groups).any?
+
+      present.flatten.any? do |g|
+        given_version = Semantic::Version.new(g)
+        required.flatten.all? do |n|
+          given_version.satisfies?(n)
+        end
+      end
+    end
+
     def actor_identifier(feature, id, guid)
       case feature.bucket_type
       when :id

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-01 00:00:00.000000000 Z
+date: 2019-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -222,8 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Determine which experiments and features a specific actor should see.