destroyed_at 1.0.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 04939466ff647a0d0017648e6c952b9223b192d1
-  data.tar.gz: f4063081197fd1557dfee1128da533be633eef54
+  metadata.gz: 7f228171fc8186eacb4a2b03091ac1da77801e98
+  data.tar.gz: 0e4ab1aadcc01078dd0b1decd2efaa2087131ee8
 SHA512:
-  metadata.gz: 0aa141594c6795094f7090832560cd0e51ed8f77444a29161ee8e9df911c9637f06490c0e4a746fcfbdf9a754aa8a2a1431a8277bc49ce6e264304dce179cf86
-  data.tar.gz: 9f03d073154ff339e9c56f920eef9580198ec3d3a45f577aec105bd6eea5e6cedd337f8d896d13ae26b5f8f4579ee982a42adee34383f83d444c87ad746e41d1
+  metadata.gz: b3c50322b6247e7baee90999128c42a8731812c4d37ba346e183f46c3dc54d6208740e5eacbf2c937a840f1e561d4ee5841cd5af7cae5824a7e5bf880e4a531f
+  data.tar.gz: 86f3b2fe4a8c15d9c5a1edb217161fdbe9377bfdcc970560d787dc6b63a7740e14330eee37a20f00b819d514253be378fd5a0dc7fce0652286b7aacf6e33ab6a

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.0.0
+* Associated models that do not include `DestroyedAt` will now be
+  **deleted** via `dependent: :destroy`. Previously, this was only the
+behavior for child records; however, child records can now delete the
+parent record (in accordance with default ActiveRecord behavior).
+
 ## 1.0.2
 * Fixes an issue in which
   `DestroyedAt::BelongsToAssociation#handle_dependency` was not deriving
@@ -6,7 +12,7 @@ an error for the wrong number of arguments. Thanks to
 [harmdewit](https://github.com/harmdewit) for catching this!
 
 ## 1.0.1
-* Fixes an issue with where the incorrect arguments were being passed
+* Fixes an issue where the incorrect arguments were being passed
   from inside the `BelongsToAssociation` and `HasOneAssociation`, as
 reported by [anarchocurious](https://github.com/anarchocurious)
 

data/README.md

@@ -71,14 +71,9 @@ user.destroyed_at
 ```
 
 #### Warning: Dependent relations with destroy ####
-Be careful when destroying parent relationships that have `dependent:
-:destroy`. If the child
-relationship does not also `include DestroyedAt`, then when you call
-`#destroy` on the parent instance, you will delete the child record,
-rather than simply marking it `destroyed_at`.
-
-The same goes for destroying through relations that omit `include
-DestroyedAt`, even if the parent and child models include the mixin.
+Be careful when destroying models that have `dependent:
+:destroy`. This will **delete**, not destroy, the associated model if
+said model does not `include DestroyedAt`. 
 
 ### Restoring ####
 When you'd like to "restore" a record, call the `#restore` method on

data/lib/destroyed_at.rb

@@ -17,7 +17,8 @@ module DestroyedAt
   def self.destroy_target_of_association(owner, target)
     if target.respond_to?(:destroyed_at) && owner.respond_to?(:destroyed_at)
       target.destroy(owner.destroyed_at)
-    elsif target.respond_to?(:destroyed_at)
+    else
+      # this will delete the target if DestroyedAt is not included.
       target.destroy
     end
   end

data/lib/destroyed_at/version.rb

@@ -1,3 +1,3 @@
 module DestroyedAt
-  VERSION = "1.0.2"
+  VERSION = "2.0.0"
 end

data/test/destroyed_at_test.rb

@@ -196,13 +196,13 @@ describe 'non destroyed-at models' do
 end
 
 describe 'destroying a child that destroys its parent on destroy' do
-  it 'does not destroy a parent record without DestroyedAt' do
+  it 'destroys the parent record' do
     parent = Person.create!
     child = DestructiveChild.create!(person: parent)
 
     child.destroy
 
-    assert_equal(1, Person.count, 'Person must be one')
+    assert_equal(0, Person.count, 'Person must be one')
     assert_equal(0, DestructiveChild.count, 'DestructiveChild must be zero')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: destroyed_at
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Michael Dupuis Jr.